From patchwork Wed Dec 7 20:46:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Asutosh Das X-Patchwork-Id: 631831 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57133C63708 for ; Wed, 7 Dec 2022 20:47:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229787AbiLGUr1 (ORCPT ); Wed, 7 Dec 2022 15:47:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229786AbiLGUrX (ORCPT ); Wed, 7 Dec 2022 15:47:23 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1945E6868D; Wed, 7 Dec 2022 12:47:13 -0800 (PST) Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2B7Itgbv022450; Wed, 7 Dec 2022 20:46:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=qcppdkim1; bh=U8uY8us+snoKmlwkDFOiH0TPjtA7d31xQ8phTYZl3/k=; b=VXUkM2ba2We4OhuABvWYbqSDAq5m/rr+VXT2Wd9pHNmWxcqlHEcZT6Pri0YWJY31hjdd bbkR3NtBKH4Dky6i4eLrDGXpvX62pm3pwPB6d9tqpI0eCn6OzbBbrcKaVfPJEaJsTSpS w44pRmVh/ZV7TUcHCcbWC5aDEE0bzCUgP/7HA0sJN/e+aVUHXg9XIcYLQH7ysh5vj+kg SOMmvgBDg8MoRBgTj2zSdfmfgmj94yc9L4NTsBBCCYNEq4jTG8RRG4vvUUXHtGXggBBp 4dIRmz/XTroWqEgvWQ/NK1JuLXiJI/xQW9jSCgjoeArVH4FlhM2kUOAjEn0fuNODfKoW Tg== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3mapg51qrx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 07 Dec 2022 20:46:44 +0000 Received: from nasanex01a.na.qualcomm.com ([10.52.223.231]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 2B7KkhKZ012261 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 7 Dec 2022 20:46:43 GMT Received: from asutoshd-linux1.qualcomm.com (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 7 Dec 2022 12:46:42 -0800 From: Asutosh Das To: , , CC: , , , , , , , , , Asutosh Das , Subject: [PATCH v10 00/16] Add Multi Circular Queue Support Date: Wed, 7 Dec 2022 12:46:11 -0800 Message-ID: X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: K8JyG7mIY1tgWprqM3nHbY_5ufDDsi0d X-Proofpoint-GUID: K8JyG7mIY1tgWprqM3nHbY_5ufDDsi0d X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-07_09,2022-12-07_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 mlxlogscore=999 malwarescore=0 spamscore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212070174 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Hi Martin, This patch series is an implementation of UFS Multi-Circular Queue. Please consider this series for next merge window. This implementation has been verified on a Qualcomm & MediaTek platform. Thanks, Asutosh UFS Multi-Circular Queue (MCQ) has been added in UFSHCI v4.0 to improve storage performance. The implementation uses the shared tagging mechanism so that tags are shared among the hardware queues. The number of hardware queues is configurable. This series doesn't include the ESI implementation for completion handling. Please take a look and let us know your thoughts. v9 -> v10: - Fix few checkpatch warnings - Use div_u64() instead of direct division in ufshcd_mcq_get_tag() to fix a LKP warning v8 -> v9: - Added missing Reviewed-by tags. v7 -> v8: - Addressed Eddie's comments v6 -> v7: - Added missing Reviewed-by tags. v5 -> v6: - Addressed Mani's comments - Addressed Bart's comments v4 -> v5: - Fixed failure to fallback to SDB during initialization - Fixed failure when rpm-lvl=5 in the ufshcd_host_reset_and_restore() path - Improved ufshcd_mcq_config_nr_queues() to handle different configurations - Addressed Bart's comments - Verified read/write using FIO, clock gating, runtime-pm[lvl=3, lvl=5] v3 -> v4: - Added a kernel module parameter to disable MCQ mode - Added Bart's reviewed-by tag for some patches - Addressed Bart's comments v2 -> v3: - Split ufshcd_config_mcq() into ufshcd_alloc_mcq() and ufshcd_config_mcq() - Use devm_kzalloc() in ufshcd_mcq_init() - Free memory and resource allocation on error paths - Corrected typos in code comments v1 -> v2: - Added a non MCQ related change to use a function to extrace ufs extended feature - Addressed Mani's comments - Addressed Bart's comments v1: - Split the changes - Addressed Bart's comments - Addressed Bean's comments * RFC versions: v2 -> v3: - Split the changes based on functionality - Addressed queue configuration issues - Faster SQE tail pointer increments - Addressed comments from Bart and Manivannan v1 -> v2: - Enabled host_tagset - Added queue num configuration support - Added one more vops to allow vendor provide the wanted MAC - Determine nutrs and can_queue by considering both MAC, bqueuedepth and EXT_IID support - Postponed MCQ initialization and scsi_add_host() to async probe - Used (EXT_IID, Task Tag) tuple to support up to 4096 tasks (theoretically) Asutosh Das (16): ufs: core: Optimize duplicate code to read extended feature ufs: core: Probe for ext_iid support ufs: core: Introduce Multi-circular queue capability ufs: core: Defer adding host to scsi if mcq is supported ufs: core: mcq: Add support to allocate multiple queues ufs: core: mcq: Configure resource regions ufs: core: mcq: Calculate queue depth ufs: core: mcq: Allocate memory for mcq mode ufs: core: mcq: Configure operation and runtime interface ufs: core: mcq: Use shared tags for MCQ mode ufs: core: Prepare ufshcd_send_command for mcq ufs: core: mcq: Find hardware queue to queue request ufs: core: Prepare for completion in mcq ufs: mcq: Add completion support of a cqe ufs: core: mcq: Add completion support in poll ufs: core: mcq: Enable Multi Circular Queue drivers/ufs/core/Makefile | 2 +- drivers/ufs/core/ufs-mcq.c | 415 +++++++++++++++++++++++++++++++++++++++++ drivers/ufs/core/ufshcd-priv.h | 92 ++++++++- drivers/ufs/core/ufshcd.c | 395 ++++++++++++++++++++++++++++++++------- drivers/ufs/host/ufs-qcom.c | 146 +++++++++++++++ drivers/ufs/host/ufs-qcom.h | 5 + include/ufs/ufs.h | 6 + include/ufs/ufshcd.h | 128 +++++++++++++ include/ufs/ufshci.h | 64 +++++++ 9 files changed, 1186 insertions(+), 67 deletions(-) create mode 100644 drivers/ufs/core/ufs-mcq.c