From patchwork Wed Feb 24 05:13:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Asutosh Das \(asd\)" X-Patchwork-Id: 387052 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BE2CC433E0 for ; Wed, 24 Feb 2021 05:14:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A1AD64EBB for ; Wed, 24 Feb 2021 05:14:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232263AbhBXFOl (ORCPT ); Wed, 24 Feb 2021 00:14:41 -0500 Received: from labrats.qualcomm.com ([199.106.110.90]:53087 "EHLO labrats.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229466AbhBXFOk (ORCPT ); Wed, 24 Feb 2021 00:14:40 -0500 IronPort-SDR: cRVMrvwArk4MIYvqzRgkaaNxbEsJ1YoYpUEwc2U9Zk8+hnl8ISOpAc9dkxGInbdkHhW8GasYki JjRtTt9td9hL5+wqiOapCKLoPfReeziWMLft8AGv2ZB6oah5WVKxiGDYbfqHbRJMf7xfXgvYwo Cw0kJORh8rHJrqVockS5tnx8hx8dlbFApsoFLgUaT7Bo5W15yCzXtDxQAn/ilOE9Hca+ItbToE NZNvafTVAdTHQzopP7mclb1Rz3KRXy3OBKkke0HsM6IKvRENc2nWu8l02JqvVN76HvoYwi1RzG dQw= X-IronPort-AV: E=Sophos;i="5.81,201,1610438400"; d="scan'208";a="29674152" Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by labrats.qualcomm.com with ESMTP; 23 Feb 2021 21:13:59 -0800 X-QCInternal: smtphost Received: from wsp769891wss.qualcomm.com (HELO stor-presley.qualcomm.com) ([192.168.140.85]) by ironmsg05-sd.qualcomm.com with ESMTP; 23 Feb 2021 21:13:59 -0800 Received: by stor-presley.qualcomm.com (Postfix, from userid 92687) id 1977D21A10; Tue, 23 Feb 2021 21:13:59 -0800 (PST) From: Asutosh Das To: cang@codeaurora.org, martin.petersen@oracle.com, linux-scsi@vger.kernel.org Cc: Asutosh Das , linux-arm-msm@vger.kernel.org Subject: [PATCH v5 0/2] Enable power management for ufs wlun Date: Tue, 23 Feb 2021 21:13:53 -0800 Message-Id: X-Mailer: git-send-email 2.7.4 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org This patch attempts to fix a deadlock in ufs while sending SSU. Recently, blk_queue_enter() added a check to not process requests if the queue is suspended. That leads to a resume of the associated device which is suspended. In ufs, that device is ufs device wlun and it's parent is ufs_hba. This resume tries to resume ufs device wlun which in turn tries to resume ufs_hba, which is already in the process of suspending, thus causing a deadlock. This patch takes care of: * Suspending the ufs device lun only after all other luns are suspended * Sending SSU during ufs device wlun suspend * Clearing uac for rpmb and ufs device wlun * Not sending commands to the device during host suspend v4 -> v5: - Addressed Adrian's comments * Used the rpmb driver contributed by Adrian * Runtime-resume the ufs device during suspend to honor spm-lvl * Unregister the scsi_driver in ufshcd_remove() * Currently shutdown() puts the ufs device to power-down mode so, just removed ufshcd_pci_poweroff() * Quiesce the scsi device during shutdown instead of remove v3 RFC -> v4: - Addressed Bart's comments * Except that I didn't get any checkpatch failures - Addressed Avri's comments - Addressed Adrian's comments * Added a check for deepsleep power mode * Removed a couple of forward declarations * Didn't separate the scsi drivers because in rpmb case it just sends uac in resume and it seemed pretty neat to me. - Added sysfs changes to resume the devices before accessing Asutosh Das (2): scsi: ufs: Enable power management for wlun ufs: sysfs: Resume the proper scsi device drivers/scsi/ufs/ufs-qcom.c | 2 + drivers/scsi/ufs/ufs-sysfs.c | 26 ++- drivers/scsi/ufs/ufshcd-pci.c | 24 -- drivers/scsi/ufs/ufshcd-pltfrm.c | 29 +++ drivers/scsi/ufs/ufshcd-pltfrm.h | 4 + drivers/scsi/ufs/ufshcd.c | 491 +++++++++++++++++++++++++++++++-------- drivers/scsi/ufs/ufshcd.h | 5 + include/trace/events/ufs.h | 20 ++ 8 files changed, 469 insertions(+), 132 deletions(-)