From patchwork Mon Feb 22 23:04:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Asutosh Das \(asd\)" X-Patchwork-Id: 386016 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F29B1C433E6 for ; Mon, 22 Feb 2021 23:05:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC9E664E07 for ; Mon, 22 Feb 2021 23:05:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230134AbhBVXFs (ORCPT ); Mon, 22 Feb 2021 18:05:48 -0500 Received: from labrats.qualcomm.com ([199.106.110.90]:8655 "EHLO labrats.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229852AbhBVXFs (ORCPT ); Mon, 22 Feb 2021 18:05:48 -0500 IronPort-SDR: AoFooxwPHGUao4LQaHzBP9Fbc7zjypQcgH/S09/M9UyJMZGr6xW5EtHZ0GWt/0E3uwtWu7ac6M hH8bdCQqt/tfrzxT0Cmzz8c/pJ2sdJSY55wyHdm8GnMUevv1Ql+viEJaE+HbujrVafcI5pMDMS 249BZCkNC/qfjbCDzDy3MCpXTM0iEIKE9s5VEEpyK55mCAaj0YWZhyFVpDJY4K8cXJ3AjSaI2S XyBavAxTdOCxV1Kp0rw6GFWSxqoWMKCfmTKmo4nkirYQ50mZIwWrEmg2XNPrBYL53qLlRxRT/K 4To= X-IronPort-AV: E=Sophos;i="5.81,198,1610438400"; d="scan'208";a="47786235" Received: from unknown (HELO ironmsg03-sd.qualcomm.com) ([10.53.140.143]) by labrats.qualcomm.com with ESMTP; 22 Feb 2021 15:05:07 -0800 X-QCInternal: smtphost Received: from stor-presley.qualcomm.com ([192.168.140.85]) by ironmsg03-sd.qualcomm.com with ESMTP; 22 Feb 2021 15:05:02 -0800 Received: by stor-presley.qualcomm.com (Postfix, from userid 92687) id E0BA021A19; Mon, 22 Feb 2021 15:05:01 -0800 (PST) From: Asutosh Das To: cang@codeaurora.org, martin.petersen@oracle.com, linux-scsi@vger.kernel.org Cc: Asutosh Das , linux-arm-msm@vger.kernel.org Subject: [PATCH v4 0/2] Enable power management for ufs wlun Date: Mon, 22 Feb 2021 15:04:48 -0800 Message-Id: X-Mailer: git-send-email 2.7.4 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org This patch attempts to fix a deadlock in ufs while sending SSU. Recently, blk_queue_enter() added a check to not process requests if the queue is suspended. That leads to a resume of the associated device which is suspended. In ufs, that device is ufs device wlun and it's parent is ufs_hba. This resume tries to resume ufs device wlun which in turn tries to resume ufs_hba, which is already in the process of suspending, thus causing a deadlock. This patch takes care of: * Suspending the ufs device lun only after all other luns are suspended * Sending SSU during ufs device wlun suspend * Clearing uac for rpmb and ufs device wlun * Not sending commands to the device during host suspend v3 RFC -> v4: - Addressed Bart's comments * Except that I didn't get any checkpatch failures - Addressed Avri's comments - Addressed Adrian's comments * Added a check for deepsleep power mode * Removed a couple of forward declarations * Didn't separate the scsi drivers because in rpmb case it just sends uac in resume and it seemed pretty neat to me. - Added sysfs changes to resume the devices before accessing Asutosh Das (2): scsi: ufs: Enable power management for wlun ufs: sysfs: Resume the proper scsi device drivers/scsi/ufs/ufs-sysfs.c | 26 +-- drivers/scsi/ufs/ufshcd.c | 455 ++++++++++++++++++++++++++++++++++--------- drivers/scsi/ufs/ufshcd.h | 4 + include/trace/events/ufs.h | 20 ++ 4 files changed, 397 insertions(+), 108 deletions(-)