From patchwork Tue May 20 22:30:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 891637 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32925244690; Tue, 20 May 2025 22:31:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747780272; cv=none; b=Qn3bN5WNyYKbh0ba/tdl7FrEaOxDg6gbzz5f0z/3TtgtHwoA1KXLRaWYWxfV/QPLYF/8Mk/J97uswQecIC/NIqHJo0nVWPBba7PxiLlLFcG21hYbuTtTaiZT1y1lpBbpQmqKR7yr/10NwAC/HBzjDGIRqPHlXA78tq9xejx1LlM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747780272; c=relaxed/simple; bh=V5uf6YlgPTr2U418QetNaAAYXDxQz7VW/iPHa55aWbE=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=bXQ8+gKgnlvgq2OYRZV1mCVlw+P1rn7coeiEKuRWx6uevZeYZKbuhQmxc9TVI++CufL3lrfteGgvf5lB4Kd3YlIaGvP4JPMSpFDEP8zJqdnW0pZRucvIA6NUgtaqVk300/jYVRT5QOCmMK+3Dkh5NCKJfGjsRk5meOeATKQ2FOQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=c8JF6yMZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="c8JF6yMZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B18DAC4AF0C; Tue, 20 May 2025 22:31:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747780271; bh=V5uf6YlgPTr2U418QetNaAAYXDxQz7VW/iPHa55aWbE=; h=From:To:Cc:Subject:Date:From; b=c8JF6yMZ2CfkNKv+fj/emGvRG+4AyBoiThhjNe5giOiqWyOZw3S7kTIX/1n0SD9Jj suGB+ONLcSBgGXRUppLShhfbiSMiz01dT9hURbyiqqUgl9uZIL9h5Qb1w5mz9fq2g3 +3KDq2sAocKLZIJ+6qf0tJKmZvhm5Ld//TaXafA9rqLXQ0D01Gikn2kmFDNEFisM35 hYRp9zZ9CfpjFon3LCztZHDMjSgmV62M8vHILqeu31B7msusbLOVZEM7R0MiAGCaAv doSIfmG9RO12LRHELfyIyHykmNE5dHzqAAGdqhZvqPBN5eiLTNrMtO52XzsHkdfs9B 5R1K5BHNnA5CA== From: Kees Cook To: Kuniyuki Iwashima Cc: Kees Cook , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , "Martin K. Petersen" , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Mike Christie , Max Gurtovoy , Maurizio Lombardi , Dmitry Bogdanov , Mingzhe Zou , Christophe Leroy , Simon Horman , "Dr. David Alan Gilbert" , Andrew Lunn , Stanislav Fomichev , Cosmin Ratiu , Lei Yang , Ido Schimmel , Samuel Mendoza-Jonas , Paul Fertser , Alexander Aring , Stefan Schmidt , Miquel Raynal , Hayes Wang , Douglas Anderson , Grant Grundler , Jay Vosburgh , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Jiri Pirko , Eric Biggers , Milan Broz , Philipp Hahn , Ard Biesheuvel , Al Viro , Ahmed Zaki , Alexander Lobakin , Xiao Liang , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, netdev@vger.kernel.org, linux-wpan@vger.kernel.org, linux-usb@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-hardening@vger.kernel.org Subject: [PATCH 0/7] net: Convert dev_set_mac_address() to struct sockaddr_storage Date: Tue, 20 May 2025 15:30:59 -0700 Message-Id: <20250520222452.work.063-kees@kernel.org> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2018; i=kees@kernel.org; h=from:subject:message-id; bh=V5uf6YlgPTr2U418QetNaAAYXDxQz7VW/iPHa55aWbE=; b=owGbwMvMwCVmps19z/KJym7G02pJDBm6TCseuGUb11+RCOzXO7lCOWzlOiOBrx4L36js6ygWL q07/N2go5SFQYyLQVZMkSXIzj3OxeNte7j7XEWYOaxMIEMYuDgFYCKzBRgZ/tQsZlVS1pRfEbvj 8Caz4t6e8B9HuKfWHNo4c+GV9lVGrxj+WV4zLXjF52Tya+X2me5K9ydwBjwu97i7/jWv+FeeaQG 6zAA= X-Developer-Key: i=kees@kernel.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Hi, As part of the effort to allow the compiler to reason about object sizes, we need to deal with the problematic variably sized struct sockaddr, which has no internal runtime size tracking. In much of the network stack the use of struct sockaddr_storage has been adopted. Continue the transition toward this for more of the internal APIs. Specifically: - inet_addr_is_any() - netif_set_mac_address() - dev_set_mac_address() Only 3 callers of dev_set_mac_address() needed adjustment; all others were already using struct sockaddr_storage internally. -Kees Kees Cook (7): net: core: Convert inet_addr_is_any() to sockaddr_storage net: core: Switch netif_set_mac_address() to struct sockaddr_storage net/ncsi: Use struct sockaddr_storage for pending_mac ieee802154: Use struct sockaddr_storage with dev_set_mac_address() net: usb: r8152: Convert to use struct sockaddr_storage internally net: core: Convert dev_set_mac_address() to struct sockaddr_storage rtnetlink: do_setlink: Use struct sockaddr_storage include/linux/inet.h | 2 +- include/linux/netdevice.h | 4 +-- net/ncsi/internal.h | 2 +- drivers/net/bonding/bond_alb.c | 8 ++--- drivers/net/bonding/bond_main.c | 10 +++--- drivers/net/hyperv/netvsc_drv.c | 6 ++-- drivers/net/macvlan.c | 10 +++--- drivers/net/team/team_core.c | 2 +- drivers/net/usb/r8152.c | 52 +++++++++++++++-------------- drivers/nvme/target/rdma.c | 2 +- drivers/nvme/target/tcp.c | 2 +- drivers/target/iscsi/iscsi_target.c | 2 +- net/core/dev.c | 11 +++--- net/core/dev_api.c | 6 ++-- net/core/rtnetlink.c | 19 +++-------- net/core/utils.c | 8 ++--- net/ieee802154/nl-phy.c | 6 ++-- net/ncsi/ncsi-rsp.c | 18 +++++----- 18 files changed, 79 insertions(+), 91 deletions(-)