mbox series

[0/6] SCSI disk source code cleanup

Message ID 20240730210042.266504-1-bvanassche@acm.org
Headers show
Series SCSI disk source code cleanup | expand

Message

Bart Van Assche July 30, 2024, 9 p.m. UTC 
Hi Martin,

This patch series removes multiple forward declarations from the SCSI disk (sd)
driver and also makes error messages easier to find with grep. Please consider
this patch series for the next merge window.

Thanks,

Bart.

Bart Van Assche (6):
  scsi: sd: Move the sd_remove() function definition
  scsi: sd: Move the sd_config_discard() function definition
  scsi: sd: Move the sd_config_write_same() function definition
  scsi: sd: Move the scsi_disk_release() function definition
  scsi: sd: Move the sd_fops definition
  scsi: sd: Do not split error messages

 drivers/scsi/sd.c | 411 ++++++++++++++++++++++------------------------
 1 file changed, 198 insertions(+), 213 deletions(-)

Comments

Damien Le Moal July 30, 2024, 11:43 p.m. UTC | #1 
On 7/31/24 06:00, Bart Van Assche wrote:
> Move the sd_config_write_same() function definition such that its forward
> declaration can be removed.
> 
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Himanshu Madhani July 31, 2024, 1:12 a.m. UTC | #2 
On 7/30/24 14:00, Bart Van Assche wrote:
> Hi Martin,
> 
> This patch series removes multiple forward declarations from the SCSI disk (sd)
> driver and also makes error messages easier to find with grep. Please consider
> this patch series for the next merge window.
> 
> Thanks,
> 
> Bart.
> 
> Bart Van Assche (6):
>    scsi: sd: Move the sd_remove() function definition
>    scsi: sd: Move the sd_config_discard() function definition
>    scsi: sd: Move the sd_config_write_same() function definition
>    scsi: sd: Move the scsi_disk_release() function definition
>    scsi: sd: Move the sd_fops definition
>    scsi: sd: Do not split error messages
> 
>   drivers/scsi/sd.c | 411 ++++++++++++++++++++++------------------------
>   1 file changed, 198 insertions(+), 213 deletions(-)
> 
> 

For the series.

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>