| Message ID | 20240628070030.30929-1-peter.wang@mediatek.com |
|---|---|
| Headers | show |
| Series | ufs: core: fix ufshcd_abort_all racing issue | expand |
On 6/28/24 12:00 AM, peter.wang@mediatek.com wrote: > When ufshcd_abort_one racing with complete ISR, > the completed tag of request's mq_hctx pointer will set NULL by ISR. > Same as previous patch race condition. > Return success when request is completed by ISR beacuse ufshcd_abort_one > dose't need do anything. dose't -> doesn't. Anyway: Reviewed-by: Bart Van Assche <bvanassche@acm.org>
On Fri, 28 Jun 2024 15:00:28 +0800, peter.wang@mediatek.com wrote: > This series fixes race condition KE in ufshcd_err_handler, which call > ufshcd_abort_all abort an already completed request by ISR in MCQ mode. > > V3: > - Modify ufshcd_mcq_req_to_hwq to distinguish cmd is completed or not > - Split two patches and add more race description. > > [...] Applied to 6.10/scsi-fixes, thanks! [1/2] ufs: core: fix ufshcd_clear_cmd racing issue https://git.kernel.org/mkp/scsi/c/9307a998cb98 [2/2] ufs: core: fix ufshcd_abort_one racing issue https://git.kernel.org/mkp/scsi/c/74736103fb41
From: Peter Wang <peter.wang@mediatek.com> This series fixes race condition KE in ufshcd_err_handler, which call ufshcd_abort_all abort an already completed request by ISR in MCQ mode. V3: - Modify ufshcd_mcq_req_to_hwq to distinguish cmd is completed or not - Split two patches and add more race description. V2: - Change patch description and add Fixes/Cc tag Peter Wang (2): ufs: core: fix ufshcd_clear_cmd racing issue ufs: core: fix ufshcd_abort_one racing issue drivers/ufs/core/ufs-mcq.c | 11 ++++++----- drivers/ufs/core/ufshcd.c | 2 ++ 2 files changed, 8 insertions(+), 5 deletions(-)