mbox series

[0/2] block, scsi: Small improvements for blk_mq_alloc_queue() usage

Message ID 20240524084829.2132555-1-john.g.garry@oracle.com
Headers show
Series block, scsi: Small improvements for blk_mq_alloc_queue() usage | expand

Message

John Garry May 24, 2024, 8:48 a.m. UTC 
A couple of small improvements to not manually set q->queuedata.

I asked Himanshu (cc'ed) to test the bsg-lib.c change as I have no setup
to test.

Based on mkp-scsi 6.10 staging queue at e4f5f8298cf6.

John Garry (2):
  scsi: core: Pass sdev to blk_mq_alloc_queue()
  scsi: bsg: Pass dev to blk_mq_alloc_queue()

 block/bsg-lib.c          | 3 +--
 drivers/scsi/scsi_scan.c | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

Comments

Himanshu Madhani May 29, 2024, 8:30 p.m. UTC | #1 
On 5/24/24 01:48, John Garry wrote:
> A couple of small improvements to not manually set q->queuedata.
> 
> I asked Himanshu (cc'ed) to test the bsg-lib.c change as I have no setup
> to test.
> 
> Based on mkp-scsi 6.10 staging queue at e4f5f8298cf6.
> 
> John Garry (2):
>    scsi: core: Pass sdev to blk_mq_alloc_queue()
>    scsi: bsg: Pass dev to blk_mq_alloc_queue()
> 
>   block/bsg-lib.c          | 3 +--
>   drivers/scsi/scsi_scan.c | 3 +--
>   2 files changed, 2 insertions(+), 4 deletions(-)
> 

Changes looks good for this series. I tested basic driver load/unload, 
as my setup is not connected to any Switch.

Tested-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Martin K. Petersen May 31, 2024, 12:23 a.m. UTC | #2 
John,

> A couple of small improvements to not manually set q->queuedata.

Applied to 6.11/scsi-staging, thanks!
Martin K. Petersen June 5, 2024, 2:32 a.m. UTC | #3 
On Fri, 24 May 2024 08:48:27 +0000, John Garry wrote:

> A couple of small improvements to not manually set q->queuedata.
> 
> I asked Himanshu (cc'ed) to test the bsg-lib.c change as I have no setup
> to test.
> 
> Based on mkp-scsi 6.10 staging queue at e4f5f8298cf6.
> 
> [...]

Applied to 6.11/scsi-queue, thanks!

[1/2] scsi: core: Pass sdev to blk_mq_alloc_queue()
      https://git.kernel.org/mkp/scsi/c/e7c09df178f7
[2/2] scsi: bsg: Pass dev to blk_mq_alloc_queue()
      https://git.kernel.org/mkp/scsi/c/41b757425203