| Message ID | 20240209-msm8996-fix-ufs-v1-0-107b52e57420@linaro.org |
|---|---|
| Headers | show |
| Series | scsi: ufs: qcom: fix UFSDHCD support on MSM8996 platform | expand |
On 9.02.2024 22:50, Dmitry Baryshkov wrote: > Since the commit b4e13e1ae95e ("scsi: ufs: qcom: Add multiple frequency > support for MAX_CORE_CLK_1US_CYCLES") the Qualcomm UFS driver uses > core_clk_unipro values from frequency table to calculate cycles_in_1us. > The DT file for MSM8996 passed 0 HZ frequencies there, resulting in > broken UFS support on that platform. Fix the corresponding clock values > in the frequency table. > > Suggested-by: Nitin Rawat <quic_nitirawa@quicinc.com> > Fixes: 57fc67ef0d35 ("arm64: dts: qcom: msm8996: Add ufs related nodes") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- I'd reword the commit title but okay Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On Sat, 10 Feb 2024 at 00:29, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > On 9.02.2024 22:50, Dmitry Baryshkov wrote: > > Follow the example of other platforms and specify core_clk frequencies > > in the frequency table in addition to the core_clk_src frequencies. The > > driver should be setting the leaf frequency instead of some interim > > clock freq. > > > > Suggested-by: Nitin Rawat <quic_nitirawa@quicinc.com> > > Fixes: 57fc67ef0d35 ("arm64: dts: qcom: msm8996: Add ufs related nodes") > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > --- > > 3.18 says the clock can even go as high as 240000000 Yeah. I just copied the core_clk_src specs. We can bump the clocks when this gets rewritten to use OPP tables.
On 09/02/2024 22:50, Dmitry Baryshkov wrote: > Describe the second RX lane used by the UFS controller on MSM8996 > platform. > > Fixes: 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema") Your commit msg does not explain why this is a fix. > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > index 10c146424baa..f1de3244b473 100644 > --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > @@ -43,11 +43,11 @@ properties: > > clocks: > minItems: 8 > - maxItems: 11 > + maxItems: 12 > > clock-names: > minItems: 8 > - maxItems: 11 > + maxItems: 12 Best regards, Krzysztof
On Sun, 11 Feb 2024 at 16:02, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 09/02/2024 22:50, Dmitry Baryshkov wrote: > > Describe the second RX lane used by the UFS controller on MSM8996 > > platform. > > > > Fixes: 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema") > > Your commit msg does not explain why this is a fix. .. and it is probably unnecessary, as msm8996 has 'lanes-per-direcion = <1>;' I'll drop this for v2. > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > --- > > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 11 ++++++----- > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > > index 10c146424baa..f1de3244b473 100644 > > --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > > +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > > @@ -43,11 +43,11 @@ properties: > > > > clocks: > > minItems: 8 > > - maxItems: 11 > > + maxItems: 12 > > > > clock-names: > > minItems: 8 > > - maxItems: 11 > > + maxItems: 12 > > > Best regards, > Krzysztof >
First several patches target fixing the UFS support on the Qualcomm MSM8996 / APQ8096 platforms, broken by the commit b4e13e1ae95e ("scsi: ufs: qcom: Add multiple frequency support for MAX_CORE_CLK_1US_CYCLES"). Last two patches clean up the UFS DT device on that platform to follow the bindings on other MSM8969 platforms. If such breaking change is unacceptable, they can be simply ignored, merging fixes only. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- Dmitry Baryshkov (8): dt-bindings: ufs: qcom,ufs: add second RX lane on MSM8996 platform scsi: ufs: qcom: provide default cycles_in_1us value arm64: dts: qcom: msm8996: unbreak UFS HCD support arm64: dts: qcom: msm8996: specify UFS core_clk frequencies arm64: dts: qcom: msm8996: add second UFS RX lane on MSM8996 platform arm64: dts: qcom: msm8996: set GCC_UFS_ICE_CORE_CLK freq directly dt-bindings: ufs: qcom,ufs: drop source clock entries arm64: dts: qcom: msm8996: drop source clock entries from the UFS node Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 13 ++++++------- arch/arm64/boot/dts/qcom/msm8996.dtsi | 13 +++++-------- drivers/ufs/host/ufs-qcom.c | 6 ++++-- 3 files changed, 15 insertions(+), 17 deletions(-) --- base-commit: 13e3d132c10bbb94e4efe7824f4aff317969cd17 change-id: 20240209-msm8996-fix-ufs-f80ae6d4d8cf Best regards,