mbox series

[v3,0/2] cleanup patch

Message ID 20231018113746.1940197-1-haowenchao2@huawei.com
Headers show
Series cleanup patch | expand

Message

Wenchao Hao Oct. 18, 2023, 11:37 a.m. UTC 
This is a cleanup patchset, no logic changed.

The first patch cleanup scsi_dev_queue_ready();
The second patch add comment to tell callback target_destroy of
scsi_host_template must not sleep.

V3:
  - Update comments suggested by Bart

V2:
  - Tell which spinlock is held in comment of target_destroy

Wenchao Hao (2):
  scsi: core: cleanup scsi_dev_queue_ready()
  scsi: Add comment of target_destroy in scsi_host_template

 drivers/scsi/scsi_lib.c  | 32 +++++++++++++++-----------------
 include/scsi/scsi_host.h |  3 +++
 2 files changed, 18 insertions(+), 17 deletions(-)

Comments

Bart Van Assche Oct. 18, 2023, 6:03 p.m. UTC | #1 
On 10/18/23 04:37, Wenchao Hao wrote:
> Add comment to tell callback function target_destroy of
> scsi_host_template must not sleep.
> 
> Signed-off-by: Wenchao Hao <haowenchao2@huawei.com>
> ---
>   include/scsi/scsi_host.h | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h
> index 49f768d0ff37..2c61dd30d766 100644
> --- a/include/scsi/scsi_host.h
> +++ b/include/scsi/scsi_host.h
> @@ -245,6 +245,9 @@ struct scsi_host_template {
>   	 * midlayer calls this point so that the driver may deallocate
>   	 * and terminate any references to the target.
>   	 *
> +	 * Note: This callback is called with the host lock held and hence
> +	 * must not sleep.
> +	 *
>   	 * Status: OPTIONAL
>   	 */
>   	void (* target_destroy)(struct scsi_target *);

Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Martin K. Petersen Oct. 30, 2023, 3:34 p.m. UTC | #2 
On Wed, 18 Oct 2023 19:37:44 +0800, Wenchao Hao wrote:

> This is a cleanup patchset, no logic changed.
> 
> The first patch cleanup scsi_dev_queue_ready();
> The second patch add comment to tell callback target_destroy of
> scsi_host_template must not sleep.
> 
> V3:
>   - Update comments suggested by Bart
> 
> [...]

Applied to 6.7/scsi-queue, thanks!

[1/2] scsi: core: cleanup scsi_dev_queue_ready()
      https://git.kernel.org/mkp/scsi/c/3dc985bfbd00
[2/2] scsi: Add comment of target_destroy in scsi_host_template
      https://git.kernel.org/mkp/scsi/c/82f52b2cd5fc