From patchwork Tue Oct 10 09:20:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wenchao Hao X-Patchwork-Id: 731809 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ABA4CD690C for ; Tue, 10 Oct 2023 09:21:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230006AbjJJJVX (ORCPT ); Tue, 10 Oct 2023 05:21:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229585AbjJJJVW (ORCPT ); Tue, 10 Oct 2023 05:21:22 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51D0B9F; Tue, 10 Oct 2023 02:21:20 -0700 (PDT) Received: from kwepemm000012.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4S4Vh60dQhz1M9Gb; Tue, 10 Oct 2023 17:18:46 +0800 (CST) Received: from build.huawei.com (10.175.101.6) by kwepemm000012.china.huawei.com (7.193.23.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 10 Oct 2023 17:21:17 +0800 From: Wenchao Hao To: "Martin K . Petersen" , Douglas Gilbert CC: "James E . J . Bottomley" , , , , Wenchao Hao Subject: [PATCH v6 00/10] scsi:scsi_debug: Add error injection for single device Date: Tue, 10 Oct 2023 17:20:41 +0800 Message-ID: <20231010092051.608007-1-haowenchao2@huawei.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Originating-IP: [10.175.101.6] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm000012.china.huawei.com (7.193.23.142) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org The original error injection mechanism was based on scsi_host which could not inject fault for a single SCSI device. This patchset provides the ability to inject errors for a single SCSI device. Now we support inject timeout errors, queuecommand errors, and hostbyte, driverbyte, statusbyte, and sense data for specific SCSI Command. Two new error injection is defined to make abort command or reset LUN failed. Besides error injection for single device, this patchset add a new interface to make reset target failed for each scsi_target. The first two patch add a debugfs interface to add and inquiry single device's error injection info; the third patch defined how to remove an injection which has been added. The following 5 patches use the injection info and generate the related error type. The last two just add a new interface to make reset target failed and control scsi_device's allow_restart flag. V6: - Check return value of debugfs_create_xxx() and print error log if debugfs_create_xxx() return error - Fix typo in description of patch7 and patch8 - Update the description of patch10 V5: - Using rcu list to sync between error inject add, remove and check - Add module parameter "allow_restart" to control scsi_device's allow_restart flag V4: - Fix BUG_ON triggered by schedule in atomic context when rmmod scsi_debug Closes: https://lore.kernel.org/oe-lkp/202308031027.5941ce5f-oliver.sang@intel.com V3: - Add two more error types to fail abort command and lun reset - Fix memleak when rmmod scsi_debug without clearing errors injected - Fix memkeak because did not implement release in sdebug_error_fops - Fix possible NULL point access in scsi_debug_slave_destroy - Move specific error type's description to each single patch which implement this error type - Add interface to make target reset fail V2: - Using debugfs rather than sysfs attribute interface to manage error Wenchao Hao (10): scsi: scsi_debug: create scsi_debug directory in the debugfs filesystem scsi: scsi_debug: Add interface to manage single device's error inject scsi: scsi_debug: Define grammar to remove added error injection scsi: scsi_debug: timeout command if the error is injected scsi: scsi_debug: Return failed value if the error is injected scsi: scsi_debug: set command's result and sense data if the error is injected scsi: scsi_debug: Add new error injection abort failed scsi: scsi_debug: Add new error injection reset lun failed scsi: scsi_debug: Add debugfs interface to fail target reset scsi: scsi_debug: Add param to control sdev's allow_restart drivers/scsi/scsi_debug.c | 575 +++++++++++++++++++++++++++++++++++++- 1 file changed, 570 insertions(+), 5 deletions(-)