From patchwork Wed Jul 26 11:25:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ranjan Kumar X-Patchwork-Id: 706878 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97B37C0015E for ; Wed, 26 Jul 2023 11:27:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233588AbjGZL1Z (ORCPT ); Wed, 26 Jul 2023 07:27:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233443AbjGZL1F (ORCPT ); Wed, 26 Jul 2023 07:27:05 -0400 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E026B2D4F for ; Wed, 26 Jul 2023 04:26:38 -0700 (PDT) Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1bba48b0bd2so19217405ad.3 for ; Wed, 26 Jul 2023 04:26:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1690370798; x=1690975598; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=6PWk17Y5NnE05L/884lOaaIrLMOzvG91yWG0iC4B6VQ=; b=fV7Gi+dQKuFVbYW706vDuagVXan/E6OjsFj45dg4HqOkR1o004oEi+LpWjSyfLbC6Y 4p2R3hc4SqJFxRK/Q6c233k1aiTYeIWeufQKzHVYpoKMW3TXcpYTn1F6UuyWt38jXoC3 6ABjUew59ppB1buTXJYR+iKYsSvXlTuliIjwo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690370798; x=1690975598; h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=6PWk17Y5NnE05L/884lOaaIrLMOzvG91yWG0iC4B6VQ=; b=fG5RLgviJYXM7ojann2ccABCFgDXiWiEBO90hnwk0sSZGyqTyNnjcU36owuuU5H9cr /eHNmXa7ucCMULqh1syB52tAlegyngZpTQwjtg6BQHjlOSiHGXFH4ka2ZMnNl2v3dRzn XCwIr/ZymiQVfwXjwnVfze6Lk7xEubPKAi4LDX7qEqitGXc0UZ+vmHny3Dsg9aqqpJBq WR7j8Z59sTmgfhQ86KMa9ReuQgFSE7P/2eLiKQSl52FWWMvBWR9kGkvKfkLK6h20q7Ht ggekO7ApuUfZhlLGsJ58/3EyhJ11T8pHAUqJ04PF+zu3rkiko+1ZsRznF35nkk+KBrS0 rMFA== X-Gm-Message-State: ABy/qLYHGQH+X8bnjUh/GS1MuHnt8B0bAte4rfbyQvuczgCoNzF124KM hVoRPYFBI8O7j8DruaDJC4HgktWAw3b7Ni/tlPdTTblkeoNTxcRfXRDPesTrdRqW1GfplUjOmp/ Ki9KDjcZlKt2VZHRKgtzwG7h062N725Lsk0TDeiirsn+Zcs4H9SqvZxlVtb4pOXg39fHkiZGZJ9 P3k3txkVsNfg== X-Google-Smtp-Source: APBJJlGN04LO+CXLjRDyLCK3Uci3S+3Ez53MKFGv+ah/BXNYVE83Oy9kGHz/CaKCeDP/sSVYDE1L3g== X-Received: by 2002:a17:902:e742:b0:1bb:a922:4a1a with SMTP id p2-20020a170902e74200b001bba9224a1amr1639264plf.6.1690370797680; Wed, 26 Jul 2023 04:26:37 -0700 (PDT) Received: from localhost.localdomain ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id iz11-20020a170902ef8b00b001bbbc655ca1sm3443231plb.219.2023.07.26.04.26.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jul 2023 04:26:36 -0700 (PDT) From: Ranjan Kumar To: linux-scsi@vger.kernel.org, martin.petersen@oracle.com Cc: sathya.prakash@broadcom.com, sreekanth.reddy@broadcom.com, Ranjan Kumar Subject: [PATCH v3 0/2] mpt3sas: Additional retries when reading specific registers Date: Wed, 26 Jul 2023 16:55:25 +0530 Message-Id: <20230726112527.14987-1-ranjan.kumar@broadcom.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Doorbell and Host diagnostic registers could return 0 even after 3 retries and that leads to occasional resets of the controllers, hence increased the retry count to thirty. v1->v2: -added a new patch for volatile as suggested by Greg KH. -renamed macro as suggested by Damien Le Moal. v2->v3: -Modified patch description with more details. Ranjan Kumar (2): Perform additional retries if Doorbell read returns 0 mpt3sas: Removing volatile qualifier drivers/scsi/mpt3sas/mpi/mpi2.h | 2 +- drivers/scsi/mpt3sas/mpt3sas_base.c | 53 ++++++++++++++++------------- drivers/scsi/mpt3sas/mpt3sas_base.h | 11 +++++- 3 files changed, 40 insertions(+), 26 deletions(-)