mbox series

[00/11] scsi_debug: Some minor improvements

Message ID 20230307105555.3745277-1-john.g.garry@oracle.com
Headers show
Series scsi_debug: Some minor improvements | expand

Message

John Garry March 7, 2023, 10:55 a.m. UTC 
This series contains a bunch of minor improvements to the driver. I have
another bunch waiting with more major changes.

Most of the changes are quite straightforward, and the only patches of note are
as follows:
- Fix the command abort feature, enabled with host option SDEBUG_OPT_CMD_ABORT
- Drop driver count of queued commands per device
- Add poll mode completions to statistics. We already have poll mode callback
  call count, so maybe it was intentional to omit poll mode from the
  statistics.
  
Based on scsi-staging 6.4 @ commit ffba85603c62 ("Merge patch series "lpfc: Update lpfc to revision 14.2.0.11")

John Garry (11):
  scsi: scsi_debug: Don't hold driver host struct pointer in
    host->hostdata[]
  scsi: scsi_debug: Stop setting devip->sdbg_host twice
  scsi: scsi_debug: Drop scsi_debug_abort() NULL pointer checks
  scsi: scsi_debug: Drop scsi_debug_device_reset() NULL pointer checks
  scsi: scsi_debug: Drop scsi_debug_target_reset() NULL pointer checks
  scsi: scsi_debug: Drop scsi_debug_bus_reset() NULL pointer checks
  scsi: scsi_debug: Drop scsi_debug_host_reset() device NULL pointer
    check
  scsi: scsi_debug: Drop check for num_in_q exceeding queue depth
  scsi: scsi_debug: Drop sdebug_dev_info.num_in_q
  scsi: scsi_debug: Get command abort feature working again
  scsi: scsi_debug: Add poll mode deferred completions to statistics

 drivers/scsi/scsi_debug.c | 201 ++++++++++++++------------------------
 1 file changed, 74 insertions(+), 127 deletions(-)

Comments

John Garry March 7, 2023, 3:12 p.m. UTC | #1 
On 07/03/2023 14:58, Bart Van Assche wrote:
> On 3/7/23 02:55, John Garry wrote:
>> +#define to_sdebug_host_from_shost(shost)    \
>> +    to_sdebug_host(shost->dma_dev)
> 
> Please make the name of this macro shorter and following naming 
> conventions used elsewhere in the SCSI core. How about the following 
> name: shost_to_sdebug_host()?

ok, fine, I can change that. Maybe then I'll also change 
to_sdebug_host() -> dev_to_sdebug_host() to avoid ambiguity.

Thanks,
John