mbox series

[v3,0/3] Changes for ufshcd.c

Message ID 20221018181627.326657-1-beanhuo@iokpp.de
Headers show
Series Changes for ufshcd.c | expand

Message

Bean Huo Oct. 18, 2022, 6:16 p.m. UTC
From: Bean Huo <beanhuo@micron.com>

v2--v3:
    1. Add patch 3/3
    2. Add remove unused parameter param_offset in patch 1/3 based on Daejun's comment
    3. Further optimized patch 2/3 based on Bart's comment

v1--v2:
    1. change in ufshcd_lu_init() in  patch 2/2:
        1) Remove duplicate parameter initialization
        2) Move lun parameter initialization before kmalloc()

Bean Huo (3):
  scsi: ufs: core: Remove unnecessary if statement
  scsi: ufs: core: Cleanup ufshcd_slave_alloc()
  scsi: ufs: core: Use is_visible to control UFS unit descriptor sysfs
    nodes

 drivers/ufs/core/ufs-sysfs.c   |  21 ++++-
 drivers/ufs/core/ufshcd-priv.h |   6 +-
 drivers/ufs/core/ufshcd.c      | 155 ++++++++++++---------------------
 3 files changed, 77 insertions(+), 105 deletions(-)

Comments

Bean Huo Oct. 18, 2022, 6:23 p.m. UTC | #1
On Tue, 2022-10-18 at 11:20 -0700, Bart Van Assche wrote:
> On 10/18/22 11:16, Bean Huo wrote:
> > From: Bean Huo <beanhuo@micron.com>
> > 
> > LUs with WB potential support are properly checked in
> > ufshcd_wb_probe()
> > before calling ufshcd_read_unit_desc_param(), so remove this
> > unnecessary
> > if-checkup in ufs_is_valid_unit_desc_lun() to match its function
> > definition.
> 
> Hi Bean,
> 
> Does this patch differ from a revert of Jaegeuk's patch? If not,
> please 
> change the patch title into "Revert scsi: ufs: WB is only available
> on 
> LUN #0 to #7" and add "Cc: Jaegeuk Kim <jaegeuk@kernel.org>" just
> above 
> the Signed-off-by line.
> 
> Thanks,
> 
> Bart.

Bart, 

no difference, I will change its title and CC Jaegeuk.

thanks,
Bean