mbox series

[0/2] Unbreak mpt3sas on big-endian machines

Message ID 20220916130111.168195-1-damien.lemoal@opensource.wdc.com
Headers show
Series Unbreak mpt3sas on big-endian machines | expand

Message

Damien Le Moal Sept. 16, 2022, 1:01 p.m. UTC 
Patches b4efbec4c2a ("scsi: mpt3sas: Fix writel() use") and
7ab4d2441b9 ("scsi: mpt3sas: Fix ioc->base_readl() use"), while aiming
at only fixign sparse warnings without any functional change, broke the
mpt3sas driver on big endian machines. This series reverts both patches,
until someone more knowledgeable of the Broadcom HBA controller
interface can properly fix register endianness control to avoid the
compilation warnings.

Damien Le Moal (2):
  scsi: mpt3sas: Revert "scsi: mpt3sas: Fix writel() use"
  scsi: mpt3sas: Revert "scsi: mpt3sas: Fix ioc->base_readl() use"

 drivers/scsi/mpt3sas/mpt3sas_base.c | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

Comments

Martin K. Petersen Sept. 25, 2022, 5:38 p.m. UTC | #1 
Damien,

> Patches b4efbec4c2a ("scsi: mpt3sas: Fix writel() use") and
> 7ab4d2441b9 ("scsi: mpt3sas: Fix ioc->base_readl() use"), while aiming
> at only fixign sparse warnings without any functional change, broke
> the mpt3sas driver on big endian machines. This series reverts both
> patches, until someone more knowledgeable of the Broadcom HBA
> controller interface can properly fix register endianness control to
> avoid the compilation warnings.

Applied to 6.1/scsi-staging, thanks!