mbox series

[v2,0/7] mpi3mr: add BSG interface support for controller management

Message ID 20220329180616.22547-1-sumit.saxena@broadcom.com
Headers show
Series mpi3mr: add BSG interface support for controller management | expand

Message

Sumit Saxena March 29, 2022, 6:06 p.m. UTC 
This patchset adds BSG interface support for controller
management. BSG layer facilitates communication/data exchange 
between application and driver/firmware through BSG device node.

v2:
-Moved definitions to be used by user space applications to
 header scsi_bsg_mpi3mr.h in /include/upai/scsi 

Sumit Saxena (7):
  mpi3mr: add BSG device support
  mpi3mr: add support for driver commands
  mpi3mr: add support for MPT commands
  mpi3mr: add support for PEL commands
  mpi3mr: expose adapter state to sysfs
  mpi3mr: add support for nvme pass-through
  mpi3mr: update driver version to 8.0.0.69.0

 drivers/scsi/mpi3mr/Kconfig         |    1 +
 drivers/scsi/mpi3mr/Makefile        |    1 +
 drivers/scsi/mpi3mr/mpi3mr.h        |  109 +-
 drivers/scsi/mpi3mr/mpi3mr_app.c    | 1612 +++++++++++++++++++++++++++
 drivers/scsi/mpi3mr/mpi3mr_debug.h  |   37 +-
 drivers/scsi/mpi3mr/mpi3mr_fw.c     |  331 +++++-
 drivers/scsi/mpi3mr/mpi3mr_os.c     |   52 +-
 include/uapi/scsi/scsi_bsg_mpi3mr.h |  462 ++++++++
 8 files changed, 2587 insertions(+), 18 deletions(-)
 create mode 100644 drivers/scsi/mpi3mr/mpi3mr_app.c
 create mode 100644 include/uapi/scsi/scsi_bsg_mpi3mr.h

Comments

Sumit Saxena April 5, 2022, 6:22 p.m. UTC | #1 
On Mon, Apr 4, 2022 at 10:01 PM Bart Van Assche <bvanassche@acm.org> wrote:

> I can't find any code in the kernel that stores the value
> MPI3_FUNCTION_NVME_ENCAPSULATED. Does that mean that that value is set
> by user space and hence that the definition of that constant should
> occur in a uapi header? Same question for struct
> mpi3_nvme_encapsulated_request.
Agree with you Bart. MPI3_FUNCTION_NVME_ENCAPSULATED and
mpi3_nvme_encapsulated_request
should be moved to uapi headers. Infact, applications may need all
headers contained in "mpi" directory
(drivers/scsi/mp3imr/mpi). So it would make sense to move the entire
"mpi" directory to "uapi/scsi/mpi3mr".

Thanks,
Sumit
>
> Thanks,
>
> Bart.