From patchwork Wed Feb 24 01:12:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daejun Park X-Patchwork-Id: 387531 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8AA2C433DB for ; Wed, 24 Feb 2021 01:28:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7700664E6C for ; Wed, 24 Feb 2021 01:28:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233438AbhBXB2H (ORCPT ); Tue, 23 Feb 2021 20:28:07 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:35836 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234690AbhBXBNP (ORCPT ); Tue, 23 Feb 2021 20:13:15 -0500 Received: from epcas2p1.samsung.com (unknown [182.195.41.53]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20210224011229epoutp01fc23d4a003e247b36bd5edac52ff1db0~miejNGJ-y1706217062epoutp019 for ; Wed, 24 Feb 2021 01:12:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20210224011229epoutp01fc23d4a003e247b36bd5edac52ff1db0~miejNGJ-y1706217062epoutp019 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1614129149; bh=pA6OCbSCh4RoQLTq6pdcLa3DzjEJdGWQeLPyoGoVvfI=; h=Subject:Reply-To:From:To:CC:Date:References:From; b=jY0mlekDH4zmeqI+21Kz1uOILxiHQgVZ3XVgHfXp6RTlGaEA2aXbThMsLpIMVFhCV akkS8SQP9TpRT9r3xORHGY+W7N/ZkUHnKekkK7zCsKnKXlLGOC7dEApG+mGXujJpGW pAhEY8AVli/vQjCMvNDKEDFlQhvT5AWzKKxSwRmE= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas2p1.samsung.com (KnoxPortal) with ESMTP id 20210224011228epcas2p164b71de526b12d63cac711695590a951~mieiYAj1k3166831668epcas2p1G; Wed, 24 Feb 2021 01:12:28 +0000 (GMT) Received: from epsmges2p1.samsung.com (unknown [182.195.40.187]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4DldF55zXgz4x9Q2; Wed, 24 Feb 2021 01:12:25 +0000 (GMT) X-AuditID: b6c32a45-34dff7000001297d-d2-6035a7f94c7e Received: from epcas2p3.samsung.com ( [182.195.41.55]) by epsmges2p1.samsung.com (Symantec Messaging Gateway) with SMTP id DF.35.10621.9F7A5306; Wed, 24 Feb 2021 10:12:25 +0900 (KST) Mime-Version: 1.0 Subject: [PATCH v23 0/4] scsi: ufs: Add Host Performance Booster Support Reply-To: daejun7.park@samsung.com Sender: Daejun Park From: Daejun Park To: Greg KH , "avri.altman@wdc.com" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "asutoshd@codeaurora.org" , "stanley.chu@mediatek.com" , "cang@codeaurora.org" , "bvanassche@acm.org" , "huobean@gmail.com" , ALIM AKHTAR , Daejun Park CC: "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , JinHwan Park , Javier Gonzalez , SEUNGUK SHIN , Sung-Jun Park , yongmyung lee , Jinyoung CHOI , BoRam Shin X-Priority: 3 X-Content-Kind-Code: NORMAL X-CPGS-Detection: blocking_info_exchange X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20210224011224epcms2p31f141acb5d528da2b8e7bfa10b95311b@epcms2p3> Date: Wed, 24 Feb 2021 10:12:24 +0900 X-CMS-MailID: 20210224011224epcms2p31f141acb5d528da2b8e7bfa10b95311b X-Sendblock-Type: AUTO_CONFIDENTIAL X-CPGSPASS: Y X-CPGSPASS: Y CMS-TYPE: 102P X-Brightmail-Tracker: H4sIAAAAAAAAA52Tb0xTVxjGc3ovvYVZdkHYDmxx9RacGFraQuHUiTFxczfDJbCAy7YY6MqV Mkrb9BYiLIudwkC0iDMR1wAbGGABBgPljzCHtgyY0bAKTiigKNQFMhiD2cgW2Cgt0+zjvv3O c573fc57Tg4PC7xKhPIytUbGoFVqKK4f3mGLiBOt1MvTJE5LJJqq6uCiq58NEmh25Q4X2cYX CHR+cQVDSy11PmjWGoEapt5FJy62cFHFLRMHmc+0c9H0xDKBakY7OOjMWhGOhrsruOjU3S4u qh9Y46Dxy36otn0MoJPlTTiqqe7B9wXTwyMJ9HCpmUNfsUwSdFnNNUD3VjYRdMGPvTj9u9OB 06WXGwC93LaNLrp2ipPo974J7FEaVOrMXEbAaFW69ExtRjyVknxAhCiBWsca46kPpEgmlirk 4hiFWBZ3eLdUIpHJKYFWmc3EU0dF3mpKYFDp191GhjUaGBWzLhn2sUZlBiNmldlsjjZDrNJl U4JcpSZnvY6K2rtHzSjTGYMgbQaoK4fuE/oq0dGZvifABOzCEuDLg2QMNNtdoAT48QLJLgBr invxEsDj8ckAuNq11e3ZStLw8S9zhJsDSQq22C2ERxdDx4Mm4GYuGQnLB+8T7j5BZCEOO1z2 jQVG1mKw0WnCPGl8eKHIiXv4JdhZ3w48vBM+qTN7PcFwrHGe2OTf+r/0eoJg4b1bXk8AnFrp 8eohsL9nkePhY7B94s+NaSB5GkDbFYePZyMK/lzcuhHMJ9+GnVVtHPeUOBkOr5/d5rG8Dj89 7troj5GvwM75CsxtwcgI2NId5UZICmGfA9+cxNT6F/Ffxkh/WGxb/VfvqprxnmwHbF5p4Xja vAwdVaAMUJanF215JtbyNPYrgDWAFxg9m53BsDK99Nl3bgMbX2DXG13g3Pyi2Ao4PGAFkIdR QXzupCwtkJ+uzMtnDLpUQ46GYa0gf33es1hosEq3/oe0xlRprEQWK4+OiY6Wx8j/tyyXxcZK FHIkj5Uh6kU+K5lKDSQzlEYmi2H0jGEznMPzDTVxzhVuz612jfwtNPcuj1bXzomYx0kBD6N2 Zg33bMnPq4yrLNh+wl9eGjbWfPdAco5zR/jxFMWY4ZOgw32HhHzR3rec01NHbn5D+t+cVh95 TeNYdk0UixJC6zoSpg9+caN3zFrUin370ed9cLYsJPzrD+XP1b86ufRmm33++f2PBJOXBguS EnsW425HzibSF5Krb6ydtF2M0yx8PyQ8Fq5bNeeyER9b9z3MiyPO+91L8g3Jemd/eeKvPv1L fyQqXJSIxWuHyydul8xVl4oeRQ8NpTVuGbA1FwwcWlDmdKf0kd89UOwOC7gUNiIePT3zg9D0 00GjrsR+x8UrdFx/TxNGjKsq9BTOqpXSXZiBVf4Dxy3N2dAEAAA= DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20210224011224epcms2p31f141acb5d528da2b8e7bfa10b95311b References: Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Changelog: v22 -> v23 1. Add support compatibility of HPB 1.0. 2. Fix read id for single HPB read command. 3. Fix number of pre-allocated requests for write buffer. 4. Add fast path for response UPIU that has same LUN in sense data. 5. Remove WARN_ON for preventing kernel crash. 7. Fix wrong argument for read buffer command. v21 -> v22 1. Add support processing response UPIU in suspend state. 2. Add support HPB hint from other LU. 3. Add sending write buffer with 0x03 after HPB init. v20 -> v21 1. Add bMAX_DATA_SIZE_FOR_HPB_SINGLE_CMD attr. and fHPBen flag support. v19 -> v20 1. Add documentation for sysfs entries of hpb->stat. 2. Fix read buffer command for under-sized sub-region. 3. Fix wrong condition checking for kick map work. 4. Delete redundant response UPIU checking. 5. Add LUN checking in response UPIU. 6. Fix possible deadlock problem due to runtime PM. 7. Add instant changing of sub-region state from response UPIU. 8. Fix endian problem in prefetched PPN. 9. Add JESD220-3A (HPB v2.0) support. v18 -> 19 1. Fix null pointer error when printing sysfs from non-HPB LU. 2. Apply HPB read opcode in lrbp->cmd->cmnd (from Can Guo's review). 3. Rebase the patch on 5.12/scsi-queue. v17 -> v18 Fix build error which reported by kernel test robot. v16 -> v17 1. Rename hpb_state_lock to rgn_state_lock and move it to corresponding patch. 2. Remove redundant information messages. v15 -> v16 1. Add missed sysfs ABI documentation. v14 -> v15 1. Remove duplicated sysfs ABI entries in documentation. 2. Add experiment result of HPB performance testing with iozone. v13 -> v14 1. Cleanup codes by commentted in Greg's review. 2. Add documentation for sysfs entries (from Greg's review). 3. Add experiment result of HPB performance testing. v12 -> v13 1. Cleanup codes by comments from Can Guo. 2. Add HPB related descriptor/flag/attributes in sysfs. 3. Change base commit from 5.10/scsi-queue to 5.11/scsi-queue. v11 -> v12 1. Fixed to return error value when HPB fails to initialize pinned active region. 2. Fixed to disable HPB feature if HPB fails to allocate essential memory and workqueue. 3. Fixed to change proper sub-region state when region is already evicted. v10 -> v11 Add a newline at end the last line on Kconfig file. v9 -> v10 1. Fixed 64-bit division error 2. Fixed problems commentted in Bart's review. v8 -> v9 1. Change sysfs initialization. 2. Change reading descriptor during HPB initialization 3. Fixed problems commentted in Bart's review. 4. Change base commit from 5.9/scsi-queue to 5.10/scsi-queue. v7 -> v8 Remove wrongly added tags. v6 -> v7 1. Remove UFS feature layer. 2. Cleanup for sparse error. v5 -> v6 Change base commit to b53293fa662e28ae0cdd40828dc641c09f133405 v4 -> v5 Delete unused macro define. v3 -> v4 1. Cleanup. v2 -> v3 1. Add checking input module parameter value. 2. Change base commit from 5.8/scsi-queue to 5.9/scsi-queue. 3. Cleanup for unused variables and label. v1 -> v2 1. Change the full boilerplate text to SPDX style. 2. Adopt dynamic allocation for sub-region data structure. 3. Cleanup. NAND flash memory-based storage devices use Flash Translation Layer (FTL) to translate logical addresses of I/O requests to corresponding flash memory addresses. Mobile storage devices typically have RAM with constrained size, thus lack in memory to keep the whole mapping table. Therefore, mapping tables are partially retrieved from NAND flash on demand, causing random-read performance degradation. To improve random read performance, JESD220-3 (HPB v1.0) proposes HPB (Host Performance Booster) which uses host system memory as a cache for the FTL mapping table. By using HPB, FTL data can be read from host memory faster than from NAND flash memory. The current version only supports the DCM (device control mode). This patch consists of 3 parts to support HPB feature. 1) HPB probe and initialization process 2) READ -> HPB READ using cached map information 3) L2P (logical to physical) map management In the HPB probe and init process, the device information of the UFS is queried. After checking supported features, the data structure for the HPB is initialized according to the device information. A read I/O in the active sub-region where the map is cached is changed to HPB READ by the HPB. The HPB manages the L2P map using information received from the device. For active sub-region, the HPB caches through ufshpb_map request. For the in-active region, the HPB discards the L2P map. When a write I/O occurs in an active sub-region area, associated dirty bitmap checked as dirty for preventing stale read. HPB is shown to have a performance improvement of 58 - 67% for random read workload. [1] [1]: https://www.usenix.org/conference/hotstorage17/program/presentation/jeong Daejun Park (4): scsi: ufs: Introduce HPB feature scsi: ufs: L2P map management for HPB read scsi: ufs: Prepare HPB read for cached sub-region scsi: ufs: Add HPB 2.0 support Documentation/ABI/testing/sysfs-driver-ufs | 150 ++ drivers/scsi/ufs/Kconfig | 9 + drivers/scsi/ufs/Makefile | 1 + drivers/scsi/ufs/ufs-sysfs.c | 20 + drivers/scsi/ufs/ufs.h | 54 +- drivers/scsi/ufs/ufshcd.c | 70 +- drivers/scsi/ufs/ufshcd.h | 29 + drivers/scsi/ufs/ufshpb.c | 2379 ++++++++++++++++++++ drivers/scsi/ufs/ufshpb.h | 274 +++ 9 files changed, 2984 insertions(+), 2 deletions(-) create mode 100644 drivers/scsi/ufs/ufshpb.c create mode 100644 drivers/scsi/ufs/ufshpb.h