mbox series

[v3,0/9] Add Host control mode to HPB

Message ID 20210218131932.106997-1-avri.altman@wdc.com
Headers show
Series Add Host control mode to HPB | expand

Message

Avri Altman Feb. 18, 2021, 1:19 p.m. UTC 
v2 -> v3:
 - Attend Greg's and Can's comments
 - rebase on Daejun's v21

v1 -> v2:
 - attend Greg's and Daejun's comments
 - add patch 9 making host mode parameters configurable
 - rebase on Daejun's v19


The HPB spec defines 2 control modes - device control mode and host
control mode. In oppose to device control mode, in which the host obey
to whatever recommendation received from the device - In host control
mode, the host uses its own algorithms to decide which regions should
be activated or inactivated.

We kept the host managed heuristic simple and concise.

Aside from adding a by-spec functionality, host control mode entails
some further potential benefits: makes the hpb logic transparent and
readable, while allow tuning / scaling its various parameters, and
utilize system-wide info to optimize HPB potential.

This series is based on Samsung's V19 device-control HPB2.0 driver, see
msg-id: 20210218090853epcms2p8ccac0b5611dec22afd04ecc06e74498e@epcms2p8
in lore.kernel.org. The patches are also available in wdc ufs repo:
https://github.com/westerndigitalcorporation/WDC-UFS-REPO/tree/hpb-v21

This version was tested on Galaxy S20, and Xiaomi Mi10 pro.
Your meticulous review and testing is mostly welcome and appreciated.

Thanks,
Avri

Avri Altman (9):
  scsi: ufshpb: Cache HPB Control mode on init
  scsi: ufshpb: Add host control mode support to rsp_upiu
  scsi: ufshpb: Add region's reads counter
  scsi: ufshpb: Make eviction depends on region's reads
  scsi: ufshpb: Region inactivation in host mode
  scsi: ufshpb: Add hpb dev reset response
  scsi: ufshpb: Add "Cold" regions timer
  scsi: ufshpb: Add support for host control mode
  scsi: ufshpb: Make host mode parameters configurable

 Documentation/ABI/testing/sysfs-driver-ufs |  68 +++
 drivers/scsi/ufs/ufshcd.h                  |   2 +
 drivers/scsi/ufs/ufshpb.c                  | 622 +++++++++++++++++++--
 drivers/scsi/ufs/ufshpb.h                  |  44 +-
 4 files changed, 691 insertions(+), 45 deletions(-)

Comments

Avri Altman Feb. 18, 2021, 2:09 p.m. UTC | #1 
> > +What:

> /sys/class/scsi_device/*/device/hpb_param_sysfs/timeout_polling_interval_ms

> > +Date:                February 2021

> > +Contact:     Avri Altman <avri.altman@wdc.com>

> > +Description: the frequency in which the delayed worker that checks the

> > +             read_timeouts is awaken.

> > +>>>>>>> ef6bf08e666d... scsi: ufshpb: Make host mode parameters

> configurable

> 

> Did you mean for this last line to be here?

Thanks. Done.