From patchwork Tue Jan 12 11:06:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ahmed S. Darwish" X-Patchwork-Id: 361575 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E68B2C433E0 for ; Tue, 12 Jan 2021 11:08:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 95A842310D for ; Tue, 12 Jan 2021 11:08:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728866AbhALLHb (ORCPT ); Tue, 12 Jan 2021 06:07:31 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:45064 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726119AbhALLHb (ORCPT ); Tue, 12 Jan 2021 06:07:31 -0500 From: "Ahmed S. Darwish" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1610449608; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=lcE1agZ3n4KMKvyXY17HKtAT0mnLoq7JsTommZWNM68=; b=GuVVGPwG3Gq250lsw1qeD98hdWrtUgEleVXRr1+D5g369oMnfkC4wn3QN8EKivvTw7aIgJ GxW8Gljpm2l+uTU614pQBl4UMkJRezMpqJjjsNxvU2scU7Fa/k9EHS3uBx6G2XA2q/h1yU gV56raMfhOH33v67OMKnxXcL+0naFZIA05+9XsPVmfp4caCdIbV3mG+Il//GdgAv7w5g4x TnnpxxvomYCzYcRgIhGMb5znNgSNpGnB5CoMoeRiFZloa2KBYNeLQZMFkblofCrxvfWQA8 pRf+7AT9b45lCd4jL+RUW3jOpMgoaoIbmlEFmcuQM04kwistA7HlZ2dd3hhUWg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1610449608; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=lcE1agZ3n4KMKvyXY17HKtAT0mnLoq7JsTommZWNM68=; b=cYGQ4IIWAJhocGDPcscoRcJTwHBDZbp2HhEV4U68s1cwEEg9l14OsA3m4vl2gQAsCby5Lu U2RJ8TKf2/Kod+AQ== To: "James E.J. Bottomley" , "Martin K. Petersen" , John Garry , Jason Yan , Daniel Wagner , Artur Paszkiewicz , Jack Wang Cc: linux-scsi@vger.kernel.org, intel-linux-scu@intel.com, LKML , Thomas Gleixner , "Sebastian A. Siewior" , "Ahmed S. Darwish" Subject: [PATCH v2 00/19] scsi: libsas: Remove in_interrupt() check Date: Tue, 12 Jan 2021 12:06:28 +0100 Message-Id: <20210112110647.627783-1-a.darwish@linutronix.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Hi, Changelog v2 ------------ - Rebase on top of v5.11-rc3 - Rebase on top of John's patch "scsi: libsas and users: Remove notifier indirection", as it affects every other patch. Include it in this series (patch #2). - Introduce patches #13 => #19, which modify call sites back to use the original libsas notifier function names without _gfp() suffix. - Collect r-b tags v1 Submission ------------- https://lkml.kernel.org/r/20201218204354.586951-1-a.darwish@linutronix.de Cover letter ------------ In the discussion about preempt count consistency across kernel configurations: https://lkml.kernel.org/r/20200914204209.256266093@linutronix.de it was concluded that the usage of in_interrupt() and related context checks should be removed from non-core code. This includes memory allocation mode decisions (GFP_*). In the long run, usage of in_interrupt() and its siblings should be banned from driver code completely. This series addresses SCSI libsas. Basically, the function: => drivers/scsi/libsas/sas_init.c: struct asd_sas_event *sas_alloc_event(struct asd_sas_phy *phy) { ... gfp_t flags = in_interrupt() ? GFP_ATOMIC : GFP_KERNEL; event = kmem_cache_zalloc(sas_event_cache, flags); ... } is transformed so that callers explicitly pass the gfp_t memory allocation flags. Affected libsas clients are modified accordingly. Patches #1, #2 => #7 have "Fixes: " tags and address bugs the were noticed during the context analysis. Thanks! 8<-------------- Ahmed S. Darwish (18): Documentation: scsi: libsas: Remove notify_ha_event() scsi: libsas: Introduce a _gfp() variant of event notifiers scsi: mvsas: Pass gfp_t flags to libsas event notifiers scsi: isci: port: link down: Pass gfp_t flags scsi: isci: port: link up: Pass gfp_t flags scsi: isci: port: broadcast change: Pass gfp_t flags scsi: libsas: Pass gfp_t flags to event notifiers scsi: pm80xx: Pass gfp_t flags to libsas event notifiers scsi: aic94xx: Pass gfp_t flags to libsas event notifiers scsi: hisi_sas: Pass gfp_t flags to libsas event notifiers scsi: libsas: event notifiers API: Add gfp_t flags parameter scsi: hisi_sas: Switch back to original libsas event notifiers scsi: aic94xx: Switch back to original libsas event notifiers scsi: pm80xx: Switch back to original libsas event notifiers scsi: libsas: Switch back to original event notifiers API scsi: isci: Switch back to original libsas event notifiers scsi: mvsas: Switch back to original libsas event notifiers scsi: libsas: Remove temporarily-added _gfp() API variants John Garry (1): scsi: libsas and users: Remove notifier indirection Documentation/scsi/libsas.rst | 5 ++-- drivers/scsi/aic94xx/aic94xx_scb.c | 20 ++++++------- drivers/scsi/hisi_sas/hisi_sas.h | 3 +- drivers/scsi/hisi_sas/hisi_sas_main.c | 29 +++++++++---------- drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 6 ++-- drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 6 ++-- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 6 ++-- drivers/scsi/isci/port.c | 11 +++---- drivers/scsi/libsas/sas_event.c | 27 ++++++++--------- drivers/scsi/libsas/sas_init.c | 17 ++++------- drivers/scsi/libsas/sas_internal.h | 5 ++-- drivers/scsi/mvsas/mv_sas.c | 24 +++++++--------- drivers/scsi/pm8001/pm8001_hwi.c | 40 ++++++++++++-------------- drivers/scsi/pm8001/pm8001_sas.c | 12 +++----- drivers/scsi/pm8001/pm80xx_hwi.c | 37 +++++++++++------------- include/scsi/libsas.h | 9 +++--- 16 files changed, 115 insertions(+), 142 deletions(-) base-commit: 7c53f6b671f4aba70ff15e1b05148b10d58c2837 Reviewed-by: John Garry --- 2.30.0