From patchwork Sat Dec 19 03:29:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daejun Park X-Patchwork-Id: 346134 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98850C2D0E4 for ; Sat, 19 Dec 2020 03:31:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6D71423BCA for ; Sat, 19 Dec 2020 03:31:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726352AbgLSDam (ORCPT ); Fri, 18 Dec 2020 22:30:42 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:33778 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726145AbgLSDal (ORCPT ); Fri, 18 Dec 2020 22:30:41 -0500 Received: from epcas2p4.samsung.com (unknown [182.195.41.56]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20201219032956epoutp038a4e64cc4e87a4b76748f565585b5b15~SAIcJ1sap2915629156epoutp03N for ; Sat, 19 Dec 2020 03:29:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20201219032956epoutp038a4e64cc4e87a4b76748f565585b5b15~SAIcJ1sap2915629156epoutp03N DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1608348596; bh=oRAdNq4C1ZzerWDr2a1xEDLsrNRCOxAWzLaMl9eWQ8Y=; h=Subject:Reply-To:From:To:CC:Date:References:From; b=Io3Molm9IcFLtZhckXzU8zLBNfV8xVYg97D0N3Y9Zhjqua7dHOUef3xDjOjWHdxMY LypNKtaZi60RzB1bhoWhGkx75bEfV7yKlbn1NUtzYwTzZXnUS4U8lcGbe/u+83uepW FzSsP4JMWBt3jGkivcN+62ISU8UalXzW/hHD92Nk= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas2p1.samsung.com (KnoxPortal) with ESMTP id 20201219032955epcas2p1b800b5dbffc0f99f9727b967b9b68bc5~SAIas_Nv62628126281epcas2p1-; Sat, 19 Dec 2020 03:29:55 +0000 (GMT) Received: from epsmges2p3.samsung.com (unknown [182.195.40.183]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4CyWSc5ln1zMqYkV; Sat, 19 Dec 2020 03:29:52 +0000 (GMT) X-AuditID: b6c32a47-b97ff7000000148e-87-5fdd73b0f7e6 Received: from epcas2p4.samsung.com ( [182.195.41.56]) by epsmges2p3.samsung.com (Symantec Messaging Gateway) with SMTP id DA.63.05262.0B37DDF5; Sat, 19 Dec 2020 12:29:52 +0900 (KST) Mime-Version: 1.0 Subject: [PATCH v15 0/3] scsi: ufs: Add Host Performance Booster Support Reply-To: daejun7.park@samsung.com Sender: Daejun Park From: Daejun Park To: Greg KH , "avri.altman@wdc.com" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "asutoshd@codeaurora.org" , "stanley.chu@mediatek.com" , "cang@codeaurora.org" , "huobean@gmail.com" , "bvanassche@acm.org" , ALIM AKHTAR , Daejun Park CC: "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sung-Jun Park , yongmyung lee , Jinyoung CHOI , Adel Choi , BoRam Shin , SEUNGUK SHIN X-Priority: 3 X-Content-Kind-Code: NORMAL X-CPGS-Detection: blocking_info_exchange X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20201219032952epcms2p668a76f6b5ab021f0e66c856c44d5be0d@epcms2p6> Date: Sat, 19 Dec 2020 12:29:52 +0900 X-CMS-MailID: 20201219032952epcms2p668a76f6b5ab021f0e66c856c44d5be0d X-Sendblock-Type: AUTO_CONFIDENTIAL X-CPGSPASS: Y X-CPGSPASS: Y CMS-TYPE: 102P X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHJsWRmVeSWpSXmKPExsWy7bCmhe6G4rvxBpcPa1tsvPuK1eLBvG1s FnvbTrBbvPx5lc3i8O137BbTPvxktvi0fhmrxctDmharHoRbNC9ez2Yx52wDk0Vv/1Y2i0U3 tjFZXN41h82i+/oONovlx/8xWdzewmWxdOtNRovO6WtYLBYt3M3iIOJx+Yq3x+W+XiaPnbPu sntMWHSA0WP/3DXsHi0n97N4fHx6i8Wjb8sqRo/Pm+Q82g90MwVwReXYZKQmpqQWKaTmJeen ZOal2yp5B8c7x5uaGRjqGlpamCsp5CXmptoqufgE6Lpl5gA9p6RQlphTChQKSCwuVtK3synK Ly1JVcjILy6xVUotSMkpMDQs0CtOzC0uzUvXS87PtTI0MDAyBapMyMlYdG8nc8FihYpv2yaz NTD+kOxi5OSQEDCRaF2yl6WLkYtDSGAHo8SO9uNMXYwcHLwCghJ/dwiD1AgLeEg8aPjLAmIL CShJrL84ix0iridx6+EaRhCbTUBHYvqJ++wgc0QEWlkkzh6aAjaUWeArk8Sn57OZILbxSsxo f8oCYUtLbF++lRHC1pD4sayXGcIWlbi5+i07jP3+2HyoGhGJ1ntnoWoEJR783A0Vl5Q4tvsD 1Px6ia13fjGCLJYQ6GGUOLzzFitEQl/iWsdGsMW8Ar4Sb2e8BLNZBFQltryfzwZR4yLxeOcF sMXMAvIS29/OYQaFBLOApsT6XfogpoSAssSRWywwrzRs/M2OzmYW4JPoOPwXLr5j3hOo09Qk 1v1czwQxRkbi1jzGCYxKsxAhPQvJ2lkIaxcwMq9iFEstKM5NTy02KjBGjtxNjOCEruW+g3HG 2w96hxiZOBgPMUpwMCuJ8IY+uB0vxJuSWFmVWpQfX1Sak1p8iNEU6OGJzFKiyfnAnJJXEm9o amRmZmBpamFqZmShJM4burIvXkggPbEkNTs1tSC1CKaPiYNTqoFp4TGWiHi+X1/+nX6h4fvV zV6zrvzN/N1Wvar8GoJnl61YeF3nx7MN7xhfqYquVY0U3riVW8S/xKTFeIrDa0X+7M9N2iET Fy8xq/rMWrnAOCT8Sf2TSRWpojvDjuwM+CX1Z3u6UOUa2Zn/X53x/S9v1uxSsYDnwTORox8Y F7xvcKn4qCiqcs/iajDX9z+xq0orktTrnT54O32WeahzZkmZbXKbrtGq7+bXL2eYrJb5vfiI x8Vg5StC6UYndl79rOAgsnd+zZXujpMXm1z3L41tl5meHr58z47ZQVVRBsJTFXhWiyXNPbhe YXNDhaQyU82CCds3qJm8Wx9WzC9kzno8WUjarnf5wt1dh196PpilxFKckWioxVxUnAgAngjW 1XEEAAA= DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20201219032952epcms2p668a76f6b5ab021f0e66c856c44d5be0d References: Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Changelog: v14 -> v15 1. Remove duplicated sysfs ABI entries in documentation. 2. Add experiment result of HPB performance testing with iozone. v13 -> v14 1. Cleanup codes by commentted in Greg's review. 2. Add documentation for sysfs entries (from Greg's review). 3. Add experiment result of HPB performance testing. (in this mail) v12 -> v13 1. Cleanup codes by comments from Can Guo. 2. Add HPB related descriptor/flag/attributes in sysfs. 3. Change base commit from 5.10/scsi-queue to 5.11/scsi-queue. v11 -> v12 1. Fixed to return error value when HPB fails to initialize pinned active region. 2. Fixed to disable HPB feature if HPB fails to allocate essential memory and workqueue. 3. Fixed to change proper sub-region state when region is already evicted. v10 -> v11 Add a newline at end the last line on Kconfig file. v9 -> v10 1. Fixed 64-bit division error 2. Fixed problems commentted in Bart's review. v8 -> v9 1. Change sysfs initialization. 2. Change reading descriptor during HPB initialization 3. Fixed problems commentted in Bart's review. 4. Change base commit from 5.9/scsi-queue to 5.10/scsi-queue. v7 -> v8 Remove wrongly added tags. v6 -> v7 1. Remove UFS feature layer. 2. Cleanup for sparse error. v5 -> v6 Change base commit to b53293fa662e28ae0cdd40828dc641c09f133405 v4 -> v5 Delete unused macro define. v3 -> v4 1. Cleanup. v2 -> v3 1. Add checking input module parameter value. 2. Change base commit from 5.8/scsi-queue to 5.9/scsi-queue. 3. Cleanup for unused variables and label. v1 -> v2 1. Change the full boilerplate text to SPDX style. 2. Adopt dynamic allocation for sub-region data structure. 3. Cleanup. NAND flash memory-based storage devices use Flash Translation Layer (FTL) to translate logical addresses of I/O requests to corresponding flash memory addresses. Mobile storage devices typically have RAM with constrained size, thus lack in memory to keep the whole mapping table. Therefore, mapping tables are partially retrieved from NAND flash on demand, causing random-read performance degradation. To improve random read performance, JESD220-3 (HPB v1.0) proposes HPB (Host Performance Booster) which uses host system memory as a cache for the FTL mapping table. By using HPB, FTL data can be read from host memory faster than from NAND flash memory. The current version only supports the DCM (device control mode). This patch consists of 3 parts to support HPB feature. 1) HPB probe and initialization process 2) READ -> HPB READ using cached map information 3) L2P (logical to physical) map management In the HPB probe and init process, the device information of the UFS is queried. After checking supported features, the data structure for the HPB is initialized according to the device information. A read I/O in the active sub-region where the map is cached is changed to HPB READ by the HPB. The HPB manages the L2P map using information received from the device. For active sub-region, the HPB caches through ufshpb_map request. For the in-active region, the HPB discards the L2P map. When a write I/O occurs in an active sub-region area, associated dirty bitmap checked as dirty for preventing stale read. HPB is shown to have a performance improvement of 58 - 67% for random read workload. [1] [1]: https://www.usenix.org/conference/hotstorage17/program/presentation/jeong Daejun Park (3): scsi: ufs: Introduce HPB feature scsi: ufs: L2P map management for HPB read scsi: ufs: Prepare HPB read for cached sub-region drivers/scsi/ufs/Kconfig | 9 + drivers/scsi/ufs/Makefile | 1 + drivers/scsi/ufs/ufs-sysfs.c | 18 + drivers/scsi/ufs/ufs.h | 49 + drivers/scsi/ufs/ufshcd.c | 53 + drivers/scsi/ufs/ufshcd.h | 23 +- drivers/scsi/ufs/ufshpb.c | 1767 ++++++++++++++++++++++++++++++++++ drivers/scsi/ufs/ufshpb.h | 230 +++++ 8 files changed, 2149 insertions(+), 1 deletion(-) create mode 100644 drivers/scsi/ufs/ufshpb.c create mode 100644 drivers/scsi/ufs/ufshpb.h