From patchwork Thu Dec 3 08:20:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anastasia Kovaleva X-Patchwork-Id: 337404 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04E88C71155 for ; Thu, 3 Dec 2020 08:21:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99A7821741 for ; Thu, 3 Dec 2020 08:21:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388381AbgLCIVt (ORCPT ); Thu, 3 Dec 2020 03:21:49 -0500 Received: from mta-02.yadro.com ([89.207.88.252]:59922 "EHLO mta-01.yadro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388328AbgLCIVt (ORCPT ); Thu, 3 Dec 2020 03:21:49 -0500 Received: from localhost (unknown [127.0.0.1]) by mta-01.yadro.com (Postfix) with ESMTP id EDAC5413A8; Thu, 3 Dec 2020 08:21:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yadro.com; h= content-type:content-type:content-transfer-encoding:mime-version :x-mailer:message-id:date:date:subject:subject:from:from :received:received:received; s=mta-01; t=1606983666; x= 1608798067; bh=MmD9P7mah3e4vs5onyHpqWruAlxXsB+lYNcJktt3FLM=; b=g ElJuAxevEYRY5lrBklXZPf4UdJxBfY0BBUMJR6SB+raxRxYG7VDsBY4XXOm0DlaQ Fjm2UOo8qlHesOImYft1+t3TfbcMRikvsHu9bgrbN8gqed8o4JpnZM/y7dOHIvpW 021H39KnORzsjWjqfF9UAPtM7TFA9kDTiVTF3IYXng= X-Virus-Scanned: amavisd-new at yadro.com Received: from mta-01.yadro.com ([127.0.0.1]) by localhost (mta-01.yadro.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jBmX92YdGIEs; Thu, 3 Dec 2020 11:21:06 +0300 (MSK) Received: from T-EXCH-03.corp.yadro.com (t-exch-03.corp.yadro.com [172.17.100.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mta-01.yadro.com (Postfix) with ESMTPS id 96296412DF; Thu, 3 Dec 2020 11:21:06 +0300 (MSK) Received: from localhost (172.17.204.63) by T-EXCH-03.corp.yadro.com (172.17.100.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.669.32; Thu, 3 Dec 2020 11:21:05 +0300 From: Anastasia Kovaleva To: CC: , , , Anastasia Kovaleva Subject: [RESEND PATCH 0/3] scsi: target: Set correct residual data Date: Thu, 3 Dec 2020 11:20:32 +0300 Message-ID: <20201203082035.54566-1-a.kovaleva@yadro.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) MIME-Version: 1.0 X-Originating-IP: [172.17.204.63] X-ClientProxiedBy: T-EXCH-01.corp.yadro.com (172.17.10.101) To T-EXCH-03.corp.yadro.com (172.17.100.103) Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Hi Martin, Please apply the changes to 5.11/scsi-queue at your earliest convenience. The series changes the behavior of the target in regard to processing commands with overflow/underflow in accordance with the standarts. The target driver used to process the DMA_TO_DEVICE commands with residuals (in particular, WRITE command) incorrectly. The target response contained neither a residual count, nor an OVERFLOW/UNDERFLOW bit. Such behavior did not comply with the RFC 7143. Also the returned ASC and ASCQ were incorrect according to FCP-4, and residuals were not set for the 4Kn devices. This patches fix the major inconsistances in processing these kind of commands. This patch series has been tested with a modified libiscsi testing library. The link to the pull request: https://github.com/sahlberg/libiscsi/pull/345 Write10Residuals, Write12Residuals, Write16Residuals tests have passed. Thanks, Anastasia Anastasia Kovaleva (2): scsi: target: core: Signal WRITE residuals scsi: target: core: Change ASCQ for residual write Roman Bolshakov (1): scsi: target: core: Set residuals for 4Kn devices drivers/target/target_core_transport.c | 53 +++++++++++++------------- include/target/target_core_base.h | 1 + 2 files changed, 28 insertions(+), 26 deletions(-)