mbox series

[v2,0/4] io_uring iopoll in scsi layer

Message ID 20201203034100.29716-1-kashyap.desai@broadcom.com
Headers show
Series io_uring iopoll in scsi layer | expand

Message

Kashyap Desai Dec. 3, 2020, 3:40 a.m. UTC
This patch series is to support io_uring iopoll feature
in scsi stack. This patch set requires shared hosttag support.

This patch set is created on top of for-next branch of
https://kernel.googlesource.com/pub/scm/linux/kernel/git/axboe/linux-block

v2 -> 
- updated feedback from v1.
- add reviewed-by & tested-by tag
- remove flood of prints in scsi_debug driver during iopoll
  reported by Douglas Gilbert.
- added new patch to support to get shost from hctx.
  added new helper function "scsi_init_hctx"

v1 -> 
Fixed warnings in scsi_debug driver.
Reported-by: kernel test robot <lkp@intel.com>

Kashyap Desai (4):
  add io_uring with IOPOLL support in scsi layer
  megaraid_sas: iouring iopoll support
  scsi_debug : iouring iopoll support
  scsi: set shost as hctx driver_data

 drivers/scsi/megaraid/megaraid_sas.h        |   2 +
 drivers/scsi/megaraid/megaraid_sas_base.c   |  90 ++++++++++++--
 drivers/scsi/megaraid/megaraid_sas_fusion.c |  43 ++++++-
 drivers/scsi/megaraid/megaraid_sas_fusion.h |   3 +
 drivers/scsi/scsi_debug.c                   | 130 ++++++++++++++++++++
 drivers/scsi/scsi_lib.c                     |  28 ++++-
 include/scsi/scsi_cmnd.h                    |   1 +
 include/scsi/scsi_host.h                    |  11 ++
 8 files changed, 294 insertions(+), 14 deletions(-)


base-commit: 0eedceafd3a63fd082743c914853ef4b9247dbe6

Comments

Kashyap Desai Jan. 11, 2021, 12:15 p.m. UTC | #1
Hi Martin,

Due to some issue in RCU lock (only in debugging environments),  there was
booting issue and shared host tag support of megaraid_sas driver is revert
backed in 5.10 -
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit
/?id=1a0e1943d8798cb3241fb5edb9a836af1611b60a

== Commit message ==
It turns out that it causes long boot-time latencies (to the point of
timeouts and failed boots).

The cause is the increase in request queues, and a fix for that is queued
up for 5.11, but we're reverting this commit that triggered the problem
for now.
==

Can you include this patch set for 5.11 ?  I see (origin/5.11/scsi-queue)
has below change set. It looks like you have already queued up "shared
host tag feature for 5.11"

git log --oneline drivers/scsi/megaraid/
498854102c1c scsi: megaraid_sas: Update function description
977001df0368 scsi: megaraid_sas: Use generic power management
8ed9d987c6d9 scsi: megaraid_sas: Drop PCI wakeup calls from .resume
bba84aeccafb scsi: megaraid_sas: Simplify compat_ioctl handling
381d34e376e3 scsi: megaraid_sas: Check user-provided offsets
55e0500eb5c0 Merge tag 'scsi-misc' of
git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi
103fbf8e4020 scsi: megaraid_sas: Added support for shared host tagset for
cpuhotplug
62aa501dc9dd scsi: megaraid: Make smp_affinity_enable static


Kashyap

> -----Original Message-----

> From: Kashyap Desai [mailto:kashyap.desai@broadcom.com]

> Sent: Thursday, December 3, 2020 9:11 AM

> To: linux-scsi@vger.kernel.org

> Cc: Kashyap Desai <kashyap.desai@broadcom.com>

> Subject: [PATCH v2 0/4] io_uring iopoll in scsi layer

>

> This patch series is to support io_uring iopoll feature in scsi stack.

This patch
> set requires shared hosttag support.

>

> This patch set is created on top of for-next branch of

>

https://kernel.googlesource.com/pub/scm/linux/kernel/git/axboe/linux-block
>

> v2 ->

> - updated feedback from v1.

> - add reviewed-by & tested-by tag

> - remove flood of prints in scsi_debug driver during iopoll

>   reported by Douglas Gilbert.

> - added new patch to support to get shost from hctx.

>   added new helper function "scsi_init_hctx"

>

> v1 ->

> Fixed warnings in scsi_debug driver.

> Reported-by: kernel test robot <lkp@intel.com>

>

> Kashyap Desai (4):

>   add io_uring with IOPOLL support in scsi layer

>   megaraid_sas: iouring iopoll support

>   scsi_debug : iouring iopoll support

>   scsi: set shost as hctx driver_data

>

>  drivers/scsi/megaraid/megaraid_sas.h        |   2 +

>  drivers/scsi/megaraid/megaraid_sas_base.c   |  90 ++++++++++++--

>  drivers/scsi/megaraid/megaraid_sas_fusion.c |  43 ++++++-

>  drivers/scsi/megaraid/megaraid_sas_fusion.h |   3 +

>  drivers/scsi/scsi_debug.c                   | 130 ++++++++++++++++++++

>  drivers/scsi/scsi_lib.c                     |  28 ++++-

>  include/scsi/scsi_cmnd.h                    |   1 +

>  include/scsi/scsi_host.h                    |  11 ++

>  8 files changed, 294 insertions(+), 14 deletions(-)

>

>

> base-commit: 0eedceafd3a63fd082743c914853ef4b9247dbe6

> --

> 2.18.1


-- 
This electronic communication and the information and any files transmitted 
with it, or attached to it, are confidential and are intended solely for 
the use of the individual or entity to whom it is addressed and may contain 
information that is confidential, legally privileged, protected by privacy 
laws, or otherwise restricted from disclosure to anyone else. If you are 
not the intended recipient or the person responsible for delivering the 
e-mail to the intended recipient, you are hereby notified that any use, 
copying, distributing, dissemination, forwarding, printing, or copying of 
this e-mail is strictly prohibited. If you received this e-mail in error, 
please return the e-mail to the sender, delete it from your computer, and 
destroy any printed copy of it.
Martin K. Petersen Jan. 13, 2021, 3:55 a.m. UTC | #2
Kashyap,

> Can you include this patch set for 5.11 ?  I see

> (origin/5.11/scsi-queue) has below change set. It looks like you have

> already queued up "shared host tag feature for 5.11"


The revert was reverted in v5.11-rc3. Note that 5.12/scsi-queue is based
on v5.11-rc2 so the queue tree does not have the commit.

-- 
Martin K. Petersen	Oracle Linux Engineering