| Message ID | 20201130024615.29171-1-bvanassche@acm.org |
|---|---|
| Headers | show |
| Series | Rework runtime suspend and SPI domain validation | expand |
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
Jens, Any objections to me picking this up? > The SCSI runtime suspend and SPI domain validation mechanisms both use > scsi_device_quiesce(). scsi_device_quiesce() restricts > blk_queue_enter() to BLK_MQ_REQ_PREEMPT requests. There is a conflict > between the requirements of runtime suspend and SCSI domain > validation: no requests must be sent to runtime suspended devices that > are in the state RPM_SUSPENDED while BLK_MQ_REQ_PREEMPT requests must > be processed during SCSI domain validation. This conflict is resolved > by reworking the SCSI domain validation implementation. > > Hybernation, runtime suspend and SCSI domain validation have been > retested. -- Martin K. Petersen Oracle Linux Engineering
On 11/30/20 3:46 AM, Bart Van Assche wrote: > Introduce the BLK_MQ_REQ_PM flag. This flag makes the request allocation > functions set RQF_PM. This is the first step towards removing > BLK_MQ_REQ_PREEMPT. > > Cc: Alan Stern <stern@rowland.harvard.edu> > Cc: Stanley Chu <stanley.chu@mediatek.com> > Cc: Christoph Hellwig <hch@lst.de> > Cc: Hannes Reinecke <hare@suse.de> > Cc: Ming Lei <ming.lei@redhat.com> > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > Cc: Can Guo <cang@codeaurora.org> > Signed-off-by: Bart Van Assche <bvanassche@acm.org> > --- > block/blk-core.c | 7 ++++--- > block/blk-mq.c | 2 ++ > include/linux/blk-mq.h | 2 ++ > 3 files changed, 8 insertions(+), 3 deletions(-) > Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
On 11/30/20 3:46 AM, Bart Van Assche wrote: > This is another step that prepares for the removal of RQF_PREEMPT. > > Cc: Christoph Hellwig <hch@lst.de> > Cc: Hannes Reinecke <hare@suse.de> > Cc: David S. Miller <davem@davemloft.net> > Cc: Alan Stern <stern@rowland.harvard.edu> > Cc: Can Guo <cang@codeaurora.org> > Cc: Stanley Chu <stanley.chu@mediatek.com> > Cc: Ming Lei <ming.lei@redhat.com> > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > Signed-off-by: Bart Van Assche <bvanassche@acm.org> > --- > drivers/ide/ide-io.c | 2 +- > drivers/ide/ide-pm.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
On 11/30/20 3:46 AM, Bart Van Assche wrote: > Instead of submitting all SCSI commands submitted with scsi_execute() to a > SCSI device if rpm_status != RPM_ACTIVE, only submit RQF_PM (power > management requests) if rpm_status != RPM_ACTIVE. This patch makes the > SCSI core handle the runtime power management status (rpm_status) as it > should be handled. > > Cc: Christoph Hellwig <hch@lst.de> > Cc: Can Guo <cang@codeaurora.org> > Cc: Stanley Chu <stanley.chu@mediatek.com> > Cc: Alan Stern <stern@rowland.harvard.edu> > Cc: Ming Lei <ming.lei@redhat.com> > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > Cc: Martin Kepplinger <martin.kepplinger@puri.sm> > Signed-off-by: Bart Van Assche <bvanassche@acm.org> > --- > drivers/scsi/scsi_lib.c | 27 ++++++++++++++------------- > 1 file changed, 14 insertions(+), 13 deletions(-) > Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
On 12/1/20 6:51 PM, Martin K. Petersen wrote: > > Jens, > > Any objections to me picking this up? No, go ahead. Looks good to me, you can add: Reviewed-by: Jens Axboe <axboe@kernel.dk> to the series. -- Jens Axboe
Bart, > The SCSI runtime suspend and SPI domain validation mechanisms both use > scsi_device_quiesce(). scsi_device_quiesce() restricts > blk_queue_enter() to BLK_MQ_REQ_PREEMPT requests. There is a conflict > between the requirements of runtime suspend and SCSI domain > validation: no requests must be sent to runtime suspended devices that > are in the state RPM_SUSPENDED while BLK_MQ_REQ_PREEMPT requests must > be processed during SCSI domain validation. This conflict is resolved > by reworking the SCSI domain validation implementation. Applied to 5.11/scsi-staging except for patch #5. Appreciate all that work that went into this series! -- Martin K. Petersen Oracle Linux Engineering