mbox series

[0/4] pm80xx updates

Message ID 20200925061605.31628-1-Viswas.G@microchip.com.com
Headers show
Series pm80xx updates | expand

Message

Viswas G Sept. 25, 2020, 6:16 a.m. UTC
From: Viswas G <Viswas.G@microchip.com>

This patch set includes some enhancements in pm80xx driver.

Viswas G (4):
  pm80xx : Increase number of supported queues.
  pm80xx : Remove DMA memory allocation for ccb and device structures.
  pm80xx : Increase the number of outstanding IO supported to 1024.
  pm80xx : Driver version update

 drivers/scsi/pm8001/pm8001_ctl.c  |   6 +-
 drivers/scsi/pm8001/pm8001_defs.h |  27 +++--
 drivers/scsi/pm8001/pm8001_hwi.c  |  38 +++----
 drivers/scsi/pm8001/pm8001_init.c | 220 ++++++++++++++++++++++++++------------
 drivers/scsi/pm8001/pm8001_sas.h  |  15 ++-
 drivers/scsi/pm8001/pm80xx_hwi.c  | 109 ++++++++++---------
 6 files changed, 253 insertions(+), 162 deletions(-)

Comments

Jinpu Wang Sept. 25, 2020, 6:13 a.m. UTC | #1
Hi Viswas,
On Fri, Sep 25, 2020 at 8:06 AM Viswas G <Viswas.G@microchip.com.com> wrote:
>
> From: Viswas G <Viswas.G@microchip.com>
>
> This patch set includes some enhancements in pm80xx driver.
Thanks for the patches. the first and 3rd one, seems to be performance
improvement,
can you share your performance number?


>
> Viswas G (4):
>   pm80xx : Increase number of supported queues.
>   pm80xx : Remove DMA memory allocation for ccb and device structures.
>   pm80xx : Increase the number of outstanding IO supported to 1024.
>   pm80xx : Driver version update
Thanks
>
>  drivers/scsi/pm8001/pm8001_ctl.c  |   6 +-
>  drivers/scsi/pm8001/pm8001_defs.h |  27 +++--
>  drivers/scsi/pm8001/pm8001_hwi.c  |  38 +++----
>  drivers/scsi/pm8001/pm8001_init.c | 220 ++++++++++++++++++++++++++------------
>  drivers/scsi/pm8001/pm8001_sas.h  |  15 ++-
>  drivers/scsi/pm8001/pm80xx_hwi.c  | 109 ++++++++++---------
>  6 files changed, 253 insertions(+), 162 deletions(-)
>
> --
> 2.16.3
>
Viswas G Sept. 25, 2020, 6:36 a.m. UTC | #2
I could see below results in my test setup.

fio_sqrd_bs512_qd.txt:  read: IOPS=1000k, BW=488MiB/s (512MB/s)(28.7GiB/60123msec)
fio_sqrd_bs64k_qd.txt:  read: IOPS=37.0k, BW=2377MiB/s (2493MB/s)(139GiB/60000msec)
fio_sqw_bs256k_qd.txt:  write: IOPS=4310, BW=1102MiB/s (1156MB/s)(66.2GiB/61531msec); 0 zone resets
fio_sqw_bs4k_qd.txt:  write: IOPS=216k, BW=846MiB/s (888MB/s)(47.3GiB/57189msec); 0 zone resets

With patches:

fio_sqrd_bs512_qd.txt:  read: IOPS=1539k, BW=752MiB/s (789MB/s)(44.2GiB/60174msec)  => +53.9%
fio_sqrd_bs64k_qd.txt:  read: IOPS=30.9k, BW=1946MiB/s (2041MB/s)(114GiB/60000msec)
fio_sqw_bs256k_qd.txt:  write: IOPS=4309, BW=1102MiB/s (1155MB/s)(66.3GiB/61602msec); 0 zone resets
fio_sqw_bs4k_qd.txt:  write: IOPS=300k, BW=1174MiB/s (1231MB/s)(68.0GiB/59355msec); 0 zone resets =>  +38%

Regards,
Viswas G

> -----Original Message-----

> From: Jinpu Wang <jinpu.wang@cloud.ionos.com>

> Sent: Friday, September 25, 2020 11:43 AM

> To: Viswas G <Viswas.G@microchip.com.com>

> Cc: Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>; Vasanthalakshmi

> Tharmarajan - I30664 <Vasanthalakshmi.Tharmarajan@microchip.com>;

> Viswas G - I30667 <Viswas.G@microchip.com>; Ruksar Devadi - I52327

> <Ruksar.devadi@microchip.com>

> Subject: Re: [PATCH 0/4] pm80xx updates

> 

> EXTERNAL EMAIL: Do not click links or open attachments unless you know

> the content is safe

> 

> Hi Viswas,

> On Fri, Sep 25, 2020 at 8:06 AM Viswas G <Viswas.G@microchip.com.com>

> wrote:

> >

> > From: Viswas G <Viswas.G@microchip.com>

> >

> > This patch set includes some enhancements in pm80xx driver.

> Thanks for the patches. the first and 3rd one, seems to be performance

> improvement, can you share your performance number?

> 

> 

> >

> > Viswas G (4):

> >   pm80xx : Increase number of supported queues.

> >   pm80xx : Remove DMA memory allocation for ccb and device structures.

> >   pm80xx : Increase the number of outstanding IO supported to 1024.

> >   pm80xx : Driver version update

> Thanks

> >

> >  drivers/scsi/pm8001/pm8001_ctl.c  |   6 +-

> >  drivers/scsi/pm8001/pm8001_defs.h |  27 +++--

> > drivers/scsi/pm8001/pm8001_hwi.c  |  38 +++----

> > drivers/scsi/pm8001/pm8001_init.c | 220

> > ++++++++++++++++++++++++++------------

> >  drivers/scsi/pm8001/pm8001_sas.h  |  15 ++-

> > drivers/scsi/pm8001/pm80xx_hwi.c  | 109 ++++++++++---------

> >  6 files changed, 253 insertions(+), 162 deletions(-)

> >

> > --

> > 2.16.3

> >
Jinpu Wang Oct. 5, 2020, 11:18 a.m. UTC | #3
On Fri, Sep 25, 2020 at 8:06 AM Viswas G <Viswas.G@microchip.com.com> wrote:
>
> From: Viswas G <Viswas.G@microchip.com>
>
> Update driver version from "0.1.39" -> "0.1.40"
>
> Signed-off-by: Viswas G <Viswas.G@microchip.com>
> Signed-off-by: Ruksar Devadi <Ruksar.devadi@microchip.com>
Acked-by: Jack Wang <jinpu.wang@cloud.ionos.com>
> ---
>  drivers/scsi/pm8001/pm8001_sas.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_sas.h b/drivers/scsi/pm8001/pm8001_sas.h
> index 9d7796a74ed4..95663e138083 100644
> --- a/drivers/scsi/pm8001/pm8001_sas.h
> +++ b/drivers/scsi/pm8001/pm8001_sas.h
> @@ -58,7 +58,7 @@
>  #include "pm8001_defs.h"
>
>  #define DRV_NAME               "pm80xx"
> -#define DRV_VERSION            "0.1.39"
> +#define DRV_VERSION            "0.1.40"
>  #define PM8001_FAIL_LOGGING    0x01 /* Error message logging */
>  #define PM8001_INIT_LOGGING    0x02 /* driver init logging */
>  #define PM8001_DISC_LOGGING    0x04 /* discovery layer logging */
> --
> 2.16.3
>