From patchwork Tue Aug 2 15:22:45 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101980 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp224175qga; Tue, 2 Aug 2016 08:23:59 -0700 (PDT) X-Received: by 10.98.133.10 with SMTP id u10mr89201178pfd.134.1470151439154; Tue, 02 Aug 2016 08:23:59 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ep4si3491787pac.211.2016.08.02.08.23.59 for ; Tue, 02 Aug 2016 08:23:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-scsi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-scsi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966501AbcHBPX3 (ORCPT ); Tue, 2 Aug 2016 11:23:29 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:59716 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965021AbcHBPXN (ORCPT ); Tue, 2 Aug 2016 11:23:13 -0400 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue103) with ESMTPA (Nemesis) id 0MNN9N-1bbSDl0k5h-006vOX; Tue, 02 Aug 2016 17:23:00 +0200 From: Arnd Bergmann To: Anil Gurumurthy , Sudarsana Kalluru Cc: "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Baoyou Xie , Arnd Bergmann Subject: [PATCH 0/5] bfa: fix W=1 build warnings Date: Tue, 2 Aug 2016 17:22:45 +0200 Message-Id: <20160802152250.1964074-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:cbAIqCG/FHYZ8nNtHnvE6eGThC6DCWtO0r81wx9pqtSMmt6oweu KzBa8py/pBemeMzToI2Lh/b7WCSwyU8GD7ZX8N3Psst2UUvdZtYc5L6COr9l0JgoA8fK7KG e5nDkSary5Lrc95PblmyUyxEz9Z4KHdLsAXHc5rpw4Ei98FAV8SxBIF6kkylCc5hd1/dl0y mvrxMBJDFQS++jv+Uweew== X-UI-Out-Filterresults: notjunk:1; V01:K0:tWhI8Phnbns=:AO0cj7gWmq+o9fuM7e+17K SUGCh6Zd576FcXPq8A8PpvTvfAJs03HJ1tVIJ5L3Rnpa24ojqsKylSpLDta5m/YlypOJOmht9 PgqiEKxRZhu1jPdVZCxDrMK9zb7odrV1uyrwztUFrm91brmirX/lBxw6bhhCl+77cVlOMiuJ6 lSgmHatPZg8B+MFPPM52XSqLzk0FqkH0IrYBkWd6iWs3IqvsASEMQMq9iu2ZEzp6mCE6J4fPq 28uCUX7AcAqz0M+pP3/jBzMALQfEOteuwD3kQewedxrO5tCy6nHfgjmON2a8eR3cl8dtH5het 5utBsiog6U5cQ3VbOPvyhiiEVm3roQl6SiuBT/VBe0RYlGHK1KwmBQYJG32sghxPck6uyPQ1P bxr/HefBpuDNl+m0AEUEEOXp0V50DAs86ldBKGkm+eX5bWEhJj8MLBGK2IEn9jPPTOac+NFWD L0SrqGIzF6hiK/P5XkrwxN0e8TEyGSRZa3vANYZJgGRQOYHM/8CxBG7oOE0wUODnfYo4cgsBS IPfDCAHaWp8qh/WM/susFep459CtyGPsYYuQBcb6ZDrmhgp5EwSmDWEyDgOLktTyOTlV9ni/E 42ZRbqLJE4gayLB8jlSdP4B6LCJDpzBADhJudT3+ixyuXEYNn66tqtJcjY/gQZmxNfd3MmcNp wetB4F3Q0X+X91aE80E+thWdnVWciu7UQnFaTIalXRw0mw20InKxCk+qMV2yuN5ZAysg= Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org I tried to build an allmodconfig kernel with W=1, and the bfa driver stuck out for having the most warnings in one file, so I decided to send patches for all of these and make the driver build cleanly with the extra warnings enabled. As most warnings were for functions that lacked a 'static', I marked them that way, and also used a script to look for further functions that have a declaration but can also be static. Overall, this saves around 10% of the size of the driver module: text data bss dec hex filename 232027 3012 976 236015 399ef drivers/scsi/bfa/bfa-before.o 221851 2996 908 225755 371db drivers/scsi/bfa/bfa-after.o Arnd Arnd Bergmann (5): bfa: mark symbols static where possible bfa: remove unused variables bfa: rename some global variables bfa: remove unused functions from fbbuild.c bfa: remove more unused functions drivers/scsi/bfa/bfa.h | 17 -- drivers/scsi/bfa/bfa_core.c | 54 +--- drivers/scsi/bfa/bfa_fcbuild.c | 609 +-------------------------------------- drivers/scsi/bfa/bfa_fcbuild.h | 90 ------ drivers/scsi/bfa/bfa_fcpim.c | 81 +++--- drivers/scsi/bfa/bfa_fcpim.h | 26 -- drivers/scsi/bfa/bfa_fcs.c | 31 +- drivers/scsi/bfa/bfa_fcs.h | 54 ---- drivers/scsi/bfa/bfa_fcs_lport.c | 211 +++----------- drivers/scsi/bfa/bfa_fcs_rport.c | 48 +-- drivers/scsi/bfa/bfa_ioc.c | 83 ++---- drivers/scsi/bfa/bfa_ioc.h | 25 -- drivers/scsi/bfa/bfa_ioc_cb.c | 3 +- drivers/scsi/bfa/bfa_ioc_ct.c | 12 +- drivers/scsi/bfa/bfa_plog.h | 8 - drivers/scsi/bfa/bfa_port.c | 6 +- drivers/scsi/bfa/bfa_port.h | 1 - drivers/scsi/bfa/bfa_svc.c | 95 ++---- drivers/scsi/bfa/bfa_svc.h | 17 -- drivers/scsi/bfa/bfad.c | 128 ++++---- drivers/scsi/bfa/bfad_attr.c | 9 +- drivers/scsi/bfa/bfad_bsg.c | 224 +++++++------- drivers/scsi/bfa/bfad_drv.h | 49 +--- drivers/scsi/bfa/bfad_im.c | 29 +- drivers/scsi/bfa/bfad_im.h | 10 - 25 files changed, 395 insertions(+), 1525 deletions(-) -- 2.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html