| Message ID | 1665998435-199946-1-git-send-email-john.garry@huawei.com |
|---|---|
| Headers | show |
| Series | libsas and drivers: NCQ error handling | expand |
On Mon, 17 Oct 2022 17:20:27 +0800, John Garry wrote: > As reported in [0], the pm8001 driver NCQ error handling more or less > duplicates what libata does in link error handling, as follows: > - abort all commands > - do autopsy with read log ext 10 command > - reset the target to recover, if necessary > > Indeed for the hisi_sas driver we want to add similar handling for NCQ > errors. > > [...] Applied to 6.2/scsi-queue, thanks! [1/8] scsi: libsas: Add sas_ata_device_link_abort() https://git.kernel.org/mkp/scsi/c/44112922674b [2/8] scsi: hisi_sas: Move slot variable definition in hisi_sas_abort_task() https://git.kernel.org/mkp/scsi/c/4b329abc9180 [3/8] scsi: hisi_sas: Add SATA_DISK_ERR bit handling for v3 hw https://git.kernel.org/mkp/scsi/c/930d97dabdd5 [4/8] scsi: hisi_sas: Modify v3 HW SATA disk error state completion processing https://git.kernel.org/mkp/scsi/c/4ef4f1a61555 [5/8] scsi: pm8001: Modify task abort handling for SATA task https://git.kernel.org/mkp/scsi/c/0b639decf651 [6/8] scsi: pm8001: Use sas_ata_device_link_abort() to handle NCQ errors https://git.kernel.org/mkp/scsi/c/811be570a9a8 [7/8] scsi: libsas: Make sas_{alloc, alloc_slow, free}_task() private https://git.kernel.org/mkp/scsi/c/8e8d43642f2f [8/8] scsi: libsas: Update SATA dev FIS in sas_ata_task_done() https://git.kernel.org/mkp/scsi/c/cc22efbec011
As reported in [0], the pm8001 driver NCQ error handling more or less duplicates what libata does in link error handling, as follows: - abort all commands - do autopsy with read log ext 10 command - reset the target to recover, if necessary Indeed for the hisi_sas driver we want to add similar handling for NCQ errors. This series add a new libsas API - sas_ata_device_link_abort() - to handle host NCQ errors, and fixes up pm8001 and hisi_sas drivers to use it. A difference in the pm8001 driver NCQ error handling is that we send SATA_ABORT per-task prior to read log ext10, but I feel that this should not make a difference to the error handling. Finally with these changes we can make the libsas task alloc/free APIs private, which they should always have been. Based on v6.1-rc1 [0] https://lore.kernel.org/linux-scsi/8fb3b093-55f0-1fab-81f4-e8519810a978@huawei.com/ Changes since v5: - Change to set ATA_DRDY in sata dev fis for sas_ata_device_link_abort() and sas_ata_task_done() - Add Niklas' tags (thanks!) - Rebase Changes since v4: - Add Jason's tags (thanks) - Rebase Changes since v3: - Add Damien's tags (thanks) - Modify hisi_sas processing as follows: - use sas_task_abort() for rejected IO - Modify abort task processing to issue softreset in certain circumstances - rebase Changes since v2: - Stop sending SATA_ABORT all for pm8001 handling - Make "reset" optional in sas_ata_device_link_abort() - Drop Jack's ACK John Garry (6): scsi: libsas: Add sas_ata_device_link_abort() scsi: hisi_sas: Move slot variable definition in hisi_sas_abort_task() scsi: pm8001: Modify task abort handling for SATA task scsi: pm8001: Use sas_ata_device_link_abort() to handle NCQ errors scsi: libsas: Make sas_{alloc, alloc_slow, free}_task() private scsi: libsas: Update SATA dev FIS in sas_ata_task_done() Xingui Yang (2): scsi: hisi_sas: Add SATA_DISK_ERR bit handling for v3 hw scsi: hisi_sas: Modify v3 HW SATA disk error state completion processing drivers/scsi/hisi_sas/hisi_sas.h | 1 + drivers/scsi/hisi_sas/hisi_sas_main.c | 26 +++- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 53 ++++++- drivers/scsi/libsas/sas_ata.c | 19 ++- drivers/scsi/libsas/sas_init.c | 3 - drivers/scsi/libsas/sas_internal.h | 4 + drivers/scsi/pm8001/pm8001_hwi.c | 186 ++++--------------------- drivers/scsi/pm8001/pm8001_sas.c | 14 +- drivers/scsi/pm8001/pm8001_sas.h | 5 - drivers/scsi/pm8001/pm80xx_hwi.c | 177 +++-------------------- include/scsi/libsas.h | 4 - include/scsi/sas_ata.h | 6 + 12 files changed, 148 insertions(+), 350 deletions(-)