mbox series

[0/4] Some small cleanups for scsi/libsas

Message ID 1644561778-183074-1-git-send-email-chenxiang66@hisilicon.com
Headers show
Series Some small cleanups for scsi/libsas | expand

Message

chenxiang Feb. 11, 2022, 6:42 a.m. UTC
From: Xiang Chen <chenxiang66@hisilicon.com>

There are some cleanups related to scsi and libsas:
- Use void for sas_discover_event() return code;
- Remove duplicated setting for task->task_state_flags;
- Remove unused parameter for function sas_ata_eh();
- Remove unused member cmd_pool for structure scsi_host_template;

Xiang Chen (4):
  scsi: libsas: Use void for sas_discover_event() return code
  scsi: libsas: Remove duplicated setting for task->task_state_flags
  scsi: libsas: Remove unused parameter for function sas_ata_eh()
  scsi: Remove unused member cmd_pool for structure scsi_host_template

 drivers/scsi/libsas/sas_ata.c       | 4 +---
 drivers/scsi/libsas/sas_discover.c  | 6 ++----
 drivers/scsi/libsas/sas_scsi_host.c | 2 +-
 include/scsi/libsas.h               | 2 +-
 include/scsi/sas_ata.h              | 6 ++----
 include/scsi/scsi_host.h            | 3 ---
 6 files changed, 7 insertions(+), 16 deletions(-)

Comments

John Garry Feb. 11, 2022, 9:10 a.m. UTC | #1
On 11/02/2022 06:42, chenxiang wrote:
> From: Xiang Chen<chenxiang66@hisilicon.com>
> 
> After the commit e9c787e65c0c ("scsi: allocate scsi_cmnd structures as
> part of struct request"), the member cmd_pool in structure
> scsi_host_template is not used, so remove it.
> 
> Signed-off-by: Xiang Chen<chenxiang66@hisilicon.com>
> ---

Reviewed-by: John Garry <john.garry@huawei.com>
Martin K. Petersen Feb. 15, 2022, 3:19 a.m. UTC | #2
On Fri, 11 Feb 2022 14:42:54 +0800, chenxiang wrote:

> From: Xiang Chen <chenxiang66@hisilicon.com>
> 
> There are some cleanups related to scsi and libsas:
> - Use void for sas_discover_event() return code;
> - Remove duplicated setting for task->task_state_flags;
> - Remove unused parameter for function sas_ata_eh();
> - Remove unused member cmd_pool for structure scsi_host_template;
> 
> [...]

Applied to 5.18/scsi-queue, thanks!

[1/4] scsi: libsas: Use void for sas_discover_event() return code
      https://git.kernel.org/mkp/scsi/c/26d4a969dd05
[2/4] scsi: libsas: Remove duplicated setting for task->task_state_flags
      https://git.kernel.org/mkp/scsi/c/59803ccb657d
[3/4] scsi: libsas: Remove unused parameter for function sas_ata_eh()
      https://git.kernel.org/mkp/scsi/c/3a20e64281fd
[4/4] scsi: Remove unused member cmd_pool for structure scsi_host_template
      https://git.kernel.org/mkp/scsi/c/23406e4d1f1e