From patchwork Tue Jan 29 13:36:47 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sylwester Nawrocki/Kernel \\\(PLT\\\) /SRPOL/Staff Engineer/Samsung Electronics" X-Patchwork-Id: 14335 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id EA72023E2E for ; Tue, 29 Jan 2013 13:36:55 +0000 (UTC) Received: from mail-vb0-f49.google.com (mail-vb0-f49.google.com [209.85.212.49]) by fiordland.canonical.com (Postfix) with ESMTP id 7C535A188DE for ; Tue, 29 Jan 2013 13:36:55 +0000 (UTC) Received: by mail-vb0-f49.google.com with SMTP id s24so257521vbi.8 for ; Tue, 29 Jan 2013 05:36:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-auditid:message-id:date:from:user-agent:mime-version :to:cc:subject:references:in-reply-to:content-type :content-transfer-encoding:x-brightmail-tracker:x-gm-message-state; bh=Kk4OQZoRDie5tQ4XACdbz42prI8lN0QkLT8LqadBv1c=; b=KD1mIr7G8FXTpKkgm1zYN/miSoEX5eHwaqatNJGV2bMNQAXPcdX+1M54FTt4RXV1F0 0GXkbdhEym3gxpLIrq6eiDHmVhCdFKovo7sy5QMa4457WiG42LX9cDsaAidir5iTWUag d5XbkeuHtZjGUMIGIRt117NlNHvUcmx/CNjazA+SzeISHYrMWoL7hb+0cbDxWwIS9Yp0 L8+mAYdbmfbJ7SDEoiOahFObWo5RtDODOuo7PehfRKSwPeL3qnNERRqg2/NNOupcbxJ5 Y1owKv/zLVfUFeIrDDL1wBv2pj6Nkpgan6AVmzQDEMMy/KP3e02yKJyy2bY5UKRMfCLr OyXA== X-Received: by 10.220.238.139 with SMTP id ks11mr918794vcb.49.1359466614937; Tue, 29 Jan 2013 05:36:54 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.58.145.101 with SMTP id st5csp136266veb; Tue, 29 Jan 2013 05:36:54 -0800 (PST) X-Received: by 10.66.78.100 with SMTP id a4mr2918657pax.4.1359466613572; Tue, 29 Jan 2013 05:36:53 -0800 (PST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com. [210.118.77.11]) by mx.google.com with ESMTP id ra6si12508729pbc.68.2013.01.29.05.36.53; Tue, 29 Jan 2013 05:36:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of s.nawrocki@samsung.com designates 210.118.77.11 as permitted sender) client-ip=210.118.77.11; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of s.nawrocki@samsung.com designates 210.118.77.11 as permitted sender) smtp.mail=s.nawrocki@samsung.com Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MHE005HN31ZT570@mailout1.w1.samsung.com>; Tue, 29 Jan 2013 13:36:51 +0000 (GMT) X-AuditID: cbfec7f4-b7f6d6d000001620-1c-5107d0735e59 Received: from eusync1.samsung.com ( [203.254.199.211]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id FD.3C.05664.370D7015; Tue, 29 Jan 2013 13:36:51 +0000 (GMT) Received: from [106.116.147.32] by eusync1.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0MHE008SV35FWW50@eusync1.samsung.com>; Tue, 29 Jan 2013 13:36:51 +0000 (GMT) Message-id: <5107D06F.4000002@samsung.com> Date: Tue, 29 Jan 2013 14:36:47 +0100 From: Sylwester Nawrocki User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-version: 1.0 To: Sachin Kamat Cc: linux-samsung-soc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, kgene.kim@samsung.com, patches@linaro.org Subject: Re: [PATCH 2/6] ARM: dts: Add MFC codec support for Exynos4 DT machines References: <1359432822-23846-1-git-send-email-sachin.kamat@linaro.org> <1359432822-23846-3-git-send-email-sachin.kamat@linaro.org> In-reply-to: <1359432822-23846-3-git-send-email-sachin.kamat@linaro.org> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprILMWRmVeSWpSXmKPExsVy+t/xy7rFF9gDDdY8N7KYcvgLi8XJP72M Dkwed67tYQtgjOKySUnNySxLLdK3S+DK2Pfdr+CNSMWH1RsYGxjPCXQxcnJICJhI3Dn9lxnC FpO4cG89WxcjF4eQwFJGiV07f7FDOJ8YJbbPnMoOUsUroCXxa/0npi5GDg4WAVWJM1NtQcJs AoYSvUf7GEFsUYEAicVLzkGVC0r8mHyPBcQWAWp92b2cCcRmFiiXOHrqKJgtDFS/7vk6Johd rYwSm2dsZANJcAp4SJzpX8oO0aAjsb91GhuELS+xec1b5gmMArOQ7JiFpGwWkrIFjMyrGEVT S5MLipPScw31ihNzi0vz0vWS83M3MUKC8csOxsXHrA4xCnAwKvHwNi5gCxRiTSwrrsw9xCjB wawkwutayx4oxJuSWFmVWpQfX1Sak1p8iJGJg1OqgVHoQoRl0+qJapJqalfW55n+57G4k/gl v/lxh3nPjKP1zyPedVV95Nt/si+Do2hD8Oxnpwonm9X+/i+ivmdz12F95V1xskVOruutuv5O u7h7iu7/GfX+P2/s4vpwhPekYKPzXuuvnB2/VZhZTkta9r1uTWs6cuuC4g2/MI4pfxZdExJL ehRV9FCJpTgj0VCLuag4EQCVBe6FJAIAAA== X-Gm-Message-State: ALoCoQngbCjZ4vpJY/KdlUmKgCSYd3TIPYmelPQIjxQoGIJ4MipJrHqQ488ekbGFE0CaOPBeJDwA On 01/29/2013 05:13 AM, Sachin Kamat wrote: > This patch adds MFC codec support for Exynos4 DT machines. > > Signed-off-by: Sachin Kamat > --- > arch/arm/boot/dts/exynos4.dtsi | 7 +++++++ > arch/arm/mach-exynos/mach-exynos4-dt.c | 17 +++++++++++++++++ > 2 files changed, 24 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi > index e1347fc..1122fb1 100644 > --- a/arch/arm/boot/dts/exynos4.dtsi > +++ b/arch/arm/boot/dts/exynos4.dtsi > @@ -289,4 +289,11 @@ > interrupts = <0 34 0>; > }; > }; > + > + mfc: codec@13400000 { > + compatible = "samsung,mfc-v5"; > + reg = <0x13400000 0x10000>; > + interrupts = <0 94 0>; > + samsung,power-domain = <&pd_mfc>; Please add: status = "disabled"; > + }; > }; > diff --git a/arch/arm/mach-exynos/mach-exynos4-dt.c b/arch/arm/mach-exynos/mach-exynos4-dt.c > index ab1dacc..8ae8da1 100644 > --- a/arch/arm/mach-exynos/mach-exynos4-dt.c > +++ b/arch/arm/mach-exynos/mach-exynos4-dt.c > @@ -12,7 +12,9 @@ > */ > > #include > +#include > #include > +#include > > #include > #include > @@ -20,6 +22,7 @@ > > #include > #include > +#include > > #include "common.h" > > @@ -80,6 +83,7 @@ static const struct of_dev_auxdata exynos4_auxdata_lookup[] __initconst = { > OF_DEV_AUXDATA("arm,pl330", EXYNOS4_PA_MDMA1, "dma-pl330.2", NULL), > OF_DEV_AUXDATA("samsung,exynos4210-tmu", EXYNOS4_PA_TMU, > "exynos-tmu", NULL), > + OF_DEV_AUXDATA("samsung,mfc-v5", 0x13400000, "s5p-mfc", NULL), > {}, > }; > > @@ -102,6 +106,18 @@ static char const *exynos4_dt_compat[] __initdata = { > NULL > }; > > +static void __init exynos4_reserve(void) > +{ > +#ifdef CONFIG_S5P_DEV_MFC Where is this symbol supposed to be enabled ? Don't you need a change like this as a part of this patch ? --- Thanks, Sylwester diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig index 1d9312a..1ae72d9 100644 --- a/arch/arm/mach-exynos/Kconfig +++ b/arch/arm/mach-exynos/Kconfig @@ -413,6 +413,7 @@ config MACH_EXYNOS4_DT select USE_OF select EXYNOS4_SETUP_USB_PHY select ARM_DMA_USE_IOMMU if EXYNOS_IOMMU + select S5P_DEV_MFC help Machine support for Samsung Exynos4 machine with device tree enabled. Select this if a fdt blob is available for the Exynos4 SoC based board.