From patchwork Mon Mar 26 04:32:57 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: KOBAYASHI Yoshitake X-Patchwork-Id: 7456 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 250FF23E13 for ; Mon, 26 Mar 2012 04:33:25 +0000 (UTC) Received: from mail-iy0-f180.google.com (mail-iy0-f180.google.com [209.85.210.180]) by fiordland.canonical.com (Postfix) with ESMTP id D28A8A18165 for ; Mon, 26 Mar 2012 04:33:24 +0000 (UTC) Received: by iage36 with SMTP id e36so10200435iag.11 for ; Sun, 25 Mar 2012 21:33:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:message-id :date:from:user-agent:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding :x-gm-message-state; bh=gRFJU6y48iLRGn+ilLN0Prf7oOu/pvJ38zvfIH2tgGo=; b=pY9/Ji61v8ULIEIlBfwFc8IkhbQrCiNTH3AqcLLO30+Rrr1vfkX2ZPf0Ibb8ni5T1d OFebVE1divJJYrOKbvCfpfoDIDI+vE2KT6ZgjrH7N7bMp50zDgxfKyhBCPnAJavmUayj CrJPoiqD4nC2GYKhhNOLFNWl+kxNyL9c+B4112DXYF2G2Eov+db8nSokBz3h0flPA+IC EmgxmvQ8v8g3FSv0rpjq8Xu2JPR44XO9MMF6bKUlJLb9BlKb2N7C+Y+8iBfKmWGonlS5 soNkhE7wV6wLVz9Kaq9Qk67bJcWHu5wAmxBOVq7OPvS0ZdLn3JBehBwg4Rujv2MXsb1K gOkA== Received: by 10.50.191.233 with SMTP id hb9mr4499869igc.44.1332736404245; Sun, 25 Mar 2012 21:33:24 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.231.5.205 with SMTP id 13csp8717ibw; Sun, 25 Mar 2012 21:33:23 -0700 (PDT) Received: by 10.68.189.138 with SMTP id gi10mr37067159pbc.89.1332736401745; Sun, 25 Mar 2012 21:33:21 -0700 (PDT) Received: from imx12.toshiba.co.jp (imx12.toshiba.co.jp. [61.202.160.132]) by mx.google.com with ESMTPS id e9si17147361pbi.51.2012.03.25.21.33.20 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 25 Mar 2012 21:33:21 -0700 (PDT) Received-SPF: pass (google.com: domain of yoshitake.kobayashi@toshiba.co.jp designates 61.202.160.132 as permitted sender) client-ip=61.202.160.132; Authentication-Results: mx.google.com; spf=pass (google.com: domain of yoshitake.kobayashi@toshiba.co.jp designates 61.202.160.132 as permitted sender) smtp.mail=yoshitake.kobayashi@toshiba.co.jp Received: from arc11.toshiba.co.jp ([133.199.90.127]) by imx12.toshiba.co.jp with ESMTP id q2Q4Wx7F026339; Mon, 26 Mar 2012 13:32:59 +0900 (JST) Received: (from root@localhost) by arc11.toshiba.co.jp id q2Q4Wxus024580; Mon, 26 Mar 2012 13:32:59 +0900 (JST) Received: from ovp11.toshiba.co.jp [133.199.90.148] by arc11.toshiba.co.jp with ESMTP id PAA24579; Mon, 26 Mar 2012 13:32:59 +0900 Received: from mx11.toshiba.co.jp (localhost [127.0.0.1]) by ovp11.toshiba.co.jp with ESMTP id q2Q4WxB4023012; Mon, 26 Mar 2012 13:32:59 +0900 (JST) Received: from BK2211.rdc.toshiba.co.jp by toshiba.co.jp id q2Q4WwSI017605; Mon, 26 Mar 2012 13:32:58 +0900 (JST) Received: from island.swc.toshiba.co.jp (localhost [127.0.0.1]) by BK2211.rdc.toshiba.co.jp (8.13.8+Sun/8.13.8) with ESMTP id q2Q4Wwrc000726; Mon, 26 Mar 2012 13:32:58 +0900 (JST) Received: from [133.196.174.107] (unknown [133.196.174.107]) by island.swc.toshiba.co.jp (Postfix) with ESMTP id 5002740002; Mon, 26 Mar 2012 13:32:58 +0900 (JST) Message-ID: <4F6FF179.5090600@toshiba.co.jp> Date: Mon, 26 Mar 2012 13:32:57 +0900 From: KOBAYASHI Yoshitake User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:11.0) Gecko/20120312 Thunderbird/11.0 MIME-Version: 1.0 To: Santosh Y Cc: James Bottomley , linux-scsi@vger.kernel.org, patches@linaro.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, arnd.bergmann@linaro.org, saugata.das@linaro.org, dsaxena@linaro.org, stephen.doel@linaro.org, venkat@linaro.org, ilho215.lee@samsung.com, nala.la@samsung.com, girish.shivananjappa@linaro.org, vishak.g@samsung.com, k.rajesh@samsung.com, yejin.moon@samsung.com, sreekumar.c@samsung.com, vinholikatti@gmail.com, linkinjeon@gmail.com, michaelc@cs.wisc.edu Subject: Re: [PATCH v3 1/5] [SCSI] ufshcd: UFS Host controller driver References: <1330497714-26504-2-git-send-email-santoshsy@gmail.com> In-Reply-To: <1330497714-26504-2-git-send-email-santoshsy@gmail.com> X-Gm-Message-State: ALoCoQniqt2OBzMT1rIfK0F4kp8dXpTbWtnTujSyCCMJ4/4R2mNVVo6WwImUdckWjRhYf9Rb3pPe > > + utrdlp[i].response_upiu_length = > > + cpu_to_le16(ALIGNED_UPIU_SIZE); Response UPIU Length(RUL) shows the response UPIU length in Dword. (JEDEC Standard No.223 6.2.1 UTP Transfer Request Descriptor) The following will be correct. diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 07ec973..feffe65 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -836,7 +836,7 @@ static void ufshcd_host_memory_configure(struct ufs_hba *hba) utrdlp[i].prd_table_offset = cpu_to_le16((prdt_offset >> 2)); utrdlp[i].response_upiu_length = - cpu_to_le16(ALIGNED_UPIU_SIZE); + cpu_to_le16(ALIGNED_UPIU_SIZE >> 2); hba->lrb[i].utr_descriptor_ptr = (utrdlp + i); hba->lrb[i].ucd_cmd_ptr =