| Message ID | 20241127-gs101-phy-lanes-orientation-dts-v1-2-5222d8508b71@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | Google Pixel 6 (oriole): TCPCI enablement & USB updates | expand |
On Wed, Nov 27, 2024 at 11:01:40AM +0000, André Draszik wrote: > On the surface, Maxim's max77759 appears identical to max33359. It > should still have a dedicated compatible, though, as it is a different > IC. This will allow for handling differences in case they are > discovered in the future. > > max77759 is used on Google Pixel 6 and Pixel 6 Pro. > > Add a dedicated compatible to allow for potential differences in the > future. > > Signed-off-by: André Draszik <andre.draszik@linaro.org> Acked-by: Conor Dooley <conor.dooley@microchip.com>
On 27/11/2024 12:01, André Draszik wrote: > On the surface, Maxim's max77759 appears identical to max33359. It > should still have a dedicated compatible, though, as it is a different > IC. This will allow for handling differences in case they are > discovered in the future. > > max77759 is used on Google Pixel 6 and Pixel 6 Pro. > > Add a dedicated compatible to allow for potential differences in the > future. > > Signed-off-by: André Draszik <andre.draszik@linaro.org> This should be sent separately to USB. Best regards, Krzysztof
On Thu, 2024-11-28 at 09:17 +0100, Krzysztof Kozlowski wrote: > On 27/11/2024 12:01, André Draszik wrote: > > On the surface, Maxim's max77759 appears identical to max33359. It > > should still have a dedicated compatible, though, as it is a different > > IC. This will allow for handling differences in case they are > > discovered in the future. > > > > max77759 is used on Google Pixel 6 and Pixel 6 Pro. > > > > Add a dedicated compatible to allow for potential differences in the > > future. > > > > Signed-off-by: André Draszik <andre.draszik@linaro.org> > > This should be sent separately to USB. Sorry, it slipped through into this series somehow. Will do. Thanks Andre
diff --git a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml index 20b62228371b..e11ede3684d4 100644 --- a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml +++ b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml @@ -13,8 +13,12 @@ description: Maxim TCPCI Type-C PD controller properties: compatible: - enum: - - maxim,max33359 + oneOf: + - enum: + - maxim,max33359 + - items: + - const: maxim,max77759 + - const: maxim,max33359 reg: maxItems: 1
On the surface, Maxim's max77759 appears identical to max33359. It should still have a dedicated compatible, though, as it is a different IC. This will allow for handling differences in case they are discovered in the future. max77759 is used on Google Pixel 6 and Pixel 6 Pro. Add a dedicated compatible to allow for potential differences in the future. Signed-off-by: André Draszik <andre.draszik@linaro.org> --- Documentation/devicetree/bindings/usb/maxim,max33359.yaml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)