diff mbox series

[2/2] pwm: Clarify PWMF_* enums definition

Message ID 20231109104748.2746839-2-m.szyprowski@samsung.com
State New
Headers show
Series [1/2] pwm: samsung: Fix broken resume after putting per-channel data into driver data | expand

Commit Message

Marek Szyprowski Nov. 9, 2023, 10:47 a.m. UTC 
PWMF_* enums are defined as flag values (like 1 << n), but then in the
code they are used as bit numbers via set/test/clear_bit() macros. Change
their values to sequential numbers to clearly show that they are bit
numbers, not the flag values.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
 include/linux/pwm.h | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/include/linux/pwm.h b/include/linux/pwm.h
index e3b437587b32..95c895c63cf6 100644
--- a/include/linux/pwm.h
+++ b/include/linux/pwm.h
@@ -40,9 +40,12 @@  struct pwm_args {
 	enum pwm_polarity polarity;
 };
 
-enum {
-	PWMF_REQUESTED = 1 << 0,
-	PWMF_EXPORTED = 1 << 1,
+/**
+ * enum pwm_flags_bits - status bits for pwm->flags entry
+ */
+enum pwm_flags_bits {
+	PWMF_REQUESTED = 0,
+	PWMF_EXPORTED = 1,
 };
 
 /*