| Message ID | 20230308233822.31180-8-semen.protsenko@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | clk: samsung: Enable PM in Exynos850 clk driver | expand |
On 09/03/2023 00:38, Sam Protsenko wrote: > As described in the corresponding binding documentation for > "samsung,exynos850-pmu", the "clocks" property should be used for > specifying CLKOUT mux inputs. Therefore, the clock provided to exynos850 > pmu_system_controller is incorrect and should be removed. Instead of > making syscon regmap keep that clock running for PMU accesses, it should > be made always running in the clock driver, because the kernel is not > the only software accessing PMU registers on Exynos850 platform. > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > --- > arch/arm64/boot/dts/exynos/exynos850.dtsi | 1 - > 1 file changed, 1 deletion(-) To avoid any bisectability issues, I will apply this in the next cycle. Best regards, Krzysztof
On Wed, 08 Mar 2023 17:38:22 -0600, Sam Protsenko wrote: > As described in the corresponding binding documentation for > "samsung,exynos850-pmu", the "clocks" property should be used for > specifying CLKOUT mux inputs. Therefore, the clock provided to exynos850 > pmu_system_controller is incorrect and should be removed. Instead of > making syscon regmap keep that clock running for PMU accesses, it should > be made always running in the clock driver, because the kernel is not > the only software accessing PMU registers on Exynos850 platform. > > [...] Applied, thanks! [7/7] arm64: dts: exynos: Remove clock from Exynos850 pmu_system_controller https://git.kernel.org/krzk/linux/c/858fd147234dbb66401bc102968a479f92e7ad43 Best regards,
diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi b/arch/arm64/boot/dts/exynos/exynos850.dtsi index d67e98120313..aa077008b3be 100644 --- a/arch/arm64/boot/dts/exynos/exynos850.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi @@ -200,7 +200,6 @@ gic: interrupt-controller@12a01000 { pmu_system_controller: system-controller@11860000 { compatible = "samsung,exynos850-pmu", "syscon"; reg = <0x11860000 0x10000>; - clocks = <&cmu_apm CLK_GOUT_PMU_ALIVE_PCLK>; reboot: syscon-reboot { compatible = "syscon-reboot";
As described in the corresponding binding documentation for "samsung,exynos850-pmu", the "clocks" property should be used for specifying CLKOUT mux inputs. Therefore, the clock provided to exynos850 pmu_system_controller is incorrect and should be removed. Instead of making syscon regmap keep that clock running for PMU accesses, it should be made always running in the clock driver, because the kernel is not the only software accessing PMU registers on Exynos850 platform. Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> --- arch/arm64/boot/dts/exynos/exynos850.dtsi | 1 - 1 file changed, 1 deletion(-)