diff mbox series

[1/2] ARM: dts: exynos: drop simple-bus from FIMC in Exynos4

Message ID 20230207193254.550236-1-krzysztof.kozlowski@linaro.org
State New
Headers show
Series [1/2] ARM: dts: exynos: drop simple-bus from FIMC in Exynos4 | expand

Commit Message

Krzysztof Kozlowski Feb. 7, 2023, 7:32 p.m. UTC
The FIMC camera node wrapper is not a bus, so using simple-bus fallback
compatible just to instantiate its children nodes was never correct.
Dropping simple-bus node fixes warnings:

  exynos4210-smdkv310.dtb: camera: $nodename:0: 'camera' does not match '^([a-z][a-z0-9\\-]+-bus|bus|localbus|soc|axi|ahb|apb)(@.+)?$'

The change is not backwards compatible and expects the FIMC driver to
populate its children.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Depends on:
https://lore.kernel.org/linux-samsung-soc/20230207192914.549309-1-krzysztof.kozlowski@linaro.org/T/#t
---
 arch/arm/boot/dts/exynos4.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Krzysztof Kozlowski May 8, 2023, 5:04 p.m. UTC | #1
On Tue, 07 Feb 2023 20:32:53 +0100, Krzysztof Kozlowski wrote:
> The FIMC camera node wrapper is not a bus, so using simple-bus fallback
> compatible just to instantiate its children nodes was never correct.
> Dropping simple-bus node fixes warnings:
> 
>   exynos4210-smdkv310.dtb: camera: $nodename:0: 'camera' does not match '^([a-z][a-z0-9\\-]+-bus|bus|localbus|soc|axi|ahb|apb)(@.+)?$'
> 
> The change is not backwards compatible and expects the FIMC driver to
> populate its children.
> 
> [...]

Applied, thanks!

[1/2] ARM: dts: exynos: drop simple-bus from FIMC in Exynos4
      https://git.kernel.org/krzk/linux/c/a1ca56099819f4b2c52bfe23b7be13b0d53a2a4a
[2/2] ARM: dts: s5pv210: drop simple-bus from FIMC
      https://git.kernel.org/krzk/linux/c/0070e0fcc522aebe2461714074f7637cab70e688

Best regards,
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index 8dd6976ab0a7..434025331041 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -201,8 +201,8 @@  dsi_0: dsi@11c80000 {
 			#size-cells = <0>;
 		};
 
-		camera: camera {
-			compatible = "samsung,fimc", "simple-bus";
+		camera: camera@11800000 {
+			compatible = "samsung,fimc";
 			status = "disabled";
 			#address-cells = <1>;
 			#size-cells = <1>;