| Message ID | 20220913164104.203957-1-dmitry.torokhov@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] ARM: dts: exynos: correct s5k6a3 reset polarity on Midas family | expand |
On Tue, Sep 13, 2022 at 6:41 PM Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > According to s5k6a3 driver code, the reset line for the chip appears to > be active low. This also matches the typical polarity of reset lines in > general. Let's fix it up as having correct polarity in DTS is important > when the driver will be switched over to gpiod API. > > Fixes: b4fec64758ab ("ARM: dts: Add camera device nodes for Exynos4412 TRATS2 board") > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Excellent catch! Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Tue, Sep 13, 2022 at 6:41 PM Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > This patch switches the driver away from legacy gpio/of_gpio API to > gpiod API, and removes one of the last uses of of_get_gpio_flags(). > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Tue, 13 Sep 2022 09:41:03 -0700, Dmitry Torokhov wrote: > According to s5k6a3 driver code, the reset line for the chip appears to > be active low. This also matches the typical polarity of reset lines in > general. Let's fix it up as having correct polarity in DTS is important > when the driver will be switched over to gpiod API. > > Applied, thanks! [1/2] ARM: dts: exynos: correct s5k6a3 reset polarity on Midas family https://git.kernel.org/krzk/linux/c/f539422ddaff0680dd1d4ad94df11be4703ccc93 Best regards,
diff --git a/arch/arm/boot/dts/exynos4412-midas.dtsi b/arch/arm/boot/dts/exynos4412-midas.dtsi index b967397a46c5..8e1c19a8ad06 100644 --- a/arch/arm/boot/dts/exynos4412-midas.dtsi +++ b/arch/arm/boot/dts/exynos4412-midas.dtsi @@ -586,7 +586,7 @@ image-sensor@10 { clocks = <&camera 1>; clock-names = "extclk"; samsung,camclk-out = <1>; - gpios = <&gpm1 6 GPIO_ACTIVE_HIGH>; + gpios = <&gpm1 6 GPIO_ACTIVE_LOW>; port { is_s5k6a3_ep: endpoint {
According to s5k6a3 driver code, the reset line for the chip appears to be active low. This also matches the typical polarity of reset lines in general. Let's fix it up as having correct polarity in DTS is important when the driver will be switched over to gpiod API. Fixes: b4fec64758ab ("ARM: dts: Add camera device nodes for Exynos4412 TRATS2 board") Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- arch/arm/boot/dts/exynos4412-midas.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)