diff mbox series

[1/2] ARM: s3c: irq-s3c24xx: include headers for missing declarations

Message ID 20210206133615.119804-1-krzk@kernel.org
State New
Headers show
Series [1/2] ARM: s3c: irq-s3c24xx: include headers for missing declarations | expand

Commit Message

Krzysztof Kozlowski Feb. 6, 2021, 1:36 p.m. UTC
Include headers to fix W=1 build warnings:

  arch/arm/mach-s3c/irq-s3c24xx.c:389:5: warning:
    no previous prototype for ‘s3c24xx_set_fiq’ [-Wmissing-prototypes]
  arch/arm/mach-s3c/irq-s3c24xx.c:683:13: warning:
    no previous prototype for ‘s3c2410_init_irq’ [-Wmissing-prototypes]

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm/mach-s3c/irq-s3c24xx.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Krzysztof Kozlowski Feb. 8, 2021, 5:10 p.m. UTC | #1
On Sat, 6 Feb 2021 14:36:14 +0100, Krzysztof Kozlowski wrote:
> Include headers to fix W=1 build warnings:

> 

>   arch/arm/mach-s3c/irq-s3c24xx.c:389:5: warning:

>     no previous prototype for ‘s3c24xx_set_fiq’ [-Wmissing-prototypes]

>   arch/arm/mach-s3c/irq-s3c24xx.c:683:13: warning:

>     no previous prototype for ‘s3c2410_init_irq’ [-Wmissing-prototypes]


Applied, thanks!

[1/2] ARM: s3c: irq-s3c24xx: include headers for missing declarations
      commit: 49dc85ca3c78d938d9eb41e05efcd85c92626e84

Best regards,
-- 
Krzysztof Kozlowski <krzk@kernel.org>
Krzysztof Kozlowski Feb. 8, 2021, 5:10 p.m. UTC | #2
On Sat, 6 Feb 2021 14:36:14 +0100, Krzysztof Kozlowski wrote:
> Include headers to fix W=1 build warnings:

> 

>   arch/arm/mach-s3c/irq-s3c24xx.c:389:5: warning:

>     no previous prototype for ‘s3c24xx_set_fiq’ [-Wmissing-prototypes]

>   arch/arm/mach-s3c/irq-s3c24xx.c:683:13: warning:

>     no previous prototype for ‘s3c2410_init_irq’ [-Wmissing-prototypes]


Applied, thanks!

[2/2] ARM: s3c: irq-s3c24xx: staticize local functions
      commit: f503878564f5e68c1aeb1ea01e437060bf905c50

Best regards,
-- 
Krzysztof Kozlowski <krzk@kernel.org>
diff mbox series

Patch

diff --git a/arch/arm/mach-s3c/irq-s3c24xx.c b/arch/arm/mach-s3c/irq-s3c24xx.c
index 79b5f19af7a5..3368159d3f3e 100644
--- a/arch/arm/mach-s3c/irq-s3c24xx.c
+++ b/arch/arm/mach-s3c/irq-s3c24xx.c
@@ -21,6 +21,7 @@ 
 #include <linux/of.h>
 #include <linux/of_irq.h>
 #include <linux/of_address.h>
+#include <linux/spi/s3c24xx.h>
 
 #include <asm/exception.h>
 #include <asm/mach/irq.h>
@@ -32,6 +33,7 @@ 
 #include "cpu.h"
 #include "regs-irqtype.h"
 #include "pm.h"
+#include "s3c24xx.h"
 
 #define S3C_IRQTYPE_NONE	0
 #define S3C_IRQTYPE_EINT	1