From patchwork Sun Feb 14 05:22:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 61912 Delivered-To: patch@linaro.org Received: by 10.112.43.199 with SMTP id y7csp404360lbl; Sat, 13 Feb 2016 21:23:22 -0800 (PST) X-Received: by 10.66.145.194 with SMTP id sw2mr14050632pab.69.1455427402534; Sat, 13 Feb 2016 21:23:22 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y1si5027791pfi.229.2016.02.13.21.23.22; Sat, 13 Feb 2016 21:23:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-samsung-soc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-samsung-soc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-samsung-soc-owner@vger.kernel.org; dkim=neutral (body hash did not verify) header.i=@linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751472AbcBNFWh (ORCPT + 4 others); Sun, 14 Feb 2016 00:22:37 -0500 Received: from mail-pf0-f177.google.com ([209.85.192.177]:33379 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751427AbcBNFWf (ORCPT ); Sun, 14 Feb 2016 00:22:35 -0500 Received: by mail-pf0-f177.google.com with SMTP id q63so69284901pfb.0 for ; Sat, 13 Feb 2016 21:22:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=2m1gUq1iIGQZEyukW58lB/mYx83M8ubLz8BlyJE3Q4s=; b=XOadYZc+UhzyWxtGhm9mGQTE8PZtsR/yecjSUuxplhLnBTWzqj+C4sWN/ebZhA1GhG vf1zIMsN9IhQt6fcKFOgjplsX4MwOj03uPAeTPMRJ4a++5z74LSP93z3xtfgFjir7x1l 4kQY7s/IzSZgth7n3pOs4h9boT9RTHeErm4dc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=2m1gUq1iIGQZEyukW58lB/mYx83M8ubLz8BlyJE3Q4s=; b=SfVA+vOhExKo+Dyh28SaydQxl+gUblqxVVbzLjUAhbh8VeHDfnEpAlwiDlqeGNR/Eg NX5q2G+TwZCrg7R2i9XNklYxc83YGoeqwVKRuZLEayqhOhMzNIRbt2xnahjjz+xl6ja9 Txhw5i5nEcwIAOJqGLFRp0TzagcZjMpF5fOjfGG6s1PrfejQtM68tOfsCvsvBZJ6XJlD 9ef0Q/l/dIa7SM7lBmusbEiE3BDyNKWEf7/5L0jTXNc2269DakpI/BHevz3k6hXWIccX YnoqLJKavFBWsU0hlb9NVNR3XmhXz11XI5Vi82PUDM4nknXZw872RScmwNFzAcewSClE Rl9g== X-Gm-Message-State: AG10YOTsvoRWh/+C84HCKzqFgZXXEhOeC5vBA07XGM00G/jpLUpVdxUNxAeo4qZyjzKTpevm X-Received: by 10.98.19.205 with SMTP id 74mr14245004pft.31.1455427355355; Sat, 13 Feb 2016 21:22:35 -0800 (PST) Received: from localhost ([122.172.89.184]) by smtp.gmail.com with ESMTPSA id s23sm29476181pfi.12.2016.02.13.21.22.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 13 Feb 2016 21:22:34 -0800 (PST) Date: Sun, 14 Feb 2016 10:52:28 +0530 From: Viresh Kumar To: Krzysztof Kozlowski Cc: Stephen Boyd , "Rafael J. Wysocki" , Nishanth Menon , linux-pm@vger.kernel.org, Linux Kernel Mailing List , Kukjin Kim , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , Bartlomiej Zolnierkiewicz , Javier Martinez Canillas , Lukasz Majewski , Krzysztof Kozlowski Subject: Re: [next] Odroid XU3 boot fail after cpufreq: dt: Use dev_pm_opp_set_rate() to switch frequency Message-ID: <20160214052228.GA18226@vireshk-i7> References: <56C008F2.3080807@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <56C008F2.3080807@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On 14-02-16, 13:56, Krzysztof Kozlowski wrote: > Hi all, > > Recently Odroid XU3 failed to boot on linux-next > on multi_v7 defconfig. exynos defconfig boots fine. > > Probably the "cpufreq: dt: Use dev_pm_opp_set_rate() to > switch frequency" is important here: > commit 78c3ba5df96c875b1668e1cd3ee0a69e62454f32 > Author: Viresh Kumar > Date: Tue Feb 9 10:30:46 2016 +0530 > > cpufreq: dt: Use dev_pm_opp_set_rate() to switch frequency > > OPP core supports frequency/voltage changes based on the target > frequency now, use that instead of open coding the same in cpufreq-dt > driver. > > Signed-off-by: Viresh Kumar > Reviewed-by: Stephen Boyd > Signed-off-by: Rafael J. Wysocki Can you please try the below untested patch please ? -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/base/power/opp/core.c b/drivers/base/power/opp/core.c index d7cd4e265766..a97b333036c9 100644 --- a/drivers/base/power/opp/core.c +++ b/drivers/base/power/opp/core.c @@ -1156,9 +1156,15 @@ static int opp_parse_supplies(struct dev_pm_opp *opp, struct device *dev, return -EINVAL; } - opp->u_volt = microvolt[0]; - opp->u_volt_min = microvolt[1]; - opp->u_volt_max = microvolt[2]; + if (count == 1) { + opp->u_volt = microvolt[0]; + opp->u_volt_min = opp->u_volt; + opp->u_volt_max = opp->u_volt; + } else { + opp->u_volt = microvolt[0]; + opp->u_volt_min = microvolt[1]; + opp->u_volt_max = microvolt[2]; + } /* Search for "opp-microamp-" */ prop = NULL;