From patchwork Mon Apr 3 06:21:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 96592 Delivered-To: patch@linaro.org Received: by 10.140.89.233 with SMTP id v96csp1737241qgd; Sun, 2 Apr 2017 23:21:38 -0700 (PDT) X-Received: by 10.98.223.76 with SMTP id u73mr15506354pfg.147.1491200497950; Sun, 02 Apr 2017 23:21:37 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w9si13240525plk.296.2017.04.02.23.21.37; Sun, 02 Apr 2017 23:21:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-samsung-soc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-samsung-soc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-samsung-soc-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751772AbdDCGVg (ORCPT + 4 others); Mon, 3 Apr 2017 02:21:36 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:46875 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751344AbdDCGVY (ORCPT ); Mon, 3 Apr 2017 02:21:24 -0400 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0ONT005KULNLUA00@mailout1.w1.samsung.com>; Mon, 03 Apr 2017 07:21:21 +0100 (BST) Received: from eusmges2.samsung.com (unknown [203.254.199.241]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20170403062120eucas1p297cb6f0fc973fcc8b3e207e1cecde19f~xzu-IQy_E0795507955eucas1p2d; Mon, 3 Apr 2017 06:21:20 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2.samsung.com (EUCPMTA) with SMTP id 36.38.04459.0E9E1E85; Mon, 3 Apr 2017 07:21:20 +0100 (BST) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20170403062120eucas1p1369bcd47ca09d99c955baa551cdb1e06~xzu_dCGBf2360123601eucas1p1p; Mon, 3 Apr 2017 06:21:20 +0000 (GMT) X-AuditID: cbfec7f1-f796e6d00000116b-46-58e1e9e05b66 Received: from eusync2.samsung.com ( [203.254.199.212]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id BB.D6.20206.3F9E1E85; Mon, 3 Apr 2017 07:21:39 +0100 (BST) Received: from AMDC2765.digital.local ([106.116.147.25]) by eusync2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0ONT006EQLNBVO80@eusync2.samsung.com>; Mon, 03 Apr 2017 07:21:19 +0100 (BST) From: Marek Szyprowski To: linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org Cc: Marek Szyprowski , Sylwester Nawrocki , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Greg Kroah-Hartman , Seung-Woo Kim , Joonyoung Shim , Inki Dae Subject: [PATCH v3 3/3] serial: samsung: Remove useless spinlock Date: Mon, 03 Apr 2017 08:21:01 +0200 Message-id: <1491200468-28463-3-git-send-email-m.szyprowski@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1491200468-28463-1-git-send-email-m.szyprowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrAIsWRmVeSWpSXmKPExsWy7djPc7oPXj6MMDj2X9Vi44z1rBbNi9ez WUy6P4HF4sW9iywW589vYLeYcX4fk8WZxb3sFmuP3GW3OPymndVixuSXbA5cHptWdbJ57J+7 ht2jb8sqRo/Pm+QCWKK4bFJSczLLUov07RK4Mj6d2sZWMJ+9ovFUF1MDYw9bFyMnh4SAicS1 zQuYIWwxiQv31gPFuTiEBJYySlw7+QzK+cwo8WrmSvYuRg6wjqMvakEahASWMUrM3eADYTcw ScxpDQKx2QQMJbredoEtEBFwlph9diETyBxmgadMErv6NzGCzBEWcJCYsKIGpIZFQFXiytzT 7CA2r4CHRNeehYwQB8lJnDw2mRXE5hTwlJi7/wYzyBwJgf9sEvuW/IC6R1Zi0wGoB1wkjmw5 CmULS7w6voUdwpaRuDy5mwXC7meUaGrVhrBnMEqce8sLYVtLHD5+EWwXswCfxKRt05khxvNK dLQJQZR4SDzrnAp1mqPEzYMPoMEzh1Hi378z7BMYZRYwMqxiFEktLc5NTy020itOzC0uzUvX S87P3cQIjOfT/45/3MH4/oTVIUYBDkYlHt4LDg8jhFgTy4orcw8xSnAwK4nwxgOTgRBvSmJl VWpRfnxRaU5q8SFGaQ4WJXFerlPXIoQE0hNLUrNTUwtSi2CyTBycUg2MdU8/3k+QDBeNFbh3 vtqnd90TjVaXl+bLGmZHK/mYhHFsMrjxmyf38irvtm/vnjWf9uXfEPXiyNJHQgu9JTitvoYr nZkW+DwlhJXxyfaAh1JzlsT9nHfW7PUCnedGvRza3SGB66ZzaGqpvd82ZTbbG+bnl3MMIxZt LVi10/R9CcPdu4mnfmb6KbEUZyQaajEXFScCALVuJgbjAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrILMWRmVeSWpSXmKPExsVy+t/xK7qfXz6MMDi/k8li44z1rBbNi9ez WUy6P4HF4sW9iywW589vYLeYcX4fk8WZxb3sFmuP3GW3OPymndVixuSXbA5cHptWdbJ57J+7 ht2jb8sqRo/Pm+QCWKLcbDJSE1NSixRS85LzUzLz0m2VQkPcdC2UFPISc1NtlSJ0fUOClBTK EnNKgTwjAzTg4BzgHqykb5fglvHp1Da2gvnsFY2nupgaGHvYuhg5OCQETCSOvqjtYuQEMsUk LtxbDxTm4hASWMIocXLlSyYIp4lJYtPdt6wgVWwChhJdb7vYQGwRAWeJ2WcXMoHYzAIvmSQO bhYEGSos4CAxYUUNSJhFQFXiytzT7CA2r4CHRNeehYwQy+QkTh6bDDaSU8BTYu7+G8wgthBQ zbm+HvYJjLwLGBlWMYqklhbnpucWG+kVJ+YWl+al6yXn525iBAb3tmM/t+xg7HoXfIhRgINR iYdXw/lhhBBrYllxZe4hRgkOZiUR3nhgbAjxpiRWVqUW5ccXleakFh9iNAU6aiKzlGhyPjDy 8kriDU0MzS0NjYwtLMyNjJTEead+uBIuJJCeWJKanZpakFoE08fEwSnVwFg+o/uL3vefriJq 5WvP/3oU3XF7xtatChW/XkmzMFzOWLs2faFqMN89Xt+dDlyFC4z61c9Jrtkr3M/x4/BVtfzn Mybo9ja6W/5ZbfXO5NjRpC+73gSc8FsU9PGRhrjdzmbD+S0KeqYqwX0FrSbMt8PnyJ2+pME9 uev8Z6WQ6NrTqrw9bLsCvZVYijMSDbWYi4oTAROTZA2EAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170403062120eucas1p1369bcd47ca09d99c955baa551cdb1e06 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?utf-8?q?Marek_Szyprowski=1BSRPOL-Kernel_=28TP=29=1B?= =?utf-8?b?7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?utf-8?q?Marek_Szyprowski=1BSRPOL-Kernel_=28TP=29=1BSam?= =?utf-8?q?sung_Electronics=1BSenior_Software_Engineer?= X-Sender-Code: =?utf-8?q?C10=1BEHQ=1BC10CD02CD027392?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170403062120eucas1p1369bcd47ca09d99c955baa551cdb1e06 X-RootMTR: 20170403062120eucas1p1369bcd47ca09d99c955baa551cdb1e06 References: <1491200468-28463-1-git-send-email-m.szyprowski@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Spinlock taken only for dma_map_single() for TX buffer is completely useless and doesn't protect anything, so remove it to simplify the code. Signed-off-by: Marek Szyprowski --- drivers/tty/serial/samsung.c | 4 ---- 1 file changed, 4 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c index ca0bcd7fd61f..8aca18c4cdea 100644 --- a/drivers/tty/serial/samsung.c +++ b/drivers/tty/serial/samsung.c @@ -906,13 +906,9 @@ static int s3c24xx_serial_request_dma(struct s3c24xx_uart_port *p) goto err_free_rx; } - spin_lock_irqsave(&p->port.lock, flags); - /* TX buffer */ dma->tx_addr = dma_map_single(p->port.dev, p->port.state->xmit.buf, UART_XMIT_SIZE, DMA_TO_DEVICE); - - spin_unlock_irqrestore(&p->port.lock, flags); if (dma_mapping_error(p->port.dev, dma->tx_addr)) { ret = -EIO; goto err_unmap_rx;