From patchwork Mon Jan 9 12:03:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 90420 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp46637qgi; Mon, 9 Jan 2017 04:05:27 -0800 (PST) X-Received: by 10.84.134.169 with SMTP id 38mr35146720plh.67.1483963527896; Mon, 09 Jan 2017 04:05:27 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p26si2323813pgd.208.2017.01.09.04.05.27; Mon, 09 Jan 2017 04:05:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-samsung-soc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-samsung-soc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-samsung-soc-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752245AbdAIMF0 (ORCPT + 4 others); Mon, 9 Jan 2017 07:05:26 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:19661 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751112AbdAIMEQ (ORCPT ); Mon, 9 Jan 2017 07:04:16 -0500 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OJI00HXNHJ1DR30@mailout1.w1.samsung.com> for linux-samsung-soc@vger.kernel.org; Mon, 09 Jan 2017 12:04:13 +0000 (GMT) Received: from eusmges2.samsung.com (unknown [203.254.199.241]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20170109120412eucas1p2415136179844feade56643298be4dd64~YGOXb2qDb1167011670eucas1p2V; Mon, 9 Jan 2017 12:04:12 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2.samsung.com (EUCPMTA) with SMTP id F3.0C.30614.C3C73785; Mon, 9 Jan 2017 12:04:12 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20170109120411eucas1p1fddd9c346093e918337dedf9a9a7739e~YGOWv6ZjO2749027490eucas1p1x; Mon, 9 Jan 2017 12:04:11 +0000 (GMT) X-AuditID: cbfec7f1-f793f6d000007796-67-58737c3c87f6 Received: from eusync3.samsung.com ( [203.254.199.213]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 5B.FC.10233.33C73785; Mon, 9 Jan 2017 12:04:03 +0000 (GMT) Received: from AMDC2765.digital.local ([106.116.147.25]) by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OJI00KQMHIPLS60@eusync3.samsung.com>; Mon, 09 Jan 2017 12:04:11 +0000 (GMT) From: Marek Szyprowski To: iommu@lists.linux-foundation.org, linux-samsung-soc@vger.kernel.org Cc: Marek Szyprowski , Joerg Roedel , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz Subject: [PATCH v2 1/4] iommu/exynos: Improve page fault debug message Date: Mon, 09 Jan 2017 13:03:53 +0100 Message-id: <1483963436-29803-2-git-send-email-m.szyprowski@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1483963436-29803-1-git-send-email-m.szyprowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrIIsWRmVeSWpSXmKPExsWy7djP87o2NcURBtM6pS02zljParFgv7VF 5+wN7BbnzwOJGef3MVmsPXKX3YHN48nBeUwem1Z1snlMvrGc0aNvyypGj8+b5AJYo7hsUlJz MstSi/TtErgyti3cwVbwmLviY9Mf9gbGX5xdjJwcEgImEh+OzGWEsMUkLtxbzwZiCwksZZSY +4Cji5ELyP7MKLFy2g12mIY5t1azQySWMUocer2XDcJpYJL4dWoDC0gVm4ChRNfbLrBRIgLu Etf/PGcBKWIW2MAocXxPEzNIQljATWLF4bdAuzk4WARUJSZO0QAJ8wp4SLyf9pUZYpucxMlj k1lBbE4BT4n7P38wQcTfs0l83RcN0iohICux6QBUuYvEkvUTWCFsYYlXx7dAHS0jcXlyNwuE 3c8o0dSqDWHPYJQ495YXwraWOHz8IlgvswCfxKRt05khxvNKdLQJQZR4SLSfOgENLEeJJa8u MUG8PodR4sWBZUwTGGUWMDKsYhRJLS3OTU8tNtIrTswtLs1L10vOz93ECIzY0/+Of9zB+P6E 1SFGAQ5GJR7eCV5FEUKsiWXFlbmHGCU4mJVEeBdWFEcI8aYkVlalFuXHF5XmpBYfYpTmYFES 592z4Eq4kEB6YklqdmpqQWoRTJaJg1OqgbFjbsFT9eP/u0U+txsaCq7M2qcw49+RPgG+h1HZ UxQuzavJqJju+0D6l7pwYUrBxLVhfH4JRyI7X8pHfE3pfu45Xdz0pANPq/7W2t0mC/Y15t9b KrHI6m7KztufljB76K9/k5GY9/O5rZffvV/T+P038v4KYms79dHwcCP/9V07o321Zryaw6fE UpyRaKjFXFScCADfVfr81AIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMLMWRmVeSWpSXmKPExsVy+t/xq7rGNcURBl0LjS02zljParFgv7VF 5+wN7BbnzwOJGef3MVmsPXKX3YHN48nBeUwem1Z1snlMvrGc0aNvyypGj8+b5AJYo9xsMlIT U1KLFFLzkvNTMvPSbZVCQ9x0LZQU8hJzU22VInR9Q4KUFMoSc0qBPCMDNODgHOAerKRvl+CW sW3hDraCx9wVH5v+sDcw/uLsYuTkkBAwkZhzazU7hC0mceHeerYuRi4OIYEljBL7Dp9ngnCa mCSedX9hA6liEzCU6HrbBWaLCLhLXP/znAWkiFlgA6PEuhkTmEESwgJuEisOv2XsYuTgYBFQ lZg4RQMkzCvgIfF+2ldmiG1yEiePTWYFsTkFPCXu//zBBGILAdUcXfGTfQIj7wJGhlWMIqml xbnpucVGesWJucWleel6yfm5mxiBAbzt2M8tOxi73gUfYhTgYFTi4Z3gVRQhxJpYVlyZe4hR goNZSYR3YUVxhBBvSmJlVWpRfnxRaU5q8SFGU6CbJjJLiSbnA6MrryTe0MTQ3NLQyNjCwtzI SEmcd+qHK+FCAumJJanZqakFqUUwfUwcnFINjMrZVWc2Cm3bmmX7/tqErRkFnf++PEzRWHBj /fbjf/tqTfat+GF6duVntlz9yqu7j8hlu7+3X3vtttmDtR4FUWwO/218mYS2bnubJZdg9qu5 eu20C+u9w49OuXQv70Oj4n2thc/n1a64Yb2q0FYofN+3m0v3ZH1a+IHD/ULNj6yov7x1BkZb A+4rsRRnJBpqMRcVJwIAjAn+snYCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170109120411eucas1p1fddd9c346093e918337dedf9a9a7739e X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRs=?= =?UTF-8?B?7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRtT?= =?UTF-8?B?YW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170109120411eucas1p1fddd9c346093e918337dedf9a9a7739e X-RootMTR: 20170109120411eucas1p1fddd9c346093e918337dedf9a9a7739e References: <1483963436-29803-1-git-send-email-m.szyprowski@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Add master device name to default IOMMU fault message to make easier to find which device triggered the fault. While at it, move printing some information (like page table base and first level entry addresses) to dev_dbg(), because those are typically not very useful for typical device driver user/developer not equipped with hardware debugging tools. Signed-off-by: Marek Szyprowski --- drivers/iommu/exynos-iommu.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index b79e4c452b8b..058ee8425f35 100644 --- a/drivers/iommu/exynos-iommu.c +++ b/drivers/iommu/exynos-iommu.c @@ -381,13 +381,14 @@ static void show_fault_information(struct sysmmu_drvdata *data, { sysmmu_pte_t *ent; - dev_err(data->sysmmu, "%s FAULT occurred at %#x (page table base: %pa)\n", - finfo->name, fault_addr, &data->pgtable); + dev_err(data->sysmmu, "%s: %s FAULT occurred at %#x\n", + dev_name(data->master), finfo->name, fault_addr); + dev_dbg(data->sysmmu, "Page table base: %pa\n", &data->pgtable); ent = section_entry(phys_to_virt(data->pgtable), fault_addr); - dev_err(data->sysmmu, "\tLv1 entry: %#x\n", *ent); + dev_dbg(data->sysmmu, "\tLv1 entry: %#x\n", *ent); if (lv1ent_page(ent)) { ent = page_entry(ent, fault_addr); - dev_err(data->sysmmu, "\t Lv2 entry: %#x\n", *ent); + dev_dbg(data->sysmmu, "\t Lv2 entry: %#x\n", *ent); } }