From patchwork Mon May 26 15:53:45 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Santosh Shukla X-Patchwork-Id: 30933 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pb0-f70.google.com (mail-pb0-f70.google.com [209.85.160.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 9052120A25 for ; Mon, 26 May 2014 15:54:55 +0000 (UTC) Received: by mail-pb0-f70.google.com with SMTP id rq2sf37929327pbb.9 for ; Mon, 26 May 2014 08:54:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=KeziZBQZFy70uMzKDA1qSc8Ikl5AP3Ey1mfovrAQkeg=; b=SFHoSBvQ0ZY97heRUL5QzUkXQqRiarM9lPnPxbLtIAib0vg0jnJJoIFyZBHBf6hhAp 66c+dPdZu0d3E6Kxm1/aSdH/4CMEBkBEwfU0xlao2d5StD0HvS7854E/JqWxezHS8n3N r3kPHcfC3h1+7GxlBEJkRJTQlk3K28RhdSg/VKNPfgjEC6oGsrq3z0L3FlAWGbdMZdmP L6ghpSCCw+Yjy6RkxVubXHBw+DBlt1LR/ljMVFwDh206M8dNsxGZIQryUJq1OjWYDTT5 N7qin92nrb22V9fkhYIMX4Q5N8rPcyzSzBKvnDgm1E0Ggla6cMzriLkEQL1l47UUKtAs +NYQ== X-Gm-Message-State: ALoCoQnJF7qgowyxyiHTM+5B+EHIKgMQLpDfSJBxXXPQwwNkkPU4tLW80i7r8kywClGz1p9Q2Fmh X-Received: by 10.66.156.2 with SMTP id wa2mr11108203pab.0.1401119694849; Mon, 26 May 2014 08:54:54 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.22.145 with SMTP id 17ls2798997qgn.21.gmail; Mon, 26 May 2014 08:54:54 -0700 (PDT) X-Received: by 10.220.47.201 with SMTP id o9mr1066476vcf.65.1401119694661; Mon, 26 May 2014 08:54:54 -0700 (PDT) Received: from mail-vc0-f172.google.com (mail-vc0-f172.google.com [209.85.220.172]) by mx.google.com with ESMTPS id g2si6461692vdq.62.2014.05.26.08.54.54 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 26 May 2014 08:54:54 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.172 as permitted sender) client-ip=209.85.220.172; Received: by mail-vc0-f172.google.com with SMTP id ik5so5994954vcb.31 for ; Mon, 26 May 2014 08:54:54 -0700 (PDT) X-Received: by 10.220.44.141 with SMTP id a13mr824146vcf.71.1401119694585; Mon, 26 May 2014 08:54:54 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp53934vcb; Mon, 26 May 2014 08:54:54 -0700 (PDT) X-Received: by 10.68.191.39 with SMTP id gv7mr29292729pbc.90.1401119693855; Mon, 26 May 2014 08:54:53 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id py7si15056956pbb.251.2014.05.26.08.54.53; Mon, 26 May 2014 08:54:53 -0700 (PDT) Received-SPF: none (google.com: linux-samsung-soc-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752553AbaEZPyu (ORCPT + 9 others); Mon, 26 May 2014 11:54:50 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:47477 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752477AbaEZPyt (ORCPT ); Mon, 26 May 2014 11:54:49 -0400 Received: by mail-pa0-f49.google.com with SMTP id lj1so7746004pab.22 for ; Mon, 26 May 2014 08:54:49 -0700 (PDT) X-Received: by 10.66.149.37 with SMTP id tx5mr28575236pab.81.1401119689087; Mon, 26 May 2014 08:54:49 -0700 (PDT) Received: from santosh-Latitude-E5530-non-vPro.mvista.com ([111.93.218.67]) by mx.google.com with ESMTPSA id qv3sm18883270pbb.87.2014.05.26.08.54.44 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 26 May 2014 08:54:48 -0700 (PDT) From: Santosh Shukla To: kgene.kim@samsung.com, arnd@arndb.de, linux@arm.linux.org.uk, catalin.marinas@arm.com Cc: thomas.abraham@linaro.org, t.figa@samsung.com, linux-samsung-soc@vger.kernel.org, linaro-kernel@lists.linaro.org, viresh.kumar@linaro.org, linux-arm-kernel@lists.infradead.org, santosh shukla Subject: [PATCH] ARM: Exynos : Fix build error with thumb2 Date: Mon, 26 May 2014 21:23:45 +0530 Message-Id: <1401119625-11309-1-git-send-email-santosh.shukla@linaro.org> X-Mailer: git-send-email 1.7.9.5 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: santosh.shukla@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.172 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: santosh shukla Add non-global symbol .LLl2x0_regs_phys to avoid build break in thumb2 mode. IIUC, arm assembler fail to load value of "global" variable l2xo_regs_phys for thum2 mode and wrapping it in non-global symbol like .Ll2x0_regs_phys solves the build break issue. arch/arm/mach-exynos/sleep.S: Assembler messages: arch/arm/mach-exynos/sleep.S:57: Error: invalid immediate for address calculation (value = 0x00000004) fix inspired from [1] [1] https://lkml.org/lkml/2010/3/31/235 Signed-off-by: santosh shukla Reviewed-by: Dave Martin --- arch/arm/mach-exynos/sleep.S | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-exynos/sleep.S b/arch/arm/mach-exynos/sleep.S index a2613e9..dc8c6b6 100644 --- a/arch/arm/mach-exynos/sleep.S +++ b/arch/arm/mach-exynos/sleep.S @@ -54,7 +54,7 @@ ENTRY(exynos_cpu_resume) ldr r1, =CPU_CORTEX_A9 cmp r0, r1 bne skip_l2_resume - adr r0, l2x0_regs_phys + adr r0, .Ll2x0_regs_phys ldr r0, [r0] cmp r0, #0 beq skip_l2_resume @@ -79,6 +79,8 @@ skip_l2_resume: b cpu_resume ENDPROC(exynos_cpu_resume) #ifdef CONFIG_CACHE_L2X0 + +.Ll2x0_regs_phys: .globl l2x0_regs_phys l2x0_regs_phys: .long 0