From patchwork Thu May 22 07:57:35 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leela Krishna Amudala X-Patchwork-Id: 30570 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ie0-f198.google.com (mail-ie0-f198.google.com [209.85.223.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id ECE1120671 for ; Thu, 22 May 2014 07:56:48 +0000 (UTC) Received: by mail-ie0-f198.google.com with SMTP id tp5sf14480141ieb.5 for ; Thu, 22 May 2014 00:56:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=kuEBBWTtzOe5C6CmX7uVp1alPV6jZMeN7CIVdmWF7Lw=; b=DNGpWuljZEuxRvLAHhcx9K/DAZtfpm/1cnZCgqCUTAGdxOV4KTqRnVaf2PX1kBMQLJ NFng1n2Ny5Jzk6+4AqQuU6Cs7DMsitftpRQyJ6x8T03vq9xHP5I/1UCqe7iHPHpx1K8n EVBpD/1806E1CSGvzlRYWdlw8JWPQ4Ri0pzcqSFZQDnLkJcbwawz4/kOMRIwO7GwgbRp ul0vWkdWXM+M/JDwJQHOqtCnvpDk6k6T1+TY5MinU/+hz97tiXgUed8agQfMPwK2f3w0 XL/JNi6n2EzItqime7VansjJ3AHDMMDA/rBNae4IjQJPQbtj4M8ORa4+YpqIk2UwPefQ pLmQ== X-Gm-Message-State: ALoCoQkjDFEL5w2+oLDCgO04C+ORFqmt19DU/6RZG0bILygvu0KsMFF1LAoj1BFVGfMu0sS2miE6 X-Received: by 10.50.115.104 with SMTP id jn8mr720862igb.1.1400745408466; Thu, 22 May 2014 00:56:48 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.91.201 with SMTP id z67ls463270qgd.94.gmail; Thu, 22 May 2014 00:56:48 -0700 (PDT) X-Received: by 10.221.7.71 with SMTP id on7mr14553968vcb.18.1400745408338; Thu, 22 May 2014 00:56:48 -0700 (PDT) Received: from mail-vc0-f173.google.com (mail-vc0-f173.google.com [209.85.220.173]) by mx.google.com with ESMTPS id vr7si4414815vcb.93.2014.05.22.00.56.48 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 22 May 2014 00:56:48 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.173 as permitted sender) client-ip=209.85.220.173; Received: by mail-vc0-f173.google.com with SMTP id il7so3957371vcb.18 for ; Thu, 22 May 2014 00:56:48 -0700 (PDT) X-Received: by 10.58.126.135 with SMTP id my7mr35563840veb.27.1400745408234; Thu, 22 May 2014 00:56:48 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp177022vcb; Thu, 22 May 2014 00:56:47 -0700 (PDT) X-Received: by 10.68.221.42 with SMTP id qb10mr65574270pbc.65.1400745407518; Thu, 22 May 2014 00:56:47 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ae4si9501013pbc.257.2014.05.22.00.56.46; Thu, 22 May 2014 00:56:46 -0700 (PDT) Received-SPF: none (google.com: linux-samsung-soc-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752354AbaEVH4p (ORCPT + 9 others); Thu, 22 May 2014 03:56:45 -0400 Received: from mail-pd0-f181.google.com ([209.85.192.181]:39886 "EHLO mail-pd0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751531AbaEVH4p (ORCPT ); Thu, 22 May 2014 03:56:45 -0400 Received: by mail-pd0-f181.google.com with SMTP id z10so2204769pdj.26 for ; Thu, 22 May 2014 00:56:44 -0700 (PDT) X-Received: by 10.68.166.36 with SMTP id zd4mr65654596pbb.54.1400745404865; Thu, 22 May 2014 00:56:44 -0700 (PDT) Received: from lk-linux.sisodomain.com ([14.140.216.146]) by mx.google.com with ESMTPSA id ja8sm11668857pbd.3.2014.05.22.00.56.41 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 22 May 2014 00:56:43 -0700 (PDT) From: Leela Krishna Amudala To: linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: daniel.lezcano@linaro.org, kgene.kim@samsung.com, amit.kucheria@linaro.org Subject: [PATCH] ARM: EXYNOS: Use wfi macro in platform_do_lowpower Date: Thu, 22 May 2014 13:27:35 +0530 Message-Id: <1400745455-27920-1-git-send-email-leela.krishna@linaro.org> X-Mailer: git-send-email 1.7.9.5 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: leela.krishna@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.173 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , This patch is originally based on commit b3377d186572 ("ARM: 7064/1: vexpress: Use wfi macro in platform_do_lowpower.") Current Exynos CPU hotplug code includes a hardcoded WFI instruction, in ARM encoding. When the kernel is compiled in Thumb-2 mode, this is invalid and causes the machine to hang hard when a CPU is offlined. Use wfi macro instead of the hardcoded WFI instruction. Signed-off-by: Leela Krishna Amudala Acked-by: Daniel Lezcano --- arch/arm/mach-exynos/hotplug.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/arch/arm/mach-exynos/hotplug.c b/arch/arm/mach-exynos/hotplug.c index 69fa483..8a134d0 100644 --- a/arch/arm/mach-exynos/hotplug.c +++ b/arch/arm/mach-exynos/hotplug.c @@ -46,13 +46,7 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious) if (cpu == 1) exynos_cpu_power_down(cpu); - /* - * here's the WFI - */ - asm(".word 0xe320f003\n" - : - : - : "memory", "cc"); + wfi(); if (pen_release == cpu_logical_map(cpu)) { /*