From patchwork Fri Sep 7 06:44:47 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Inderpal Singh X-Patchwork-Id: 11220 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 42FFE23F25 for ; Fri, 7 Sep 2012 06:44:55 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id ED310A18D24 for ; Fri, 7 Sep 2012 06:44:54 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id k11so4187681iea.11 for ; Thu, 06 Sep 2012 23:44:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=8K8QlSWdFaY1B5wq4FTT1OSp/k6D54dzGjljYFslz/A=; b=faB5LX2kMSkWpD/CR4GxgkpKOHV9x67NO9rLxkSDhesO/p/wyUotoy0c2STrJ17K2O ovElLSsJb2F4POROhCxoTDA3vhca2N6GGPKIbTgLLlY0fJLs5iY+RpHgMXYdfkzqcvyn ZJEyt/8HLkWZ5/MYuBUVeUikMKQ6yK/iRyMJdrMS1xhx+SpTcBujnFXcM8TH3EEidivH 2ncVFZfEMUi1XckbW7r7eNdswhIk9yczr89gzawaZFg7QbJX5DTc6jG8LR9db6yrawyM XesPlvTrpA/J+s/SMsAwM43YI0Cep8aThqWoHbghrvUAqAaF7UyoNPayv07mylwG9mE8 A77g== Received: by 10.50.191.227 with SMTP id hb3mr16488470igc.43.1347000294657; Thu, 06 Sep 2012 23:44:54 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp363074igc; Thu, 6 Sep 2012 23:44:54 -0700 (PDT) Received: by 10.66.75.105 with SMTP id b9mr7230895paw.58.1347000293653; Thu, 06 Sep 2012 23:44:53 -0700 (PDT) Received: from mail-pb0-f50.google.com (mail-pb0-f50.google.com [209.85.160.50]) by mx.google.com with ESMTPS id pb4si7416412pbc.270.2012.09.06.23.44.53 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 06 Sep 2012 23:44:53 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of inderpal.singh@linaro.org) client-ip=209.85.160.50; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of inderpal.singh@linaro.org) smtp.mail=inderpal.singh@linaro.org Received: by pbcmd12 with SMTP id md12so3943686pbc.37 for ; Thu, 06 Sep 2012 23:44:53 -0700 (PDT) Received: by 10.68.221.72 with SMTP id qc8mr8803204pbc.63.1347000293317; Thu, 06 Sep 2012 23:44:53 -0700 (PDT) Received: from inder-ubuntu.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPS id vd4sm2624472pbc.41.2012.09.06.23.44.49 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 06 Sep 2012 23:44:52 -0700 (PDT) From: Inderpal Singh To: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kgene.kim@samsung.com, vinod.koul@intel.com, patches@linaro.org, boojin.kim@samsung.com, jassisinghbrar@gmail.com, Inderpal Singh Subject: [PATCH 1/2] DMA: PL330: Remove controller clock enable/disable Date: Fri, 7 Sep 2012 12:14:47 +0530 Message-Id: <1347000288-20441-2-git-send-email-inderpal.singh@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1347000288-20441-1-git-send-email-inderpal.singh@linaro.org> References: <1347000288-20441-1-git-send-email-inderpal.singh@linaro.org> X-Gm-Message-State: ALoCoQmAdXRPJUud7WFPDhCBVZV1Qjdlp47U1Wx0EGYray8P0OT6ms5/w4RVKfHKhycUn81OkFS1 The controller clock is being enabled/disabled in AMBA bus infrastructre in probe/remove functions. Hence, its not required at driver level probe/remove. Signed-off-by: Inderpal Singh --- drivers/dma/pl330.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index e4feba6..f70e783 100644 --- a/drivers/dma/pl330.c +++ b/drivers/dma/pl330.c @@ -2896,11 +2896,6 @@ pl330_probe(struct amba_device *adev, const struct amba_id *id) amba_set_drvdata(adev, pdmac); -#ifndef CONFIG_PM_RUNTIME - /* enable dma clk */ - clk_enable(pdmac->clk); -#endif - irq = adev->irq[0]; ret = request_irq(irq, pl330_irq_handler, 0, dev_name(&adev->dev), pi); @@ -2987,9 +2982,6 @@ probe_err5: probe_err4: free_irq(irq, pi); probe_err3: -#ifndef CONFIG_PM_RUNTIME - clk_disable(pdmac->clk); -#endif clk_put(pdmac->clk); probe_err2: iounmap(pi->base); @@ -3037,10 +3029,6 @@ static int __devexit pl330_remove(struct amba_device *adev) res = &adev->res; release_mem_region(res->start, resource_size(res)); -#ifndef CONFIG_PM_RUNTIME - clk_disable(pdmac->clk); -#endif - kfree(pdmac); return 0;