From patchwork Wed Aug 8 10:25:17 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kukjin Kim X-Patchwork-Id: 10574 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id B890E23E53 for ; Wed, 8 Aug 2012 10:25:20 +0000 (UTC) Received: from mail-gg0-f180.google.com (mail-gg0-f180.google.com [209.85.161.180]) by fiordland.canonical.com (Postfix) with ESMTP id 4EDF8A184CC for ; Wed, 8 Aug 2012 10:25:20 +0000 (UTC) Received: by ggnf1 with SMTP id f1so562828ggn.11 for ; Wed, 08 Aug 2012 03:25:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-type:content-transfer-encoding:x-mailer :thread-index:content-language:x-brightmail-tracker:x-tm-as-mml :x-gm-message-state; bh=M18V7my+nLa02zfZ4iQ6/BlPhKVMGsxOi+kTWrpLMWM=; b=lkWEdJW0TUJwtTzd7zAzItYVt18rUU9AIGNgHel3LweFG7il8+lJhu8XsK0l6UK6mM RFj6Eq/vDU6BF1xQPnvqhQH0njX0f1ZHb9iA9453+Sv/jtNdUoIO8Noi7u7SzdbAMQG4 b5mEl6Gn5AKddVR5KGMqTYoVW5BpjJtidrOtwuc5g57gqqw0enQdfug0ir3sjPDjH6Fb Bo9NU3+5/GXsa+9loddzcJ0Rh4kF5TBsPu8DTctQmkaBgbBbSi/pA0AGxC+Z+VPaoOYT aFjQr2Ir7iU+ZmbNPoli8iwXAFybFxtDosTySEGz8SA5FPe6djWNFc+bq6R/mb10wI8x iK9Q== Received: by 10.50.181.136 with SMTP id dw8mr374687igc.31.1344421519615; Wed, 08 Aug 2012 03:25:19 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.200 with SMTP id ew8csp599514igc; Wed, 8 Aug 2012 03:25:19 -0700 (PDT) Received: by 10.66.75.228 with SMTP id f4mr51560paw.52.1344421518767; Wed, 08 Aug 2012 03:25:18 -0700 (PDT) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by mx.google.com with ESMTP id os5si22096041pbb.56.2012.08.08.03.25.18; Wed, 08 Aug 2012 03:25:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of kgene.kim@samsung.com designates 203.254.224.34 as permitted sender) client-ip=203.254.224.34; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of kgene.kim@samsung.com designates 203.254.224.34 as permitted sender) smtp.mail=kgene.kim@samsung.com Received: from epcpsbgm2.samsung.com (mailout4.samsung.com [203.254.224.34]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0M8F003KRMA58Q20@mailout4.samsung.com>; Wed, 08 Aug 2012 19:25:17 +0900 (KST) X-AuditID: cbfee61b-b7f566d000005c8a-e5-50223e8d7cf3 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id AD.75.23690.D8E32205; Wed, 08 Aug 2012 19:25:17 +0900 (KST) Received: from DOKGENEKIM03 ([12.23.119.152]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0M8F003ATMA5KP70@mmp1.samsung.com>; Wed, 08 Aug 2012 19:25:17 +0900 (KST) From: Kukjin Kim To: 'Thierry Reding' Cc: 'Tushar Behera' , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, s.hauer@pengutronix.de, patches@linaro.org, 'Jingoo Han' References: <1344333546-16995-1-git-send-email-tushar.behera@linaro.org> <098f01cd7488$0d66d630$28348290$%kim@samsung.com> <5020F568.5020204@linaro.org> <0a2d01cd7500$53e26c50$fba744f0$%kim@samsung.com> <20120808061102.GA22417@avionic-0098.mockup.avionic-design.de> <0abe01cd752f$4f96ad80$eec40880$%kim@samsung.com> <20120808065046.GA30832@avionic-0098.mockup.avionic-design.de> In-reply-to: <20120808065046.GA30832@avionic-0098.mockup.avionic-design.de> Subject: RE: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig Date: Wed, 08 Aug 2012 19:25:17 +0900 Message-id: <0af001cd7550$1af66040$50e320c0$%kim@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac11MiaZdi3s362VSqSYklyLRdwjMAAG9irA Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrILMWRmVeSWpSXmKPExsVy+t9jAd1eO6UAg4+v5C2mHP7CYtH+dy+b A5PHnWt72AIYo7hsUlJzMstSi/TtErgy9ux+wFSwSLSip/c/SwPjQYEuRk4OCQETiR3/LzBB 2GISF+6tZ+ti5OIQEljEKLHt11d2kISQwF9GidWvVEBsNgENicPvn4HFRQTMJZYs2ssM0sAs cJhR4sbUKUwQDW3MEp8+K4LYnALeEk+vLQJq4OAQFvCXeNRZABJmEVCV+N+ylwkkzCtgK/F6 ug1ImFdAUOLH5HssIDazgJbE+p3HmSBseYnNa94yg5RLCKhLPPqrC3GBkcTGjROYIUpEJPa9 eMc4gVFoFpJJs5BMmoVk0iwkLQsYWVYxiqYWJBcUJ6XnGukVJ+YWl+al6yXn525iBAf0M+kd jKsaLA4xCnAwKvHwbkpVDBBiTSwrrsw9xCjBwawkwrvnIFCINyWxsiq1KD++qDQntfgQozQH i5I4r4n3V38hgfTEktTs1NSC1CKYLBMHp1QDY0TYjLm6bxmbt+jtN03/HfLw96Wth+uVbifm JHIoT+7vTKyclzdvW/DexiWrGkJ+rN2gdPSC5+PdyeY/An5fvqNq7X4k46BLzpL8h/On7Fp9 K1TrQ4fu9O2308r2KGk9dhL1KVnzPLjEyHb/k/B3nFlVO9e7yXO8fL3sWG65b4LGivtzGu86 siixFGckGmoxFxUnAgCe2duFZAIAAA== X-TM-AS-MML: No X-Gm-Message-State: ALoCoQlKD2XwjJz9dzwyB2UQz9uKaItOBZgKO6h+/E08AtjvP/UQbQloFKjGgPKACD9zmP8XqLVm Thierry Reding wrote: > > On Wed, Aug 08, 2012 at 03:30:32PM +0900, Kukjin Kim wrote: [...] > > Yeah, your pointing out is correct, but in this case, it should be > 'bool' > > not 'tristate' because the PWM driver cannot support module now. > > Is there any reason why that is so? I mean, current pwm-samsung.c does not support module, as you know, the pwm_init() of pwm-samsung is called by arch_initcall(). > Looking at the driver it seems like > it should be easy to turn it into a module. Yeah, I know :) > I know that Jingoo (Cc'ed) > has been working on the driver and I've asked him the same question > already. > I didn't know, would be helpful to me if you could add me in Cc for discussion of pwm-samsung. And he is my team member, so I will talk to him about the plan. > Anyway I don't want to force the issue, I just think you should consider > it. > Thanks. > > > solve this problem would be to add a default line, like so: > > > > > > default PLAT_SAMSUNG > > > > > > I've checked this with a s3c2410_defconfig and this causes PWM_SAMSUNG > > > to be selected =y, which I guess is what you want. > > > > > How do you think following, just adding from original one? > > > > - tristate "Samsung pwm support" > > + bool "SAMSUNG PWM support" > > > > Thanks. > > If you convert this to bool anyway, then maybe you can still use > def_bool: > > config PWM_SAMSUNG > prompt "SAMSUNG PWM support" if PLAT_SAMSUNG > def_bool PLAT_SAMSUNG > > Any particular reason why you want "SAMSUNG" capitalized? > No, there is no reason, just because... So, how about following? If PWM is selected on Samsung SoCs, the PWM_SAMSUNG will be selected automatically. Of course, it can be de-selected in kernel menuconfig. Note that, I think, using 'bool ' and 'depends on ' is more clear than 'prompt ["if" ]'. However if any your preference here, please kindly let me know. Acked-by: Thierry Reding --- --- Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig index 8fc3808..c74d055 100644 --- a/drivers/pwm/Kconfig +++ b/drivers/pwm/Kconfig @@ -58,14 +58,12 @@ config PWM_PXA will be called pwm-pxa. config PWM_SAMSUNG - tristate "Samsung pwm support" + bool "Samsung PWM support" depends on PLAT_SAMSUNG + default y help Generic PWM framework driver for Samsung. - To compile this driver as a module, choose M here: the module - will be called pwm-samsung. - config PWM_TEGRA tristate "NVIDIA Tegra PWM support" depends on ARCH_TEGRA