From patchwork Wed Aug 8 00:54:13 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kukjin Kim X-Patchwork-Id: 10571 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 18C0023E57 for ; Wed, 8 Aug 2012 00:54:17 +0000 (UTC) Received: from mail-gg0-f180.google.com (mail-gg0-f180.google.com [209.85.161.180]) by fiordland.canonical.com (Postfix) with ESMTP id C056AA1830C for ; Wed, 8 Aug 2012 00:54:16 +0000 (UTC) Received: by ggnf1 with SMTP id f1so235591ggn.11 for ; Tue, 07 Aug 2012 17:54:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-type:content-transfer-encoding:x-mailer :thread-index:content-language:x-brightmail-tracker:x-tm-as-mml :x-gm-message-state; bh=Bw2O5hcN1z8/LUQocoum7o90JPgzozKaBe+6JD0K2N0=; b=YKHbs6ncH+YrMnR/5wYRHS6jxOdAk0ZWwxP4Ud9Dhcl714A2WM3JUA36Sywo6QlG0r SoA/xSqkZsoRz21/CjuUmMfhh6KSBOiXyg63byYgPiv+sq7271oIqWdUGY686zAZCRzY 4nrribB7UVYKcJotMjyY5yFklof96C61JUGPR7Gq1yXl75ZsmG26n3rdb3pCiIN2Tqx2 vwo0jdIB+8pkQGGglHz1qHIHti30TZk3BuXEs8JQDLwwJvXLwvY44pwEV6MWSL5cEjEJ 8uDk2IR6zUQKJYDdHrs72sgjXKRez6vNpsPlHD0zZOWeo8WrKt7aFj1WDlk3lRX1w7f8 g9Ag== Received: by 10.50.159.135 with SMTP id xc7mr348249igb.9.1344387255919; Tue, 07 Aug 2012 17:54:15 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.200 with SMTP id ew8csp582039igc; Tue, 7 Aug 2012 17:54:15 -0700 (PDT) Received: by 10.68.230.194 with SMTP id ta2mr6538904pbc.30.1344387254979; Tue, 07 Aug 2012 17:54:14 -0700 (PDT) Received: from mailout3.samsung.com (mailout3.samsung.com. [203.254.224.33]) by mx.google.com with ESMTP id vx2si19441065pbc.21.2012.08.07.17.54.14; Tue, 07 Aug 2012 17:54:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of kgene.kim@samsung.com designates 203.254.224.33 as permitted sender) client-ip=203.254.224.33; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of kgene.kim@samsung.com designates 203.254.224.33 as permitted sender) smtp.mail=kgene.kim@samsung.com Received: from epcpsbgm2.samsung.com (mailout3.samsung.com [203.254.224.33]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0M8E009T3VTIXG90@mailout3.samsung.com>; Wed, 08 Aug 2012 09:54:13 +0900 (KST) X-AuditID: cbfee61b-b7f566d000005c8a-b4-5021b8b5652c Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id B8.C8.23690.5B8B1205; Wed, 08 Aug 2012 09:54:13 +0900 (KST) Received: from DOKGENEKIM03 ([12.23.119.152]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0M8E001FZVUDHB30@mmp1.samsung.com>; Wed, 08 Aug 2012 09:54:13 +0900 (KST) From: Kukjin Kim To: 'Tushar Behera' , thierry.reding@avionic-design.de Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, s.hauer@pengutronix.de, patches@linaro.org References: <1344333546-16995-1-git-send-email-tushar.behera@linaro.org> <098f01cd7488$0d66d630$28348290$%kim@samsung.com> <5020F568.5020204@linaro.org> In-reply-to: <5020F568.5020204@linaro.org> Subject: RE: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig Date: Wed, 08 Aug 2012 09:54:13 +0900 Message-id: <0a2d01cd7500$53e26c50$fba744f0$%kim@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac10i/Ch62t3OukGTm260i7w2w6O+gActU3Q Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrELMWRmVeSWpSXmKPExsVy+t9jAd2tOxQDDC6eE7KYcvgLi0X7371s Dkwed67tYQtgjOKySUnNySxLLdK3S+DK+HC4m6ngoUXF8WV7WBoY1+h1MXJySAiYSMzfMIMd whaTuHBvPVsXIxeHkMAiRol/K1rZIZy/jBKn/r5gBaliE9CQOPz+GViHiECAxLITr8DizAKF EqePTmWEaJjFKNGw8y3QKA4OTgEtiRvffUFMYQF/iUedBSDlLAKqEi9OHARr5RWwleh69IMR whaU+DH5HgvESC2J9TuPM0HY8hKb17xlBhkjIaAu8eivLsQFRhLT3xxnhigRkdj34h3jBEah WUgmzUIyaRaSSbOQtCxgZFnFKJpakFxQnJSea6RXnJhbXJqXrpecn7uJERzSz6R3MK5qsDjE KMDBqMTDuylVMUCINbGsuDL3EKMEB7OSCG9bK1CINyWxsiq1KD++qDQntfgQozQHi5I4r4n3 V38hgfTEktTs1NSC1CKYLBMHp1QD48zVsXEKUzb1lhgtuxtneVI1ZLnmniLLXt/IM9EVz6a8 5bi480LG3I/v/7ZVbna1b55zZ1dtkdq2In4z5ojH2csSjpq3x2Td+/Sn2331reJ5tpsKWS5I JGZ+lZbt97E1csvc/FI/8JFW8CvmffMjp8nbust7LZvTsHVJ2j1dQfbz5RaL9+5QUWIpzkg0 1GIuKk4EANo2GPllAgAA X-TM-AS-MML: No X-Gm-Message-State: ALoCoQlYswAM45K6sb8Nym9Yryo0p4EmkrCf7THAnyna42+ASjUB1RA0kzEXBQhtLe0oPiOJUgpi Tushar Behera wrote: > > On 08/07/2012 04:03 PM, Kukjin Kim wrote: > > Tushar Behera wrote: > >> > >> Commit 2663e766c56a "ARM Samsung: Move s3c pwm driver to pwm framework" > >> moved Samsung PWM driver to drivers/pwm and the config option to select > >> this driver has changed. > >> > >> This patch fixes following build-error with s3c2410_defconfig. > >> arch/arm/mach-s3c24xx/mach-rx1950.c:430: undefined reference to > >> `pwm_config' > >> > > > > Yes, need to fix... > > > > arch/arm/mach-s3c24xx/built-in.o: In function `rx1950_lcd_power': > > arch/arm/mach-s3c24xx/mach-rx1950.c:430: undefined reference to > `pwm_config' > > arch/arm/mach-s3c24xx/mach-rx1950.c:431: undefined reference to > > `pwm_disable' > > arch/arm/mach-s3c24xx/mach-rx1950.c:437: undefined reference to > `pwm_config' > > arch/arm/mach-s3c24xx/mach-rx1950.c:438: undefined reference to > `pwm_enable' > > arch/arm/mach-s3c24xx/built-in.o: In function `rx1950_backlight_exit': > > arch/arm/mach-s3c24xx/mach-rx1950.c:504: undefined reference to > `pwm_free' > > arch/arm/mach-s3c24xx/built-in.o: In function `rx1950_backlight_init': > > arch/arm/mach-s3c24xx/mach-rx1950.c:487: undefined reference to > > `pwm_request' > > > > Yes, the patch fixes all of these errors, didn't include them in the > patch comments though as they were all similar. > I will add above description when I apply this :) > > >> Signed-off-by: Tushar Behera > >> --- > >> arch/arm/mach-s3c24xx/Kconfig | 4 ++-- > >> arch/arm/plat-samsung/Kconfig | 3 ++- > >> 2 files changed, 4 insertions(+), 3 deletions(-) > >> > >> diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach- > s3c24xx/Kconfig > >> index e249611..d56b0f7 100644 > >> --- a/arch/arm/mach-s3c24xx/Kconfig > >> +++ b/arch/arm/mach-s3c24xx/Kconfig > >> @@ -483,7 +483,7 @@ config MACH_NEO1973_GTA02 > >> select I2C > >> select POWER_SUPPLY > >> select MACH_NEO1973 > >> - select S3C2410_PWM > >> + select S3C24XX_PWM > > The above needs to be picked up as S3C2410_PWM is no longer defined. > Correct, I know. In addition, I'd preferred to use SAMSUNG_PWM so I will change the name later. > >> select S3C_DEV_USB_HOST > >> help > >> Say Y here if you are using the Openmoko GTA02 / Freerunner GSM > >> Phone > >> @@ -493,7 +493,7 @@ config MACH_RX1950 > >> select S3C24XX_DCLK > >> select PM_H1940 if PM > >> select I2C > >> - select S3C2410_PWM > >> + select S3C24XX_PWM > > Same as above. > > >> select S3C_DEV_NAND > >> select S3C2410_IOTIMING if S3C2440_CPUFREQ > >> select S3C2440_XTAL_16934400 > >> diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat- > samsung/Kconfig > >> index 7aca31c..9c3b90c 100644 > >> --- a/arch/arm/plat-samsung/Kconfig > >> +++ b/arch/arm/plat-samsung/Kconfig > >> @@ -403,7 +403,8 @@ config S5P_DEV_USB_EHCI > >> > >> config S3C24XX_PWM > >> bool "PWM device support" > >> - select HAVE_PWM > >> + select PWM > >> + select PWM_SAMSUNG > >> help > >> Support for exporting the PWM timer blocks via the pwm device > >> system > >> -- > >> 1.7.4.1 > > > > I think, following would be better? Or ... > > > > No issues. You can pick whichever you find better. > Thanks, see below. > > --- > > diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat- > samsung/Kconfig > > index 7aca31c..dcdfb77 100644 > > --- a/arch/arm/plat-samsung/Kconfig > > +++ b/arch/arm/plat-samsung/Kconfig > > @@ -403,7 +403,7 @@ config S5P_DEV_USB_EHCI > > > > config S3C24XX_PWM > > bool "PWM device support" > > - select HAVE_PWM > > + select PWM > > help > > Support for exporting the PWM timer blocks via the pwm device > > system > > diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig > > index 8fc3808..34c8ec1 100644 > > --- a/drivers/pwm/Kconfig > > +++ b/drivers/pwm/Kconfig > > @@ -59,7 +59,7 @@ config PWM_PXA > > > > config PWM_SAMSUNG > > tristate "Samsung pwm support" > > - depends on PLAT_SAMSUNG > > + def_bool PLAT_SAMSUNG > > help > > Generic PWM framework driver for Samsung. > > --- > > > > From: Tushar Behera Subject: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig Commit 2663e766c56a ("ARM Samsung: Move s3c pwm driver to pwm framework") moved Samsung PWM driver to drivers/pwm and the config option to select this driver has changed. This patch fixes following build-error with s3c2410_defconfig. arch/arm/mach-s3c24xx/built-in.o: In function 'rx1950_lcd_power': arch/arm/mach-s3c24xx/mach-rx1950.c:430: undefined reference to 'pwm_config' arch/arm/mach-s3c24xx/mach-rx1950.c:431: undefined reference to 'pwm_disable' arch/arm/mach-s3c24xx/mach-rx1950.c:437: undefined reference to 'pwm_config' arch/arm/mach-s3c24xx/mach-rx1950.c:438: undefined reference to 'pwm_enable' arch/arm/mach-s3c24xx/built-in.o: In function 'rx1950_backlight_exit': arch/arm/mach-s3c24xx/mach-rx1950.c:504: undefined reference to 'pwm_free' arch/arm/mach-s3c24xx/built-in.o: In function 'rx1950_backlight_init': arch/arm/mach-s3c24xx/mach-rx1950.c:487: undefined reference to 'pwm_request' Signed-off-by: Tushar Behera [kgene.kim@samsung.com: re-worked as per review comments] Cc: Thierry Reding Signed-off-by: Kukjin Kim --- arch/arm/mach-s3c24xx/Kconfig | 4 ++-- arch/arm/plat-samsung/Kconfig | 2 +- drivers/pwm/Kconfig | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig index e249611..d56b0f7 100644 --- a/arch/arm/mach-s3c24xx/Kconfig +++ b/arch/arm/mach-s3c24xx/Kconfig @@ -483,7 +483,7 @@ config MACH_NEO1973_GTA02 select I2C select POWER_SUPPLY select MACH_NEO1973 - select S3C2410_PWM + select S3C24XX_PWM select S3C_DEV_USB_HOST help Say Y here if you are using the Openmoko GTA02 / Freerunner GSM Phone @@ -493,7 +493,7 @@ config MACH_RX1950 select S3C24XX_DCLK select PM_H1940 if PM select I2C - select S3C2410_PWM + select S3C24XX_PWM select S3C_DEV_NAND select S3C2410_IOTIMING if S3C2440_CPUFREQ select S3C2440_XTAL_16934400 diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig index 7aca31c..dcdfb77 100644 --- a/arch/arm/plat-samsung/Kconfig +++ b/arch/arm/plat-samsung/Kconfig @@ -403,7 +403,7 @@ config S5P_DEV_USB_EHCI config S3C24XX_PWM bool "PWM device support" - select HAVE_PWM + select PWM help Support for exporting the PWM timer blocks via the pwm device system diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig index 8fc3808..34c8ec1 100644 --- a/drivers/pwm/Kconfig +++ b/drivers/pwm/Kconfig @@ -59,7 +59,7 @@ config PWM_PXA config PWM_SAMSUNG tristate "Samsung pwm support" - depends on PLAT_SAMSUNG + def_bool PLAT_SAMSUNG help Generic PWM framework driver for Samsung.