From patchwork Tue Aug 7 10:33:15 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kukjin Kim X-Patchwork-Id: 10560 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id E831D23F3F for ; Tue, 7 Aug 2012 10:33:18 +0000 (UTC) Received: from mail-gh0-f180.google.com (mail-gh0-f180.google.com [209.85.160.180]) by fiordland.canonical.com (Postfix) with ESMTP id A0C82A18F4E for ; Tue, 7 Aug 2012 10:33:18 +0000 (UTC) Received: by ghbg10 with SMTP id g10so1739286ghb.11 for ; Tue, 07 Aug 2012 03:33:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-type:content-transfer-encoding:x-mailer :thread-index:content-language:x-brightmail-tracker:x-tm-as-mml :x-gm-message-state; bh=OpN6qMQrhTa6++ZHPeALcn3JR9xPBe+1/r9txGz3BZ0=; b=Td5dn6bDyqYHcVFySSNqB8MPlMirAInuLnRi/whs6oHQSYex0SLF9J5ynDKCbBDBWd 4Q+oohKSgeZbMJE6joOb+cg0dK6wjlll+LdidVCwPQLvHWIl4LBjI6OAbWVux7HpqGcX 075r/rJ2mvkjvpY4df7SmlRzrtffOz7k4YhtaSlhMgxj1FPgv/zoxRWosUAHVhmyGONK 8Mw+sabCcCk7GC3CJUPs6DX3OV4uKC0yDf4VGCeSHCFNAPvqc22RFC6aF2JgSY0kFlSG LkyqWhAguKHLQ6uXCJhb0F3kFuLBZUkvZbxJ4/idQQ6X+GwhYONit9+YgeXMmbpCPMwB mraA== Received: by 10.50.219.194 with SMTP id pq2mr8016585igc.25.1344335597529; Tue, 07 Aug 2012 03:33:17 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.87.40 with SMTP id u8csp490291igz; Tue, 7 Aug 2012 03:33:17 -0700 (PDT) Received: by 10.68.234.98 with SMTP id ud2mr13361631pbc.165.1344335596715; Tue, 07 Aug 2012 03:33:16 -0700 (PDT) Received: from mailout2.samsung.com (mailout2.samsung.com. [203.254.224.25]) by mx.google.com with ESMTP id kt9si6112560pbc.260.2012.08.07.03.33.16; Tue, 07 Aug 2012 03:33:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of kgene.kim@samsung.com designates 203.254.224.25 as permitted sender) client-ip=203.254.224.25; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of kgene.kim@samsung.com designates 203.254.224.25 as permitted sender) smtp.mail=kgene.kim@samsung.com Received: from epcpsbgm1.samsung.com (mailout2.samsung.com [203.254.224.25]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0M8D0098ERYZ2J40@mailout2.samsung.com>; Tue, 07 Aug 2012 19:33:15 +0900 (KST) X-AuditID: cbfee61a-b7f616d000004b7e-fd-5020eeeb4b36 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 52.C6.19326.BEEE0205; Tue, 07 Aug 2012 19:33:15 +0900 (KST) Received: from DOKGENEKIM03 ([12.23.119.152]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0M8D00FRBRZFA830@mmp2.samsung.com>; Tue, 07 Aug 2012 19:33:15 +0900 (KST) From: Kukjin Kim To: 'Tushar Behera' , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: s.hauer@pengutronix.de, patches@linaro.org References: <1344333546-16995-1-git-send-email-tushar.behera@linaro.org> In-reply-to: <1344333546-16995-1-git-send-email-tushar.behera@linaro.org> Subject: RE: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig Date: Tue, 07 Aug 2012 19:33:15 +0900 Message-id: <098f01cd7488$0d66d630$28348290$%kim@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac10g32T4AWU0Y5rSSmDrnk9nuMJqgAAjOnA Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrALMWRmVeSWpSXmKPExsVy+t9jQd3X7xQCDJacF7eYcvgLi0X7371s Dkwed67tYQtgjOKySUnNySxLLdK3S+DK6Do9m7Xgs1TFzsczmRsYl4h1MXJySAiYSFyZ+o0Z whaTuHBvPVsXIxeHkMB0RokVi88xQTh/GSVaZzWyg1SxCWhIHH7/DMwWESiUeH2qhxXEZhbQ k5i++S+YLSTgITF3wjsWEJtTwFPiwY9Oxi5GDg5hAX+JR50FICaLgKrEiQeaIBW8ArYSZ+81 skHYghI/Jt9jgZioJbF+53EmCFteYvOat8wgrRIC6hKP/uqCmCICRhJ/GgQhKkQk9r14xziB UWgWkkGzkAyahWTQLCQtCxhZVjGKphYkFxQnpeca6hUn5haX5qXrJefnbmIEh/MzqR2MKxss DjEKcDAq8fBOkFUIEGJNLCuuzD3EKMHBrCTCe3gnUIg3JbGyKrUoP76oNCe1+BCjNAeLkjiv sfdXfyGB9MSS1OzU1ILUIpgsEwenFDAeVrAtKP9jc6j5/pUtLCsUjXdv2fxYZKP4zE1cu/J3 njQsW910qq5vrrvm//vczG7MZit3MAVr7KxyOdDcsP/Wdi+H/fu9ZlgkJkjt3q1pfj7XwcVo qtVZnkMWH2WUs1tL9L4clc07eVn6bXHG9wVzeuvCve79yxFxZOe7uEtCj/VQofv7wiwlluKM REMt5qLiRADN4VeKYwIAAA== X-TM-AS-MML: No X-Gm-Message-State: ALoCoQkRpV5+dsMMxB7zmzwJjKsR16BLfLjVvEOR6Lod5+bUcvyj5VbcGYQ4spwC3sAMQ+bT+x7T Tushar Behera wrote: > > Commit 2663e766c56a "ARM Samsung: Move s3c pwm driver to pwm framework" > moved Samsung PWM driver to drivers/pwm and the config option to select > this driver has changed. > > This patch fixes following build-error with s3c2410_defconfig. > arch/arm/mach-s3c24xx/mach-rx1950.c:430: undefined reference to > `pwm_config' > Yes, need to fix... arch/arm/mach-s3c24xx/built-in.o: In function `rx1950_lcd_power': arch/arm/mach-s3c24xx/mach-rx1950.c:430: undefined reference to `pwm_config' arch/arm/mach-s3c24xx/mach-rx1950.c:431: undefined reference to `pwm_disable' arch/arm/mach-s3c24xx/mach-rx1950.c:437: undefined reference to `pwm_config' arch/arm/mach-s3c24xx/mach-rx1950.c:438: undefined reference to `pwm_enable' arch/arm/mach-s3c24xx/built-in.o: In function `rx1950_backlight_exit': arch/arm/mach-s3c24xx/mach-rx1950.c:504: undefined reference to `pwm_free' arch/arm/mach-s3c24xx/built-in.o: In function `rx1950_backlight_init': arch/arm/mach-s3c24xx/mach-rx1950.c:487: undefined reference to `pwm_request' > Signed-off-by: Tushar Behera > --- > arch/arm/mach-s3c24xx/Kconfig | 4 ++-- > arch/arm/plat-samsung/Kconfig | 3 ++- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig > index e249611..d56b0f7 100644 > --- a/arch/arm/mach-s3c24xx/Kconfig > +++ b/arch/arm/mach-s3c24xx/Kconfig > @@ -483,7 +483,7 @@ config MACH_NEO1973_GTA02 > select I2C > select POWER_SUPPLY > select MACH_NEO1973 > - select S3C2410_PWM > + select S3C24XX_PWM > select S3C_DEV_USB_HOST > help > Say Y here if you are using the Openmoko GTA02 / Freerunner GSM > Phone > @@ -493,7 +493,7 @@ config MACH_RX1950 > select S3C24XX_DCLK > select PM_H1940 if PM > select I2C > - select S3C2410_PWM > + select S3C24XX_PWM > select S3C_DEV_NAND > select S3C2410_IOTIMING if S3C2440_CPUFREQ > select S3C2440_XTAL_16934400 > diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig > index 7aca31c..9c3b90c 100644 > --- a/arch/arm/plat-samsung/Kconfig > +++ b/arch/arm/plat-samsung/Kconfig > @@ -403,7 +403,8 @@ config S5P_DEV_USB_EHCI > > config S3C24XX_PWM > bool "PWM device support" > - select HAVE_PWM > + select PWM > + select PWM_SAMSUNG > help > Support for exporting the PWM timer blocks via the pwm device > system > -- > 1.7.4.1 I think, following would be better? Or ... --- Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig index 7aca31c..dcdfb77 100644 --- a/arch/arm/plat-samsung/Kconfig +++ b/arch/arm/plat-samsung/Kconfig @@ -403,7 +403,7 @@ config S5P_DEV_USB_EHCI config S3C24XX_PWM bool "PWM device support" - select HAVE_PWM + select PWM help Support for exporting the PWM timer blocks via the pwm device system diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig index 8fc3808..34c8ec1 100644 --- a/drivers/pwm/Kconfig +++ b/drivers/pwm/Kconfig @@ -59,7 +59,7 @@ config PWM_PXA config PWM_SAMSUNG tristate "Samsung pwm support" - depends on PLAT_SAMSUNG + def_bool PLAT_SAMSUNG help Generic PWM framework driver for Samsung. ---