mbox series

[v8,0/2] arm64: dts: fsd: Add Ethernet support for FSD SoC

Message ID 20250307044904.59077-1-swathi.ks@samsung.com
Headers show
Series arm64: dts: fsd: Add Ethernet support for FSD SoC | expand

Message

Swathi K S March 7, 2025, 4:49 a.m. UTC 
FSD platform has two instances of EQoS IP, one is in FSYS0 block and
another one is in PERIC block. This patch series add required DT file
modifications for the same.

Changes since v1:
1. Addressed the format related corrections.
2. Addressed the MAC address correction.

Changes since v2:
1. Corrected intendation issues.

Changes since v3:
1. Removed alias names of ethernet nodes

Changes since v4:
1. Added more details to the commit message as per review comment.

Changes since v5:
1. Avoided inserting node in the end and inserted it in between as per
address.
2. Changed the node label.
3. Separating DT patches from net patches and posting in different
branches.

Changes since v6:
1. Addressed Andrew's review comment and removed phy-mode from .dtsi to
.dts

Changes since v7:
1. Addressed Russell's review comment-Implemented clock tree setup in DT

Swathi K S (2):
  arm64: dts: fsd: Add Ethernet support for FSYS0 Block of FSD SoC
  arm64: dts: fsd: Add Ethernet support for PERIC Block of FSD SoC

 arch/arm64/boot/dts/tesla/fsd-evb.dts      |  20 ++++
 arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 112 +++++++++++++++++++++
 arch/arm64/boot/dts/tesla/fsd.dtsi         |  50 +++++++++
 3 files changed, 182 insertions(+)

Comments

Swathi K S March 18, 2025, 10:52 a.m. UTC | #1 
> -----Original Message-----
> From: Swathi K S <swathi.ks@samsung.com>
> Sent: 07 March 2025 10:19
> To: krzk+dt@kernel.org; linux-fsd@tesla.com; robh@kernel.org;
> conor+dt@kernel.org; richardcochran@gmail.com;
> alim.akhtar@samsung.com
> Cc: jayati.sahu@samsung.com; swathi.ks@samsung.com; linux-arm-
> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> netdev@vger.kernel.org; pankaj.dubey@samsung.com;
> ravi.patel@samsung.com; gost.dev@samsung.com
> Subject: [PATCH v8 0/2] arm64: dts: fsd: Add Ethernet support for FSD SoC
> 
> FSD platform has two instances of EQoS IP, one is in FSYS0 block and another
> one is in PERIC block. This patch series add required DT file modifications for
> the same.
> 
> Changes since v1:
> 1. Addressed the format related corrections.
> 2. Addressed the MAC address correction.
> 
> Changes since v2:
> 1. Corrected intendation issues.
> 
> Changes since v3:
> 1. Removed alias names of ethernet nodes
> 
> Changes since v4:
> 1. Added more details to the commit message as per review comment.
> 
> Changes since v5:
> 1. Avoided inserting node in the end and inserted it in between as per
> address.
> 2. Changed the node label.
> 3. Separating DT patches from net patches and posting in different branches.
> 
> Changes since v6:
> 1. Addressed Andrew's review comment and removed phy-mode from .dtsi
> to .dts
> 
> Changes since v7:
> 1. Addressed Russell's review comment-Implemented clock tree setup in DT
> 

Hi, 
The DT binding and driver patches corresponding to this patch is now reflecting in linux-next
https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/diff/Documentation/devicetree/bindings/net/tesla,fsd-ethqos.yaml?id=f654ead4682a1d351d4d780b1b59ab02477b1185

Could you consider these DT file patches for review/merge or do I need to resend these?

-Swathi

> Swathi K S (2):
>   arm64: dts: fsd: Add Ethernet support for FSYS0 Block of FSD SoC
>   arm64: dts: fsd: Add Ethernet support for PERIC Block of FSD SoC
> 
>  arch/arm64/boot/dts/tesla/fsd-evb.dts      |  20 ++++
>  arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 112 +++++++++++++++++++++
>  arch/arm64/boot/dts/tesla/fsd.dtsi         |  50 +++++++++
>  3 files changed, 182 insertions(+)
> 
> --
> 2.17.1
Swathi K S March 28, 2025, 8:36 a.m. UTC | #2 
> -----Original Message-----
> From: Swathi K S <swathi.ks@samsung.com>
> Sent: 18 March 2025 16:22
> To: 'krzk+dt@kernel.org' <krzk+dt@kernel.org>; 'linux-fsd@tesla.com'
> <linux-fsd@tesla.com>; 'robh@kernel.org' <robh@kernel.org>;
> 'conor+dt@kernel.org' <conor+dt@kernel.org>; 'richardcochran@gmail.com'
> <richardcochran@gmail.com>; 'alim.akhtar@samsung.com'
> <alim.akhtar@samsung.com>
> Cc: 'jayati.sahu@samsung.com' <jayati.sahu@samsung.com>; 'linux-arm-
> kernel@lists.infradead.org' <linux-arm-kernel@lists.infradead.org>; 'linux-
> samsung-soc@vger.kernel.org' <linux-samsung-soc@vger.kernel.org>;
> 'devicetree@vger.kernel.org' <devicetree@vger.kernel.org>; 'linux-
> kernel@vger.kernel.org' <linux-kernel@vger.kernel.org>;
> 'netdev@vger.kernel.org' <netdev@vger.kernel.org>;
> 'pankaj.dubey@samsung.com' <pankaj.dubey@samsung.com>;
> 'ravi.patel@samsung.com' <ravi.patel@samsung.com>;
> 'gost.dev@samsung.com' <gost.dev@samsung.com>
> Subject: RE: [PATCH v8 0/2] arm64: dts: fsd: Add Ethernet support for FSD
> SoC
> 
> 
> 
> > -----Original Message-----
> > From: Swathi K S <swathi.ks@samsung.com>
> > Sent: 07 March 2025 10:19
> > To: krzk+dt@kernel.org; linux-fsd@tesla.com; robh@kernel.org;
> > conor+dt@kernel.org; richardcochran@gmail.com;
> > alim.akhtar@samsung.com
> > Cc: jayati.sahu@samsung.com; swathi.ks@samsung.com; linux-arm-
> > kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org;
> > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> > netdev@vger.kernel.org; pankaj.dubey@samsung.com;
> > ravi.patel@samsung.com; gost.dev@samsung.com
> > Subject: [PATCH v8 0/2] arm64: dts: fsd: Add Ethernet support for FSD
> > SoC
> >
> > FSD platform has two instances of EQoS IP, one is in FSYS0 block and
> > another one is in PERIC block. This patch series add required DT file
> > modifications for the same.
> >
> > Changes since v1:
> > 1. Addressed the format related corrections.
> > 2. Addressed the MAC address correction.
> >
> > Changes since v2:
> > 1. Corrected intendation issues.
> >
> > Changes since v3:
> > 1. Removed alias names of ethernet nodes
> >
> > Changes since v4:
> > 1. Added more details to the commit message as per review comment.
> >
> > Changes since v5:
> > 1. Avoided inserting node in the end and inserted it in between as per
> > address.
> > 2. Changed the node label.
> > 3. Separating DT patches from net patches and posting in different
> branches.
> >
> > Changes since v6:
> > 1. Addressed Andrew's review comment and removed phy-mode from
> .dtsi
> > to .dts
> >
> > Changes since v7:
> > 1. Addressed Russell's review comment-Implemented clock tree setup in
> > DT
> >
> 
> Hi,
> The DT binding and driver patches corresponding to this patch is now
> reflecting in linux-next
> https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-
> next.git/diff/Documentation/devicetree/bindings/net/tesla,fsd-
> ethqos.yaml?id=f654ead4682a1d351d4d780b1b59ab02477b1185
> 

Hi reviewers, 
Could you please confirm whether this set of patches can be considered for review or should I resend them?

- Swathi

> Could you consider these DT file patches for review/merge or do I need to
> resend these?
> 
> -Swathi
> 
> > Swathi K S (2):
> >   arm64: dts: fsd: Add Ethernet support for FSYS0 Block of FSD SoC
> >   arm64: dts: fsd: Add Ethernet support for PERIC Block of FSD SoC
> >
> >  arch/arm64/boot/dts/tesla/fsd-evb.dts      |  20 ++++
> >  arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 112
> +++++++++++++++++++++
> >  arch/arm64/boot/dts/tesla/fsd.dtsi         |  50 +++++++++
> >  3 files changed, 182 insertions(+)
> >
> > --
> > 2.17.1
Krzysztof Kozlowski March 28, 2025, 9:37 a.m. UTC | #3 
On 28/03/2025 09:36, Swathi K S wrote:
> 
> 
>> -----Original Message-----
>> From: Swathi K S <swathi.ks@samsung.com>
>> Sent: 18 March 2025 16:22
>> To: 'krzk+dt@kernel.org' <krzk+dt@kernel.org>; 'linux-fsd@tesla.com'
>> <linux-fsd@tesla.com>; 'robh@kernel.org' <robh@kernel.org>;
>> 'conor+dt@kernel.org' <conor+dt@kernel.org>; 'richardcochran@gmail.com'
>> <richardcochran@gmail.com>; 'alim.akhtar@samsung.com'
>> <alim.akhtar@samsung.com>
>> Cc: 'jayati.sahu@samsung.com' <jayati.sahu@samsung.com>; 'linux-arm-
>> kernel@lists.infradead.org' <linux-arm-kernel@lists.infradead.org>; 'linux-
>> samsung-soc@vger.kernel.org' <linux-samsung-soc@vger.kernel.org>;
>> 'devicetree@vger.kernel.org' <devicetree@vger.kernel.org>; 'linux-
>> kernel@vger.kernel.org' <linux-kernel@vger.kernel.org>;
>> 'netdev@vger.kernel.org' <netdev@vger.kernel.org>;
>> 'pankaj.dubey@samsung.com' <pankaj.dubey@samsung.com>;
>> 'ravi.patel@samsung.com' <ravi.patel@samsung.com>;
>> 'gost.dev@samsung.com' <gost.dev@samsung.com>
>> Subject: RE: [PATCH v8 0/2] arm64: dts: fsd: Add Ethernet support for FSD
>> SoC
>>
>>
>>
>>> -----Original Message-----
>>> From: Swathi K S <swathi.ks@samsung.com>
>>> Sent: 07 March 2025 10:19
>>> To: krzk+dt@kernel.org; linux-fsd@tesla.com; robh@kernel.org;
>>> conor+dt@kernel.org; richardcochran@gmail.com;
>>> alim.akhtar@samsung.com
>>> Cc: jayati.sahu@samsung.com; swathi.ks@samsung.com; linux-arm-
>>> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org;
>>> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
>>> netdev@vger.kernel.org; pankaj.dubey@samsung.com;
>>> ravi.patel@samsung.com; gost.dev@samsung.com
>>> Subject: [PATCH v8 0/2] arm64: dts: fsd: Add Ethernet support for FSD
>>> SoC
>>>
>>> FSD platform has two instances of EQoS IP, one is in FSYS0 block and
>>> another one is in PERIC block. This patch series add required DT file
>>> modifications for the same.
>>>
>>> Changes since v1:
>>> 1. Addressed the format related corrections.
>>> 2. Addressed the MAC address correction.
>>>
>>> Changes since v2:
>>> 1. Corrected intendation issues.
>>>
>>> Changes since v3:
>>> 1. Removed alias names of ethernet nodes
>>>
>>> Changes since v4:
>>> 1. Added more details to the commit message as per review comment.
>>>
>>> Changes since v5:
>>> 1. Avoided inserting node in the end and inserted it in between as per
>>> address.
>>> 2. Changed the node label.
>>> 3. Separating DT patches from net patches and posting in different
>> branches.
>>>
>>> Changes since v6:
>>> 1. Addressed Andrew's review comment and removed phy-mode from
>> .dtsi
>>> to .dts
>>>
>>> Changes since v7:
>>> 1. Addressed Russell's review comment-Implemented clock tree setup in
>>> DT
>>>
>>
>> Hi,
>> The DT binding and driver patches corresponding to this patch is now
>> reflecting in linux-next
>> https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-
>> next.git/diff/Documentation/devicetree/bindings/net/tesla,fsd-
>> ethqos.yaml?id=f654ead4682a1d351d4d780b1b59ab02477b1185
>>
> 
> Hi reviewers, 
> Could you please confirm whether this set of patches can be considered for review or should I resend them?

Don't ping during merge window.

Best regards,
Krzysztof
Krzysztof Kozlowski April 8, 2025, 4:25 p.m. UTC | #4 
On Fri, 07 Mar 2025 10:19:02 +0530, Swathi K S wrote:
> FSD platform has two instances of EQoS IP, one is in FSYS0 block and
> another one is in PERIC block. This patch series add required DT file
> modifications for the same.
> 
> Changes since v1:
> 1. Addressed the format related corrections.
> 2. Addressed the MAC address correction.
> 
> [...]

Applied, thanks!

[1/2] arm64: dts: fsd: Add Ethernet support for FSYS0 Block of FSD SoC
      https://git.kernel.org/krzk/linux/c/1d62af229b18bff2430ea5dde0e129d43515e12c
[2/2] arm64: dts: fsd: Add Ethernet support for PERIC Block of FSD SoC
      https://git.kernel.org/krzk/linux/c/ebeab0be707ddcffd2b7f6ff4f9bd8e0c1c49fdd

Best regards,