| Message ID | 20240628223506.1237523-1-peter.griffin@linaro.org |
|---|---|
| Headers | show |
| Series | Add syscon-reboot and syscon-poweroff support for gs101/Pixel 6 | expand |
On Fri, 28 Jun 2024 23:35:05 +0100, Peter Griffin wrote: > Not all registers in PMU_ALIVE block support atomic set/clear operations. > GS101_SYSIP_DAT0 and GS101_SYSTEM_CONFIGURATION registers are two regs > where attempting atomic access fails. > > As documentation on exactly which registers support atomic operations is > not forthcoming. We default to atomic access, unless the register is > explicitly added to the tensor_is_atomic() function. Update the comment > to reflect this as well. > > [...] Applied, thanks! [2/3] soc: samsung: exynos-pmu: add support for PMU_ALIVE non atomic registers https://git.kernel.org/krzk/linux/c/85863cee8ce0c3f4d0010e78feb664fb26c35e95 Best regards,
Hi Krzysztof, This series adds support for syscon-reboot and syscon-poweroff to gs101/Oriole. It has been tested with reboot and poweroff commands respectively. Note the syscon-reboot/poweroff has *runtime* dependencies on the exynos-pmu and clk-gs101 patches in this series, as well as [1] which was just queued by Lee. As you are the maintainer for exynos-pmu and samsung clock drivers I've included those patches in this series. For the moment I have left out syscon-reboot-mode dt node as whilst it uses the same SYSIP_DAT0 register as exynosautov9, and setting this the reboot mode is correctly reported in the Pixel bootloader. The bootloader is also checking a scratch register in max77779 chip that isn't currently enabled upstream, and thus the bootloader doesn't actually enter fastboot. Kind regards, Peter [1] https://lore.kernel.org/linux-arm-kernel/20240621115544.1655458-1-peter.griffin@linaro.org/ Changes in v2: - Move PMUALIVE_MASK check into tensor_is_atomic() (William) - Collect up tags - rebase onto next-20240628 Peter Griffin (3): arm64: dts: exynos: gs101: add syscon-poweroff and syscon-reboot nodes soc: samsung: exynos-pmu: add support for PMU_ALIVE non atomic registers clk: samsung: gs101: mark gout_hsi2_ufs_embd_i_clk_unipro as critical arch/arm64/boot/dts/exynos/google/gs101.dtsi | 15 +++++++++++++++ drivers/clk/samsung/clk-gs101.c | 2 +- drivers/soc/samsung/exynos-pmu.c | 16 ++++++++++++++-- include/linux/soc/samsung/exynos-regs-pmu.h | 4 ++++ 4 files changed, 34 insertions(+), 3 deletions(-)