| Message ID | 20230803024645.2716057-1-ruanjinjie@huawei.com |
|---|---|
| Headers | show |
| Series | media: platform: Do not check for 0 return after calling platform_get_irq() | expand |
W dniu 3.08.2023 o 04:46, Ruan Jinjie pisze: > It is not possible for platform_get_irq() or platform_get_irq_byname() > to return 0. Use the return value from platform_get_irq() > or platform_get_irq_byname(). > > Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com> > --- > drivers/media/platform/verisilicon/hantro_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/verisilicon/hantro_drv.c b/drivers/media/platform/verisilicon/hantro_drv.c > index 35ca71b19def..423fc85d79ee 100644 > --- a/drivers/media/platform/verisilicon/hantro_drv.c > +++ b/drivers/media/platform/verisilicon/hantro_drv.c > @@ -1085,8 +1085,8 @@ static int hantro_probe(struct platform_device *pdev) > irq_name = "default"; > irq = platform_get_irq(vpu->pdev, 0); > } > - if (irq <= 0) > - return -ENXIO; > + if (irq < 0) > + return irq; > > ret = devm_request_irq(vpu->dev, irq, > vpu->variant->irqs[i].handler, 0,
There is no possible for platform_get_irq() and platform_get_irq_byname() to return 0, And the return value of platform_get_irq() or platform_get_irq_byname() is more sensible to show the error reason. Ruan Jinjie (2): media: camif-core: Do not check for 0 return after calling platform_get_irq() media: verisilicon: Do not check for 0 return after calling platform_get_irq() drivers/media/platform/samsung/s3c-camif/camif-core.c | 4 ++-- drivers/media/platform/verisilicon/hantro_drv.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)