mbox series

[v4,0/2] arm64: dts: Add SYSREG nodes for FSD SoC

Message ID 20221129115531.102932-1-sriranjani.p@samsung.com
Headers show
Series arm64: dts: Add SYSREG nodes for FSD SoC | expand

Message

Sriranjani P Nov. 29, 2022, 11:55 a.m. UTC
FSD has few system controller register blocks. This patch series intends to
add support of device node for system controller registers group that
resides in PERIC, FSYS0, FSYS1 and CAM blocks of FSD SoC. As these will
be used by PCIE, EQoS and CSI module. Patches for adding support for PCIE,
EQoS and CSI are already under review at [1], [2] and [3].

Also this patch series add required DT bindings for such system controller
of FSD SoC.

[1]: https://lkml.org/lkml/2022/11/21/463
[2]: https://lkml.org/lkml/2022/11/4/420
[3]: https://lkml.org/lkml/2022/11/20/363

These changes are made on top of Krzysztof's patches [4] posted as part of
splitting Samsung Exynos SoC SYSREG bindings to own file.

[4]: https://lkml.org/lkml/2022/11/25/370

Changes since v3:
1. As per update from Krzysztof, add dedicated compatibles for sysreg found
on FSD SoC in the exynos-sysreg.yaml file.
2. Add CAM block sysreg changes in the dtsi file and respective compatible
in binding document.

Changes since v2:
1. Updated compatibles as per improvements suggested by Krzysztof.

Changes since v1:
1. Fixed SoB in [PATCH 1/2] dt-bindings: mfd: syscon: Add tesla compatible
found on FSD SoC.
2. Address review comments from Krzysztof on [PATCH 2/2] and aligned sysreg
node near to respective blocks sorted in order of unit address.

Sriranjani P (2):
  dt-bindings: soc: samsung: exynos-sysreg: Add tesla FSD sysreg
    compatibles
  arm64: dts: fsd: add sysreg device node

 .../soc/samsung/samsung,exynos-sysreg.yaml    |  4 ++++
 arch/arm64/boot/dts/tesla/fsd.dtsi            | 20 +++++++++++++++++++
 2 files changed, 24 insertions(+)

Comments

Sriranjani P Dec. 6, 2022, 8:57 a.m. UTC | #1
Hi all,

Gentle Reminder to review this patch series.

Thanks,
Sriranjani P.

> -----Original Message-----
> From: Sriranjani P [mailto:sriranjani.p@samsung.com]
> Sent: 29 November 2022 17:25
> To: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> devicetree@vger.kernel.org; alim.akhtar@samsung.com;
> pankaj.dubey@samsung.com; ravi.patel@samsung.com;
> sathya@samsung.com
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> linux-samsung-soc@vger.kernel.org; Sriranjani P
> <sriranjani.p@samsung.com>
> Subject: [PATCH v4 0/2] arm64: dts: Add SYSREG nodes for FSD SoC
> 
> FSD has few system controller register blocks. This patch series intends to
> add support of device node for system controller registers group that resides
> in PERIC, FSYS0, FSYS1 and CAM blocks of FSD SoC. As these will be used by
> PCIE, EQoS and CSI module. Patches for adding support for PCIE, EQoS and
> CSI are already under review at [1], [2] and [3].
> 
> Also this patch series add required DT bindings for such system controller of
> FSD SoC.
> 
> [1]: https://lkml.org/lkml/2022/11/21/463
> [2]: https://lkml.org/lkml/2022/11/4/420
> [3]: https://lkml.org/lkml/2022/11/20/363
> 
> These changes are made on top of Krzysztof's patches [4] posted as part of
> splitting Samsung Exynos SoC SYSREG bindings to own file.
> 
> [4]: https://lkml.org/lkml/2022/11/25/370
> 
> Changes since v3:
> 1. As per update from Krzysztof, add dedicated compatibles for sysreg found
> on FSD SoC in the exynos-sysreg.yaml file.
> 2. Add CAM block sysreg changes in the dtsi file and respective compatible in
> binding document.
> 
> Changes since v2:
> 1. Updated compatibles as per improvements suggested by Krzysztof.
> 
> Changes since v1:
> 1. Fixed SoB in [PATCH 1/2] dt-bindings: mfd: syscon: Add tesla compatible
> found on FSD SoC.
> 2. Address review comments from Krzysztof on [PATCH 2/2] and aligned
> sysreg node near to respective blocks sorted in order of unit address.
> 
> Sriranjani P (2):
>   dt-bindings: soc: samsung: exynos-sysreg: Add tesla FSD sysreg
>     compatibles
>   arm64: dts: fsd: add sysreg device node
> 
>  .../soc/samsung/samsung,exynos-sysreg.yaml    |  4 ++++
>  arch/arm64/boot/dts/tesla/fsd.dtsi            | 20 +++++++++++++++++++
>  2 files changed, 24 insertions(+)
> 
> --
> 2.17.1
Krzysztof Kozlowski Dec. 6, 2022, 10:07 a.m. UTC | #2
On 06/12/2022 09:57, Sriranjani P wrote:
> Hi all,
> 
> Gentle Reminder to review this patch series.
> 

If you ping me, then:
1. Pinging after a week is a bit too fast. Standard is 2 weeks.
2. It is too late in the cycle for me to pick it up. I will take it
after the merge window. Anything sent after rc5 usually misses upcoming
merge window.

Best regards,
Krzysztof
Krzysztof Kozlowski Dec. 26, 2022, 3:17 p.m. UTC | #3
On Tue, 29 Nov 2022 17:25:29 +0530, Sriranjani P wrote:
> FSD has few system controller register blocks. This patch series intends to
> add support of device node for system controller registers group that
> resides in PERIC, FSYS0, FSYS1 and CAM blocks of FSD SoC. As these will
> be used by PCIE, EQoS and CSI module. Patches for adding support for PCIE,
> EQoS and CSI are already under review at [1], [2] and [3].
> 
> Also this patch series add required DT bindings for such system controller
> of FSD SoC.
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: soc: samsung: exynos-sysreg: Add tesla FSD sysreg compatibles
      https://git.kernel.org/krzk/linux/c/7e03ca7429b23105b740eb79364dc410f214848b
[2/2] arm64: dts: fsd: add sysreg device node
      https://git.kernel.org/krzk/linux/c/beaf55952d46fb14387d92de280bed7985ea85e5

Best regards,