| Message ID | 20220816133016.77553-1-krzysztof.kozlowski@linaro.org |
|---|---|
| Headers | show |
| Series | pinctrl/arm: dt-bindings: deprecate header with register constants | expand |
On Tue, 16 Aug 2022 16:30:14 +0300, Krzysztof Kozlowski wrote: > Changes since v3 > ================ > 1. Add patch 1 - bindings example fixes. > 2. All dependencies were merged, so this can go via Samsung pinctrl tree. > > Changes since v2 > ================ > 1. Split last bindings patch per driver changes and bindings. > 2. Add tags. > > [...] Applied, thanks! [1/2] dt-bindings: pinctrl: samsung: stop using bindings header with constants https://git.kernel.org/pinctrl/samsung/c/df805304a820ed10fc3d038dd64b85821c9ee606 [2/2] dt-bindings: pinctrl: samsung: deprecate header with register constants https://git.kernel.org/pinctrl/samsung/c/9d9292576810d0b36897718c24dfbc1a2835314b Best regards,
Hi, Changes since v3 ================ 1. Add patch 1 - bindings example fixes. 2. All dependencies were merged, so this can go via Samsung pinctrl tree. Changes since v2 ================ 1. Split last bindings patch per driver changes and bindings. 2. Add tags. Changes since v1 ================ 1. Correct title (in the comment) of each header (Chanho). 2. Patch #7: Adjust warning message. 3. Add tags. Description =========== The Samsung pin controller drivers were always expecting DTS to use raw register values for pin configuration (e.g. pull up/down, drive strength). DTS had these values hard-coded all over, so at some point we decided for convenience to move them to dt-bindings header. Less code duplication, some meaning added to raw number, etc. However these constants do not fit the purpose of bindings. They do not provide any abstraction, any hardware and driver independent ID. With minor exceptions, the Linux drivers actually do not use the bindings header at all. Because of this "dt-bindings ID" approach, these constants were re-used between chips, e.g. Exynos ones in S5PV210. These does not make much sense because the values between Exynos and S5PV210 (or S3C24xx) are not related. If it was an abstraction ID, this would be fine. But it's not. Clean this up by: 1. Moving the constants to DTS-local headers. 2. Deprecating the bindings header. Tested by comparing DTBs (dtx_diff, fdtdump). Best regards, Krzysztof Krzysztof Kozlowski (2): dt-bindings: pinctrl: samsung: stop using bindings header with constants dt-bindings: pinctrl: samsung: deprecate header with register constants .../pinctrl/samsung,pinctrl-pins-cfg.yaml | 1 - .../bindings/pinctrl/samsung,pinctrl.yaml | 63 ++++++++----------- include/dt-bindings/pinctrl/samsung.h | 7 +++ 3 files changed, 34 insertions(+), 37 deletions(-)