mbox series

[0/4] support watchdog for exynosautov9

Message ID 20220520121750.71473-1-chanho61.park@samsung.com
Headers show
Series support watchdog for exynosautov9 | expand

Message

Chanho Park May 20, 2022, 12:17 p.m. UTC 
This adds to support watchdog and its device tree nodes for Exynos Auto
v9 SoC. Like exynos850, the SoC has two cpu watchdog devices but they
have different CPU configurations compared with exynos850. So, we need
to add separate configurations for Exynos Auto v9 SoC.

Chanho Park (4):
  dt-bindings: watchdog: add exynosautov9 compatible
  watchdog: s3c2410_wdt: support exynosautov9 watchdog
  arm64: dts: exynosautov9: add watchdog DT nodes
  arm64: dts: exynosautov9-sadk: enable watchdog devices

 .../bindings/watchdog/samsung-wdt.yaml        |  3 ++
 .../boot/dts/exynos/exynosautov9-sadk.dts     |  8 ++++
 arch/arm64/boot/dts/exynos/exynosautov9.dtsi  | 22 ++++++++++
 drivers/watchdog/s3c2410_wdt.c                | 41 +++++++++++++++++--
 4 files changed, 70 insertions(+), 4 deletions(-)

Comments

Krzysztof Kozlowski May 20, 2022, 12:52 p.m. UTC | #1 
On 20/05/2022 14:17, Chanho Park wrote:
> Adds "samsung,exynosautov9-wdt" to samsung-wdt compatible. This has two
> cpu watchdogs like exynos850.
> 
> Signed-off-by: Chanho Park <chanho61.park@samsung.com>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof
Krzysztof Kozlowski May 20, 2022, 12:58 p.m. UTC | #2 
On 20/05/2022 14:17, Chanho Park wrote:
> Adds two cpu watchdog devices for ExynosAutov9 SoC.
> 
> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> ---
>  arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 22 ++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
> index 3e23db8f09d9..34be955dc2d5 100644
> --- a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
> @@ -400,6 +400,28 @@ ufs_0: ufs0@17e00000 {
>  			samsung,sysreg = <&syscon_fsys2 0x710>;
>  			status = "disabled";
>  		};
> +
> +		watchdog_cl0: watchdog@10050000 {
> +			compatible = "samsung,exynosautov9-wdt";
> +			reg = <0x10050000 0x100>;
> +			interrupts = <GIC_SPI 476 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&cmu_peris CLK_GOUT_WDT_CLUSTER0>, <&xtcxo>;
> +			clock-names = "watchdog", "watchdog_src";
> +			samsung,syscon-phandle = <&pmu_system_controller>;
> +			samsung,cluster-index = <0>;
> +			status = "disabled";

Blocks which do not need board-level resources should be enabled by
default, so drop status and drop patch #4.

Best regards,
Krzysztof
Chanho Park May 23, 2022, 11:30 a.m. UTC | #3 
> > diff --git a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
> > b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
> > index 3e23db8f09d9..34be955dc2d5 100644
> > --- a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
> > +++ b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
> > @@ -400,6 +400,28 @@ ufs_0: ufs0@17e00000 {
> >  			samsung,sysreg = <&syscon_fsys2 0x710>;
> >  			status = "disabled";
> >  		};
> > +
> > +		watchdog_cl0: watchdog@10050000 {
> > +			compatible = "samsung,exynosautov9-wdt";
> > +			reg = <0x10050000 0x100>;
> > +			interrupts = <GIC_SPI 476 IRQ_TYPE_LEVEL_HIGH>;
> > +			clocks = <&cmu_peris CLK_GOUT_WDT_CLUSTER0>, <&xtcxo>;
> > +			clock-names = "watchdog", "watchdog_src";
> > +			samsung,syscon-phandle = <&pmu_system_controller>;
> > +			samsung,cluster-index = <0>;
> > +			status = "disabled";
> 
> Blocks which do not need board-level resources should be enabled by
> default, so drop status and drop patch #4.

Okay. They can be enabled as default. I'll drop the status and #4 patch as well.

Best Regards,
Chanho Park