mbox series

[v2,0/2] i2c: exynos5: add support for ExynosAutov9 SoC

Message ID 20211111084327.106696-1-jaewon02.kim@samsung.com
Headers show
Series i2c: exynos5: add support for ExynosAutov9 SoC | expand

Message

Jaewon Kim Nov. 11, 2021, 8:43 a.m. UTC 
Serial IPs(UART, I2C, SPI) are integrated into New IP-Core
called USI(Universal Serial Interface).

As it is integrated into USI, there are additinal HW changes.
Registers to control USI and sysreg to set serial IPs have been added.
Also, some timing registres have been changed.

Changes in v2:
 - Changes compatible name to "samsung,exynosautov9-hsi2c"
 - Changes I2C type name to "I2C_TYPE_EXYNOSAUTOV9" from "I2C_TYPE_USI"
 - Changes to clear after reset instread of clearing reset
 - Add description about system register for USI

Jaewon Kim (2):
  dt-bindings: i2c: exynos5: add exynosautov9-hsi2c compatible
  i2c: exynos5: add support for ExynosAutov9 SoC

 .../devicetree/bindings/i2c/i2c-exynos5.txt   |   7 +
 drivers/i2c/busses/i2c-exynos5.c              | 133 ++++++++++++++++--
 2 files changed, 130 insertions(+), 10 deletions(-)

Comments

Krzysztof Kozlowski Nov. 11, 2021, 8:53 a.m. UTC | #1 
On 11/11/2021 09:43, Jaewon Kim wrote:
> This patch adds new "samsung,exynosautov9-hsi2c" compatible.
> It is for i2c compatible with HSI2C available on Exynos SoC with USI.
> 
> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> ---
>  Documentation/devicetree/bindings/i2c/i2c-exynos5.txt | 7 +++++++
>  1 file changed, 7 insertions(+)
> 

You did not Cc the necessary lists (devicetree). Please use
scripts/get_maintainers.pl to get list of addresses to CC.

Patch itself looks good, so you can resend with:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>


Best regards,
Krzysztof
Jaewon Kim Nov. 11, 2021, 9:11 a.m. UTC | #2 
Hello Krzysztof

> On 11/11/2021 09:43, Jaewon Kim wrote:
> > This patch adds new "samsung,exynosautov9-hsi2c" compatible.
> > It is for i2c compatible with HSI2C available on Exynos SoC with USI.
> >
> > Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> > ---
> >  Documentation/devicetree/bindings/i2c/i2c-exynos5.txt | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> 
> You did not Cc the necessary lists (devicetree). Please use scripts/get_maintainers.pl to get list of
> addresses to CC.
> 
> Patch itself looks good, so you can resend with:
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> 
> 
> Best regards,
> Krzysztof

Thanks.
I will add more CC lists in next.